Openbravo Issue Tracking System - Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0038991 | Modules | Advanced Warehouse Operations | public | 2018-07-19 12:20 | 2018-09-24 10:00 |
|
| Reporter | dmiguelez | |
| Assigned To | dmiguelez | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Regression date | |
| Regression introduced by commit | |
| Regression level | |
| Review Assigned To | guilleaer |
| Support ticket | |
| OBNetwork customer | |
| Regression introduced in release | |
|
| Summary | 0038991: Do not log unnecessary exceptions in Errors While Processing Tasks Window |
| Description | Do not log unnecessary exceptions in Errors While Processing Tasks Window.
There are some expected exceptions that should not be logged in this Window, because the user does not need to perform further actions:
- Error when there is no Task to Confirm in a Group of Tasks
- Error when a confirmed Task is being updated
- Error when trying to process a confirmed Task
This exceptions should be handled but not logged in this window. |
| Steps To Reproduce | With AWO and AWO SampleData installed
Log in as AWO QA Admin
Go to Purchase Order Window and create a new record with:
- Organization: US West Coast
- Business Partner: Be Soft Drinker
- Warehouse: US West Coast
Move to Lines Tab and create a new record with:
- Product: Ale Beer
- Operative Quantity: 10
Book the document
Click on Receive button and assign the Task to Openbravo. Click on Done.
Now it is necessary to open a new Tab in Front End mode and have both BE and FE open at the same time.
In FE the Task should be shown.
In BE, move to Task tab under the Lines and click on Confirm and done.
In the FE click on confirm.
A pop up shows noticing that an exception has happened.
In the Backend, there is an entry in the Errors While Processing Tasks window related to this Task.
This should not happen, this error should not be logged in this window. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  38991ProposedSolution.diff (4,104) 2018-07-19 12:21
https://issues.openbravo.com/file_download.php?file_id=11978&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-07-19 12:20 | dmiguelez | New Issue | |
| 2018-07-19 12:20 | dmiguelez | Assigned To | => dmiguelez |
| 2018-07-19 12:21 | dmiguelez | File Added: 38991ProposedSolution.diff | |
| 2018-07-25 09:36 | VictorVillar | Resolution time | => 1535666400 |
| 2018-08-06 14:25 | Sandrahuguet | Resolution time | 1535666400 => |
| 2018-08-14 10:28 | VictorVillar | Resolution time | => 1535666400 |
| 2018-09-07 14:42 | guilleaer | Note Added: 0106642 | |
| 2018-09-07 14:43 | guilleaer | Note Edited: 0106642 | bug_revision_view_page.php?bugnote_id=0106642#r17611 |
| 2018-09-17 17:15 | hgbot | Checkin | |
| 2018-09-17 17:15 | hgbot | Note Added: 0106813 | |
| 2018-09-17 17:15 | hgbot | Status | new => resolved |
| 2018-09-17 17:15 | hgbot | Resolution | open => fixed |
| 2018-09-17 17:15 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a777a2e3e4fe67ed6c93208492070157ca915357 [^] |
| 2018-09-17 17:15 | hgbot | Checkin | |
| 2018-09-17 17:15 | hgbot | Note Added: 0106814 | |
| 2018-09-17 17:15 | hgbot | Checkin | |
| 2018-09-17 17:15 | hgbot | Note Added: 0106815 | |
| 2018-09-17 17:16 | dmiguelez | Review Assigned To | => guilleaer |
| 2018-09-17 18:51 | hgbot | Checkin | |
| 2018-09-17 18:51 | hgbot | Note Added: 0106820 | |
| 2018-09-18 10:17 | hgbot | Checkin | |
| 2018-09-18 10:17 | hgbot | Note Added: 0106828 | |
| 2018-09-18 10:17 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a777a2e3e4fe67ed6c93208492070157ca915357 [^] => http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/e873fc39b8cc01e0a460c393fa038d32e1462048 [^] |
| 2018-09-18 10:17 | hgbot | Checkin | |
| 2018-09-18 10:17 | hgbot | Note Added: 0106829 | |
| 2018-09-18 10:17 | hgbot | Checkin | |
| 2018-09-18 10:17 | hgbot | Note Added: 0106830 | |
| 2018-09-18 10:17 | hgbot | Checkin | |
| 2018-09-18 10:17 | hgbot | Note Added: 0106831 | |
| 2018-09-24 09:59 | hgbot | Checkin | |
| 2018-09-24 09:59 | hgbot | Note Added: 0106948 | |
| 2018-09-24 10:00 | hgbot | Checkin | |
| 2018-09-24 10:00 | hgbot | Note Added: 0106949 | |
| 2018-09-24 10:00 | guilleaer | Status | resolved => closed |
| 2022-09-06 17:18 | caristu | Category | Advance Warehouse Operations => Advanced Warehouse Operations |
|
Notes |
|
|
(0106642)
|
|
guilleaer
|
2018-09-07 14:42
(edited on: 2018-09-07 14:43) |
|
After the fix of issue 39039 errors which comes from OBException are saved in error while importing with the flag BLOCKS = false.
Only errors which make sense to be shown to the user should be saved in errors while importing. Those which blocks the task should have the flag BLOCKS = true and those who just want to inform with BLOCKS = false
Ex:
Delta generation problem -> User should see the error, but the task should not be blocked
Problem confirming task because an stock issue -> User should see the error and the task should be blocked
Task already confirmed -> should not be saved, neither shown to the user.
|
|
|
|
(0106813)
|
|
hgbot
|
|
2018-09-17 17:15
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a777a2e3e4fe67ed6c93208492070157ca915357
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 17 12:20:18 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a777a2e3e4fe67ed6c93208492070157ca915357 [^]
Fixes Issue 38991. Allow to decide if an exception is going to be
saved and if it is going to block the current Task
* Added two flags in OBAWOExcpetion class, Blocks and Save
This flags allows to state if the exception will be saved
and, if so, if it will block the current Task until the
exception is fixed
* Changed OBException with OBAWOException for
- Exception when Group of Tasks does not have any Task to process
- Not possible to update Task because it is already processed
* Save OBAWOException with no Blocks flag for
- Delta Management exception
- Trying to confirm an already confirmed Task
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/DeltaManagerDifferent.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksConfirmator.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/TaskEventObserver.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskProcessor.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/sync/AWODataSynchronizationErrorHandler.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/OBAWOException.java
---
|
|
|
|
(0106814)
|
|
hgbot
|
|
2018-09-17 17:15
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 222efbc4e293d03c8bc03caf6fb600dc7810a6fd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 17 16:15:15 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/222efbc4e293d03c8bc03caf6fb600dc7810a6fd [^]
Related to Issue 38991. Refactor of method to reduce
cognitive complexity.
* Split method into smaller ones
* Remove clutter
* Add final modifiers to variables
* Set proper names
* Add missing Override annotation
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/sync/AWODataSynchronizationErrorHandler.java
---
|
|
|
|
(0106815)
|
|
hgbot
|
|
2018-09-17 17:15
|
|
|
|
|
(0106820)
|
|
hgbot
|
|
2018-09-17 18:51
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 1ae17678d0ed6fc784d6d250f935f6c951788278
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Sep 17 18:50:37 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1ae17678d0ed6fc784d6d250f935f6c951788278 [^]
Related to issue 38991: Fix some small errors related to error management
* Add picking list columns (now grouping can come also from picking)
* Fix some typos
* Fix error when grouping document is retrieved from db
---
M src-db/database/model/tables/OBAWO_ERRORS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/ReceptionListProcessor.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/sync/AWODataSynchronizationErrorHandler.java
---
|
|
|
|
(0106828)
|
|
hgbot
|
|
2018-09-18 10:17
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: e873fc39b8cc01e0a460c393fa038d32e1462048
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 17 12:20:18 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/e873fc39b8cc01e0a460c393fa038d32e1462048 [^]
Fixes Issue 38991. Allow to decide if an exception is going to be
saved and if it is going to block the current Task
* Added two flags in OBAWOExcpetion class, Blocks and Save
This flags allows to state if the exception will be saved
and, if so, if it will block the current Task until the
exception is fixed
* Changed OBException with OBAWOException for
- Exception when Group of Tasks does not have any Task to process
- Not possible to update Task because it is already processed
* Save OBAWOException with no Blocks flag for
- Delta Management exception
- Trying to confirm an already confirmed Task
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/DeltaManagerDifferent.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/centralbroker/GroupOfTasksConfirmator.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/eventobserver/TaskEventObserver.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/TaskProcessor.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/sync/AWODataSynchronizationErrorHandler.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/utils/OBAWOException.java
---
|
|
|
|
(0106829)
|
|
hgbot
|
|
2018-09-18 10:17
|
|
|
|
|
(0106830)
|
|
hgbot
|
|
2018-09-18 10:17
|
|
|
|
|
(0106831)
|
|
hgbot
|
|
2018-09-18 10:17
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 296b88f1dca498d8905ae847d250c0c0ee2e6341
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Sep 17 18:50:37 2018 +0200
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/296b88f1dca498d8905ae847d250c0c0ee2e6341 [^]
Related to issue 38991: Fix some small errors related to error management
* Add picking list columns (now grouping can come also from picking)
* Fix some typos
* Fix error when grouping document is retrieved from db
---
M src-db/database/model/tables/OBAWO_ERRORS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/processors/ReceptionListProcessor.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/sync/AWODataSynchronizationErrorHandler.java
---
|
|
|
|
(0106948)
|
|
hgbot
|
|
2018-09-24 09:59
|
|
|
|
|
(0106949)
|
|
hgbot
|
|
2018-09-24 10:00
|
|
|