Notes |
|
(0107304)
|
vmromanos
|
2018-10-15 15:01
(edited on: 2018-10-24 13:33) |
|
Before this design defect the behavior is the following:
In Sales Order:
1. It shows an error when closing a sales order with open tasks
2. It shows an error if there are allocated reservations linked to the order
In both cases the order can't be closed till the user manually fixes these situations.
In Distribution Order:
The system allows to close a distribution with open reservations and/or tasks.
This design defect must try to fix this mismatch.
Proposed solution:
Implement the current behavior found in Sales Order to Distribution Order.
Create a new preference (disabled by default) called "Delete tasks & reservations when closing Document". If enable it will automatically delete the related tasks and reservations linked to the SO/DO at closing document time.
This preference might have different values per document
In DO module add a hook when processing a DO (to be executed from "draft -> book" and from "booked -> close").
In DO for AWO module implement the hook to delete non-closed tasks linked to the DO. This should automatically delete any linked reservation. Please double check.
In DO module implement the hook to release any open reservation linked to the DO line (that won't be linked to any task).
For Sales Order, instead of creating a hook, it will be necessary to directly implement an extension point (http://wiki.openbravo.com/wiki/How_to_use_an_Extension_Point [^]) on C_Order_Post to delete any related task.
Reservations should be already released when closing the order.
|
|
|
|
Test plan 1. Closing DO with non confirmed picking tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Close the document
8. Verify the document was closed
Test plan 2. Closing DO with confirmed picking tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Close the document
9. Verify the document was closed
Test plan 3. Closing DO with non confirmed issue tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Close the document
10. Verify the document was closed
Test plan 4. Closing DO with confirmed issue tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing DO" preference
3. Create a Distribution Order Issue
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Confirm issue tasks
10. Close the document
11. Verify the document was closed
Test plan 5. Closing Sales Order with non confirmed picking tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Close the document
8. Verify the document was closed
Test plan 6. Closing Sales Order with confirmed picking tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Close the document
9. Verify the document was closed
Test plan 7. Closing Sales Order with non confirmed issue tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Close the document
10. Verify the document was closed
Test plan 8. Closing Sales Order with confirmed issue tasks
1. Log as AWO QA Admin
2. Set "Delete tasks and reservations when closing SO" preference
3. Create a Sales Order
4. Add a line of product
5. Complete the document
6. Generate picking tasks.
7. Confirm picking tasks
8. Generate issue tasks
9. Confirm issue tasks
10. Close the document
11. Verify the document was closed |
|
|
(0107669)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 8cbc638247e89a93e0dbafa220a642a7b9876b08
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 12:02:24 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/8cbc638247e89a93e0dbafa220a642a7b9876b08 [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new preference has been added to point out open reservations sould be
released, and non confirmed tasks should be removed, when closing a
Sales Order.
- The expension point OBAWO_CLOSE_ORDER_EP has been modified to, when closing
the order, remove non confirmed tasks linked to sales order lines if
preference is set; otherwise an exception is thrown.
- A new extension point has been created to be executed at the beginning of
order proccesing, to, when closing the order, release all open reservations
linked to sales order lines.
- Automated tests have been added.
---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
|
|
|
(0107670)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 757558f2ac882ed6e474f555951012752ac7918e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:40:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/757558f2ac882ed6e474f555951012752ac7918e [^]
Related to issue 38911: Code review improvements
OBAWO_CLOSE_ORDER_BEFORE_EP: Simplified update query, avoiding to query once again the m_reservation_stock table.
OBAWO_CLOSE_ORDER_EP: Added missing documentation. Use <> 'CL' to support new non-closed statuses in the future
AD_REF_LIST: Removed blank space in the name
---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
|
|
|
(0107671)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/mods/org.openbravo.distributionorder
Changeset: 11b34e901a1c9b520f544538259cd0025739699d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:23:08 2018 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/11b34e901a1c9b520f544538259cd0025739699d [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new hook was created to be executed after the Distribution Order has been
processed.
- A new hook implementation was added to release all open reservations linked
to Distribution Order lines, when closing the Distribution Order.
- Automated tests were updated
---
M src-test/org/openbravo/distributionorder/test/OBDO_FB_WeldBaseTest.java
M src-test/org/openbravo/distributionorder/test/utils/DistributionOrderTestUtils.java
M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
A src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107672)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/mods/org.openbravo.distributionorder
Changeset: b4cd74947fdcd7175b07f571eb50272155e1e58a
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:47 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/b4cd74947fdcd7175b07f571eb50272155e1e58a [^]
Related to issue 38911: Code review improvements
ProcessDistributionOrderUtil:
* Declare as public the DocActions, as they might be interesting for the hooks
* Pass the docAction to the hooks
AfterDistributionOrderProcessedHook:
* Pass docAction to the methods isValid() and run()
* Created method isBeingClosed() useful for the hooks implementation
AfterDistributionOrderProcessedHookRunner:
* Implement new AfterDistributionOrderProcessedHook API
AfterOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* isValid() calls the isBeingClosed() method
* Proper class javadoc
---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107673)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: b92e6eb41047b1a042f89293be295405a71d6837
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:26:05 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/b92e6eb41047b1a042f89293be295405a71d6837 [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new preference has been added to point out open reservations sould be
released, and non confirmed tasks should be removed, when closing a
Distribution Order.
- A new hook implementation has been added to remove all non confimed tasks
linked to Distribution Order lines, when closing a Distribution Order.
---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTestSuite.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
A src-db/database/sourcedata/AD_REF_LIST.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107674)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: beddffa5b19750cab949140f7911e02ebf53b898
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:49 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/beddffa5b19750cab949140f7911e02ebf53b898 [^]
Related to issue 38911: Code review improvements
Avoid to duplicate utility methods that are already available at the DO module.
AfterAWODistributionOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* Run flush() only if necessary
* Clear session inside the tasks loop
* Use <> 'CL' to support new non-closed statuses in the future
* Proper class javadoc
---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107675)
|
hgbot
|
2018-10-30 17:45
|
|
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 4499478bcb9b08166a9c9365518d57fc2b2d60e5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 17:28:47 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/4499478bcb9b08166a9c9365518d57fc2b2d60e5 [^]
Related to issue 38911: Code review improvements II
Avoid to load too many objects in memory. Instead only the affected records are loaded.
Properly support tasks behaving as group with RI.
Note that it is necessary to delete the tasks (or the group of tasks document) through Hibernate (not directly using SQL) because it's necessary to launch the EventObserves on those entities
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107685)
|
hgbot
|
2018-10-31 10:08
|
|
Repository: erp/mods/org.openbravo.distributionorder
Changeset: 51d2fe865c7e58ebb6e7cff17b1c345d4601b837
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:02:56 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/51d2fe865c7e58ebb6e7cff17b1c345d4601b837 [^]
Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks
---
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107686)
|
hgbot
|
2018-10-31 10:08
|
|
Repository: erp/mods/org.openbravo.distributionorder
Changeset: 1f2f60b596e3b7deebb21aff694178043bb70226
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:20:14 2018 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.distributionorder/rev/1f2f60b596e3b7deebb21aff694178043bb70226 [^]
Related to issue 38911: Renamed hook to make it clear
---
A src/org/openbravo/distributionorder/hooks/implementation/AfterDOProcessedHook.java
R src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107687)
|
hgbot
|
2018-10-31 10:08
|
|
|
|
(0107688)
|
hgbot
|
2018-10-31 10:09
|
|
|
|
(0107689)
|
hgbot
|
2018-10-31 10:09
|
|
|
|
(0107690)
|
hgbot
|
2018-10-31 10:09
|
|
|
|
(0107694)
|
hgbot
|
2018-10-31 10:49
|
|
|
|
(0107732)
|
hgbot
|
2018-11-05 11:51
|
|
|
|
(0107733)
|
hgbot
|
2018-11-05 11:51
|
|
|
|
(0107739)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 8bc3d3972fdfc6abc3b9940b6f1670f65b323527
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 13:23:08 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/8bc3d3972fdfc6abc3b9940b6f1670f65b323527 [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new hook was created to be executed after the Distribution Order has been
processed.
- A new hook implementation was added to release all open reservations linked
to Distribution Order lines, when closing the Distribution Order.
- Automated tests were updated
---
M src-test/org/openbravo/distributionorder/test/OBDO_FB_WeldBaseTest.java
M src-test/org/openbravo/distributionorder/test/utils/DistributionOrderTestUtils.java
M src/org/openbravo/distributionorder/actionHandler/ProcessDistributionOrder.java
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
A src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
A src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107740)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 1f0d98bf420ece164b835e6ad47376c79547984c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:47 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/1f0d98bf420ece164b835e6ad47376c79547984c [^]
Related to issue 38911: Code review improvements
ProcessDistributionOrderUtil:
* Declare as public the DocActions, as they might be interesting for the hooks
* Pass the docAction to the hooks
AfterDistributionOrderProcessedHook:
* Pass docAction to the methods isValid() and run()
* Created method isBeingClosed() useful for the hooks implementation
AfterDistributionOrderProcessedHookRunner:
* Implement new AfterDistributionOrderProcessedHook API
AfterOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* isValid() calls the isBeingClosed() method
* Proper class javadoc
---
M src/org/openbravo/distributionorder/erpCommon/utility/ProcessDistributionOrderUtil.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107741)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder
Changeset: 9a9a2b4952d6439a0c8d6fa7b8ee108a15480e00
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Oct 31 09:02:56 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.distributionorder/rev/9a9a2b4952d6439a0c8d6fa7b8ee108a15480e00 [^]
Related to issue 38911: Avoid OptimisticLockException
Set an order to execute the hooks
---
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHook.java
M src/org/openbravo/distributionorder/hooks/AfterDistributionOrderProcessedHookRunner.java
M src/org/openbravo/distributionorder/hooks/implementation/AfterOrderProcessedHook.java
---
|
|
|
(0107742)
|
hgbot
|
2018-11-05 18:14
|
|
|
|
(0107743)
|
hgbot
|
2018-11-05 18:14
|
|
|
|
(0107745)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: f0c4fe046c0c1275f23203de2b58ad3957f482ef
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Fri Oct 19 12:02:24 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/f0c4fe046c0c1275f23203de2b58ad3957f482ef [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new preference has been added to point out open reservations sould be
released, and non confirmed tasks should be removed, when closing a
Sales Order.
- The expension point OBAWO_CLOSE_ORDER_EP has been modified to, when closing
the order, remove non confirmed tasks linked to sales order lines if
preference is set; otherwise an exception is thrown.
- A new extension point has been created to be executed at the beginning of
order proccesing, to, when closing the order, release all open reservations
linked to sales order lines.
- Automated tests have been added.
---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOx_CloseSalesOrder.java
---
|
|
|
(0107744)
|
hgbot
|
2018-11-05 18:14
|
|
|
|
(0107746)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: b25a50b7c2a95a38373cae717f287c43173fc61c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:40:16 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/b25a50b7c2a95a38373cae717f287c43173fc61c [^]
Related to issue 38911: Code review improvements
OBAWO_CLOSE_ORDER_BEFORE_EP: Simplified update query, avoiding to query once again the m_reservation_stock table.
OBAWO_CLOSE_ORDER_EP: Added missing documentation. Use <> 'CL' to support new non-closed statuses in the future
AD_REF_LIST: Removed blank space in the name
---
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_BEFORE_EP.xml
M src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
|
|
|
(0107747)
|
hgbot
|
2018-11-05 18:14
|
|
|
|
(0107748)
|
hgbot
|
2018-11-05 18:14
|
|
|
|
(0107749)
|
hgbot
|
2018-11-05 18:14
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 745af9b736717908833010c562be9cf14851cc6a
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed Oct 31 10:39:14 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/745af9b736717908833010c562be9cf14851cc6a [^]
Fixes issue 38911: Close Order with open reservations and non confirmed tasks.
- A new preference has been added to point out open reservations sould be
released, and non confirmed tasks should be removed, when closing a
Distribution Order.
- A new hook implementation has been added to remove all non confimed tasks
linked to Distribution Order lines, when closing a Distribution Order.
---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTestSuite.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
A src-db/database/sourcedata/AD_REF_LIST.xml
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107750)
|
hgbot
|
2018-11-05 18:15
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 4ebc2bd5cef7115c9f7156c82113a852f543e8c0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 12:46:49 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/4ebc2bd5cef7115c9f7156c82113a852f543e8c0 [^]
Related to issue 38911: Code review improvements
Avoid to duplicate utility methods that are already available at the DO module.
AfterAWODistributionOrderProcessedHook:
* Implement new AfterDistributionOrderProcessedHook API
* Run flush() only if necessary
* Clear session inside the tasks loop
* Use <> 'CL' to support new non-closed statuses in the future
* Proper class javadoc
---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOAWOCloseDistributionOrder.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTests.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107751)
|
hgbot
|
2018-11-05 18:15
|
|
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 30741e0d503c829f09d1fef16dd99dc20bf1162c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Oct 30 17:28:47 2018 +0100
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/30741e0d503c829f09d1fef16dd99dc20bf1162c [^]
Related to issue 38911: Code review improvements II
Avoid to load too many objects in memory. Instead only the affected records are loaded.
Properly support tasks behaving as group with RI.
Note that it is necessary to delete the tasks (or the group of tasks document) through Hibernate (not directly using SQL) because it's necessary to launch the EventObserves on those entities
---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/hook/AfterAWODistributionOrderProcessedHook.java
---
|
|
|
(0107752)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
(0107753)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
(0107754)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
(0107755)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
(0107756)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
(0107757)
|
hgbot
|
2018-11-05 18:15
|
|
|
|
|
Code review + testing OK.
Fixed in:
AWO 1.3.600 or higher
AWO DO 1.2.300 or higher
DO 1.2.300 or higher |
|
|
(0107817)
|
hgbot
|
2018-11-09 09:41
|
|
|
|
(0107819)
|
hgbot
|
2018-11-09 09:52
|
|
|
|
(0107820)
|
hgbot
|
2018-11-09 09:52
|
|
|
|
(0107821)
|
hgbot
|
2018-11-09 09:52
|
|
|
|
(0107936)
|
hgbot
|
2018-11-15 17:39
|
|
|
|
(0107937)
|
hgbot
|
2018-11-15 17:39
|
|
|