Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038907Openbravo ERP01. General setuppublic2018-07-05 18:142018-08-08 13:06
Reporterplujan 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelQA functional test
Regression date2018-06-28
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/ed73bce3ae3b093cba0908df13b6ffabb73f6564 [^]
Triggers an Emergency PackNo
Summary0038907: DB errors which several OB messages are not correctly parsed in PG
DescriptionWhen creating a Sales Order and one of the lines contains a product that has been marked as "Obsolete" the error message on booking the order says:

"Error: Please verify its PLM Status"
Steps To Reproduce1. Having a product marked as Obsolete in its PLM Status, create a new Sales Order
2. Add several lines containing active products and one line containing the obsolete one.
3. Try to book the order. The message shown does not point out which was the obsolete product, making the message not practical. See attached screenshot.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0033940 new Triage Platform Base [SERQA 1558 ]When Postgres database is configured in French the unique message is not found in Openbravo's ad_message 
depends on backport 00390803.0PR18Q3 closed caristu DB errors which several OB messages are not correctly parsed in PG 
depends on backport 00390813.0PR18Q2.2 closed caristu DB errors which several OB messages are not correctly parsed in PG 
caused by defect 0038827 closed caristu Some trigger error messages are not shown nicely when using PostgreSQL version 10 (shows part of technical error) 
related to defect 0038855 closed alostale Error in 'Purchase Order Report' is not user friendly 
Attached Filespng PLM-ErrorMessage.png (57,823) 2018-07-05 18:14
https://issues.openbravo.com/file_download.php?file_id=11938&type=bug
png

png Selection_269.png (36,406) 2018-08-02 08:56
https://issues.openbravo.com/file_download.php?file_id=12023&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-07-05 18:14plujanNew Issue
2018-07-05 18:14plujanAssigned To => Triage Finance
2018-07-05 18:14plujanFile Added: PLM-ErrorMessage.png
2018-07-05 18:14plujanModules => Core
2018-07-05 18:14plujanTriggers an Emergency Pack => No
2018-07-05 18:25plujanNote Added: 0105653
2018-07-27 01:32collazoandy4Assigned ToTriage Finance => collazoandy4
2018-07-27 01:32collazoandy4Statusnew => scheduled
2018-08-01 14:45SandrahuguetAssigned Tocollazoandy4 => platform
2018-08-01 16:49alostaleStatusscheduled => acknowledged
2018-08-02 08:56alostaleRelationship addedrelated to 0033940
2018-08-02 08:56alostaleFile Added: Selection_269.png
2018-08-02 08:56alostaleStatusacknowledged => scheduled
2018-08-02 09:10alostaleNote Added: 0106094
2018-08-02 09:12alostaleRelationship addedcaused by 0038827
2018-08-02 09:17alostaleRegression level => QA functional test
2018-08-02 09:17alostaleRegression date => 2018-06-28
2018-08-02 09:17alostaleRegression introduced in release => 3.0PR17Q3
2018-08-02 09:17alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/ed73bce3ae3b093cba0908df13b6ffabb73f6564 [^]
2018-08-02 09:17alostaleStatusscheduled => feedback
2018-08-02 09:18alostaleStatusfeedback => new
2018-08-02 09:18alostaleSummary[PR18Q3] [PLM] Error message when including an obsolete product is not clear => DB errors which several OB messages are not correctly parsed in PG
2018-08-02 09:19alostaleStatusnew => scheduled
2018-08-02 09:26alostaleAssigned Toplatform => caristu
2018-08-02 09:26alostalePrioritynormal => immediate
2018-08-02 09:45alostaleRegression introduced in release3.0PR17Q3 => main
2018-08-02 10:26alostaleRelationship addedrelated to 0038855
2018-08-02 13:18hgbotCheckin
2018-08-02 13:18hgbotNote Added: 0106115
2018-08-02 13:18hgbotStatusscheduled => resolved
2018-08-02 13:18hgbotResolutionopen => fixed
2018-08-02 13:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3bdec175d94119ce31aa03d6bc74a2b67531cb48 [^]
2018-08-02 13:18hgbotCheckin
2018-08-02 13:18hgbotNote Added: 0106116
2018-08-02 13:20caristuReview Assigned To => AugustoMauch
2018-08-03 12:57AugustoMauchNote Added: 0106158
2018-08-03 12:57AugustoMauchStatusresolved => closed
2018-08-03 12:57AugustoMauchFixed in Version => 3.0PR18Q4
2018-08-08 13:06hudsonbotCheckin
2018-08-08 13:06hudsonbotNote Added: 0106237
2018-08-08 13:06hudsonbotCheckin
2018-08-08 13:06hudsonbotNote Added: 0106238

Notes
(0105653)
plujan   
2018-07-05 18:25   
When a product is in Ramp Down status and its stock is 0, the message is also missing informative text.
(0106094)
alostale   
2018-08-02 09:10   
In Oracle it works properly, it fails only in PG.
(0106115)
hgbot   
2018-08-02 13:18   
Repository: erp/devel/pi
Changeset: 3bdec175d94119ce31aa03d6bc74a2b67531cb48
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Aug 02 13:03:20 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3bdec175d94119ce31aa03d6bc74a2b67531cb48 [^]

fixes bug 38907: PG error text parser is not translating properly some messages

  Fix for issue 0038827 was not taking into accout the possibility of having multiple translatable elements (text surrounded by @) in the same error message.

  Therefore, it has been restored the previous regular expression, and we are now directly stripping the part that contains the technical information of a trigger failure from the DB message returned by PostgreSQL.

---
M src/org/openbravo/erpCommon/utility/ErrorTextParserPOSTGRE.java
---
(0106116)
hgbot   
2018-08-02 13:18   
Repository: erp/devel/pi
Changeset: f78e4433d0cc5abf9a24919e66be1ca474ba3d7e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Aug 02 13:16:08 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f78e4433d0cc5abf9a24919e66be1ca474ba3d7e [^]

related to issue 38907: add test case

  - Extracted the test that reproduces some particular scenarios to test the error parsing into new ErrorTextParserIntegrationTest test class.
  - Use the ErrorTextParserTest to keep just those tests that directly test the parsing/translation of error string messages.

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/AllQuickAntTaskTests.java
M src-test/src/org/openbravo/test/AntTaskTests.java
M src-test/src/org/openbravo/test/system/ErrorTextParserTest.java
A src-test/src/org/openbravo/test/system/ErrorTextParserIntegrationTest.java
---
(0106158)
AugustoMauch   
2018-08-03 12:57   
Code reviewed and verified
(0106237)
hudsonbot   
2018-08-08 13:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test
(0106238)
hudsonbot   
2018-08-08 13:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test