Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038879Openbravo ERP02. Master data managementpublic2018-06-19 19:272018-07-04 15:52
Reportergsuarez 
Assigned Tocollazoandy4 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR18Q2.1Fixed in Version3.0PR18Q2.1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-09-07
Regression introduced in release3.0PR17Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/9ba0cfebdf14fb6bf6dec4a657674975d16373a2 [^]
Triggers an Emergency PackYes
Summary0038879: the process "Create price list" increases the product price incrementally
DescriptionRun several times "Create price list" only calculates the price of one product and the other leaves you the same. That is, applying the process many times over the same version, modifies the price of one of the products incrementally.

I can send a video if needed
Steps To Reproduce1. create price list
2. activate checks: default,Sales price list and Price ioncludes Tax
3. create price list version:
                             3.1 create Price list schema
                             3.2 create two lines with two different products
                                 that belong to the same product category
                             3.3 set Unit price discount% = -50
4. assign the previous Price list schema to the version
5. set base version (Default)the version must be of purchase, without activated checks.
6.  click "Create price list" and acept
7.  create the price list well
8.  click again on the button and this modify the price of one of the products
9.  click again on the button
10. the process modifies again the price of one of the products
attached video
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038792 closed collazoandy4 the process "Create price list" increases the product price incrementally 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-07-03 10:29SandrahuguetTypedefect => backport
2018-07-03 10:29SandrahuguetTarget Version => 3.0PR18Q2.1
2018-07-04 15:23hgbotCheckin
2018-07-04 15:23hgbotNote Added: 0105580
2018-07-04 15:23hgbotStatusscheduled => resolved
2018-07-04 15:23hgbotResolutionopen => fixed
2018-07-04 15:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q2.1/rev/fceb997950391f3169102335ccb942832080aaa0 [^]
2018-07-04 15:23hgbotCheckin
2018-07-04 15:23hgbotNote Added: 0105581
2018-07-04 15:52SandrahuguetReview Assigned To => Sandrahuguet
2018-07-04 15:52SandrahuguetNote Added: 0105588
2018-07-04 15:52SandrahuguetStatusresolved => closed
2018-07-04 15:52SandrahuguetFixed in Version => 3.0PR18Q2.1

Notes
(0105580)
hgbot   
2018-07-04 15:23   
Repository: erp/backports/3.0PR18Q2.1
Changeset: fceb997950391f3169102335ccb942832080aaa0
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Jun 25 15:28:36 2018 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2.1/rev/fceb997950391f3169102335ccb942832080aaa0 [^]

Fixed issue 38879:The process "Create price list" increases the product price

The process Create Price List was increasing the product price when the price list
schema have two or more lines at product level.

Now the price list schema lines defined at product level is take into account in
the Create Price List process.

A new JUnit test was added to properly check this behavior.

A new preference was created to calculate the product price in a hierarchical way

---
M src-db/database/model/functions/M_PRICELIST_CREATE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-test/src/org/openbravo/test/pricelist/PriceListTest.java
M src-test/src/org/openbravo/test/pricelist/data/PriceListTestConstants.java
M src-test/src/org/openbravo/test/pricelist/data/PriceListTestData.java
A src-test/src/org/openbravo/test/pricelist/data/PriceListTestData17.java
---
(0105581)
hgbot   
2018-07-04 15:23   
Repository: erp/backports/3.0PR18Q2.1
Changeset: d0cc6cddbf69f8cd3b11cd20a0dc47f66cc082ab
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Jul 04 09:22:23 2018 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2.1/rev/d0cc6cddbf69f8cd3b11cd20a0dc47f66cc082ab [^]

related to issue 38879 added modulescript with default value of preference

added modulescript with default value of hierarchical price list
preference depends on the openbravo version.

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/HierarchicalPriceListPreference.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/HierarchicalPriceListPreferenceData.class
A src-util/modulescript/src/org/openbravo/modulescript/HierarchicalPriceListPreference.java
A src-util/modulescript/src/org/openbravo/modulescript/HierarchicalPriceListPreference_data.xsql
---
(0105588)
Sandrahuguet   
2018-07-04 15:52   
Code review + testing OK