Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038864Openbravo ERP07. Sales managementpublic2018-06-29 10:192018-08-08 13:06
Reporterjoniturralde93 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR18Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket2851
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038864: Problems in 'Add Details' (Payment In) when autodistribute amount property is disabled
DescriptionWindow 'Payment In', button 'Add Details'.

When 'Add Payment: Automatically distribute amounts' property is set to 'N' or there are more than 100 shown invoices (so it doesn't autodistribute anyway), if you have many selected invoices and you change the 'Actual Payment' value to the same as 'Expected Payment', 'There is a difference of' doesn't refresh automatically (it should be 0) and therefore, 'Overpayment Action' combo box doesn't dissapear. Both fields should be refreshed in real time when 'Actual Payment' is modified.
Steps To Reproduce1. Create a 'Payment In' record ('Payment Method'=Transferencia, 'Amount'=50000).
2. Set 'Add Payment: Automatically distribute amounts' property to 'N' with a preference.
3. Create some invoices, all with payment method 'Transferencia', with lines, no payments and completed, so they can be selected in 'Add Details'.
4. Click 'Add Details' for the 'Payment In' record.
5. Select some invoices.
6. Change 'Actual Payment' to 'Expected Payment' value.
7. Neither 'There is a difference of' or 'Overpayment Action' fields are refreshed ('There is a difference of' should be 0 and 'Overpayment Action' should disappear)


Point 2 works the same if you create more than 100 invoices, since system doesn't autodistribute amount when there are more than 100 records.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-29 10:19joniturralde93New Issue
2018-06-29 10:19joniturralde93Assigned To => Triage Finance
2018-06-29 10:19joniturralde93OBNetwork customer => Yes
2018-06-29 10:19joniturralde93Modules => Core
2018-06-29 10:19joniturralde93Support ticket => 2851
2018-06-29 10:19joniturralde93Resolution time => 1532037600
2018-06-29 10:19joniturralde93Triggers an Emergency Pack => No
2018-07-10 15:56SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-07-18 18:03collazoandy4Assigned ToAtulOpenbravo => collazoandy4
2018-07-18 18:04collazoandy4Statusnew => scheduled
2018-07-19 16:09collazoandy4Note Added: 0105811
2018-07-25 11:55hgbotCheckin
2018-07-25 11:55hgbotNote Added: 0105941
2018-07-25 11:55hgbotStatusscheduled => resolved
2018-07-25 11:55hgbotResolutionopen => fixed
2018-07-25 11:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4e896f3e4b174d10049a78887f0654ab514c3b70 [^]
2018-07-25 11:55dmiguelezReview Assigned To => dmiguelez
2018-07-25 11:55dmiguelezNote Added: 0105942
2018-07-25 11:55dmiguelezStatusresolved => closed
2018-07-25 11:55dmiguelezFixed in Version => 3.0PR18Q4
2018-08-08 13:06hudsonbotCheckin
2018-08-08 13:06hudsonbotNote Added: 0106229

Notes
(0105811)
collazoandy4   
2018-07-19 16:09   
Test Plan
 Go to Preference window and create a new record:
   Property: Add Payment: Automatically distribute amounts
   Value: N
 Create some invoices pending to be paid
 Go to Payment In window and create a new record:
   Payment Method: Transferencia
   Amount: 50000
   Clic on Add Details button
     Select some invoices and change Actual Payment to Expected Payment value.
     Check There is a difference of and Overpayment Action fields are updated.


Test Plan II
  Repeat the previous test plan with Add Payment: Automatically distribute amounts preference value to Y

Test Plan III
  Repeat the two previous tests plan with more than 100 invoices pending to be paid.
(0105941)
hgbot   
2018-07-25 11:55   
Repository: erp/devel/pi
Changeset: 4e896f3e4b174d10049a78887f0654ab514c3b70
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 18 23:32:49 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/4e896f3e4b174d10049a78887f0654ab514c3b70 [^]

Fixes issue 38864: Problems in 'Add Details' (Payment In) when autodistribute
amount property is disabled

When 'Add Payment: Automatically distribute amounts' property is set to 'N' or
there are more than 100 shown invoices, if you have many selected invoices and
you change the 'Actual Payment' value to the same as 'Expected Payment',
'There is a difference of' doesn't refresh automatically (it should be 0) and
therefore, 'Overpayment Action' combo box doesn't dissapear. Both fields should
be refreshed in real time when 'Actual Payment' is modified.

Now the fields are properly updated even if the amount doesn't distribute
automatically

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0105942)
dmiguelez   
2018-07-25 11:55   
Code Review + Testing Ok
(0106229)
hudsonbot   
2018-08-08 13:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bfd7a414183a [^]
Maturity status: Test