Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038819Retail ModulesWeb POSpublic2018-06-04 12:372018-06-25 12:32
Reporterjavietxe 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q2.1Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038819: SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property
DescriptionWith the change introduced in https://issues.openbravo.com/view.php?id=37727, [^] the loaded property has to be equal to the last updated date from the order. As the data is coming from external systems, is very likely to have differences in the data, so the payment will be rejected.
Steps To ReproduceAdd a payment from the external order loader with date older than the last modification of the order.
Proposed SolutionThe proposed solution is to disable the concurrency check in the external order loader requests, because we cannot assume that the external tools will be able to send the originally loaded updated from the original order.

(Implemented in the attached patch)
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038692 closed marvintm SERQA 4142: The payments from ecommerce are not integrated because of the "loaded" property 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-22 14:17marvintmTypedefect => backport
2018-06-22 14:17marvintmTarget Version => RR18Q2.1
2018-06-22 14:22hgbotCheckin
2018-06-22 14:22hgbotNote Added: 0105346
2018-06-22 14:22hgbotStatusscheduled => resolved
2018-06-22 14:22hgbotResolutionopen => fixed
2018-06-22 14:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77ac4acecd1fd8ffcfe34a9a36ae4b454243f9e6 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/8d04f2c80d829613cfd9a85d5a066eb980889505 [^]
2018-06-25 12:32migueldejuanaNote Added: 0105356
2018-06-25 12:32migueldejuanaStatusresolved => closed

Notes
(0105346)
hgbot   
2018-06-22 14:22   
Repository: retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal
Changeset: 8d04f2c80d829613cfd9a85d5a066eb980889505
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 22 14:21:59 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/8d04f2c80d829613cfd9a85d5a066eb980889505 [^]

Fixed issue 38819. The payments from ecommerce are not integrated because of the loaded property.
Concurrency check will be disabled in the ExternalOrderLoader because we cannot guarantee that the external tools will be able to send the same 'loaded' property as the WebPOS in all cases.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0105356)
migueldejuana   
2018-06-25 12:32   
Reviewed