Openbravo Issue Tracking System - Modules
View Issue Details
0038803ModulesAdvanced Warehouse Operationspublic2018-06-21 11:282018-09-20 10:23
dmiguelez 
dmiguelez 
highmajoralways
closedfixed 
5
 
 
vmromanos
0038803: Not possible to Issue a Sales Order after it has been Boxed (and a Picking has been done first)
For a Sales Order that has been picked, the quantity is Boxed, afterwards it is not possible to Issue it
With AWO SampleData installed

Go to Warehouse Operations Window and filter by US West Coast Warehouse and SHP301 Bin
For all the records that appear in the window, loop through them and remove the Tasks that appear in the Task Tab

Go to Warehouse Definition Window and select US West Coast Warehouse
Move to Storage Bin Tab and select SHP301 Bin
Click on Change Status and select Available. Click on Done

Go to Sales Order Window and create a new record with:
  - Organization: US
  - Business Partner: Healthy Food Supermarkets
  - Warehouse: US West Coast
Move to lines Tab and create a new record with:
  - Product: Apple
  - Operative Quantity: 10
Book the Document
Click on Pick and Done
Move to Task Tab under the lines and set 5 as confirmed quantity
Click on Confirm and Done

Move to Warehouse Operations Window and filter to see the stock of the Product Apple that is located in SHP301 Bin
Click on Box and select Big Box as Referenced Inventory Type and SHP301 as Storage Bin. Click on Done.
Move to the Task Tab below and confirm the Task

Move back to Sales Order Window and click on Issue
The following error message is shown:
No Batch of Tasks document was created
With AWO SampleData installed

Go to Sales Order Window and create a new record with:
  - Organization: US
  - Business Partner: Healthy Food Supermarkets
  - Warehouse: US West Coast
Move to lines and create a new record with:
  - Product: Apple
  - Operative Quantity: 10
Book the document
Click on Pick and Done
Move to the Task Tab under the lines and set 5 as confirmed Quantity.
Click on Confirm and Done (Make sure that Delta Response is Same in the Confirm PopUp)
Move to the header and click on Issue
Move again to the Task Tab and confirm the Issue Task

Confirm the pending Picking Task
Move to Warehouse Operations Window and filter to see the stock of the Product Apple that is located in SHP301 Bin
Click on Box and select Big Box as Referenced Inventory Type and SHP301 as Storage Bin. Click on Done.
Move to the Task Tab below and confirm the Task

Go back to Sales Order window and click on Issue
Move to the Task Tab and confirm the existing Issue Task (check in the Expected Attribute that the Stock is included in a Box)
No tags attached.
related to defect 0038352 closed vmromanos Cannot Issue a partially issued sales order, there are errors with reserved stock 
related to defect 0038802 closed dmiguelez Not possible to Issue a DO after a partial Issue has been done first 
Issue History
2018-06-21 11:28dmiguelezNew Issue
2018-06-21 11:28dmiguelezAssigned To => dmiguelez
2018-06-21 11:30dmiguelezRelationship addedrelated to 0038352
2018-06-21 11:30dmiguelezRelationship addedrelated to 0038802
2018-06-21 11:36hgbotCheckin
2018-06-21 11:36hgbotNote Added: 0105296
2018-06-21 11:36hgbotStatusnew => resolved
2018-06-21 11:36hgbotResolutionopen => fixed
2018-06-21 11:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/318b9474a3517e4d016aca4e7ba8686365177dc7 [^]
2018-06-21 11:40hgbotCheckin
2018-06-21 11:40hgbotNote Added: 0105298
2018-06-21 17:00hgbotCheckin
2018-06-21 17:00hgbotNote Added: 0105310
2018-06-21 17:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/318b9474a3517e4d016aca4e7ba8686365177dc7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^]
2018-06-21 17:00hgbotCheckin
2018-06-21 17:00hgbotNote Added: 0105312
2018-06-21 17:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/ceedfcc75cc4ef99a78136ab4aeabc8286608a02 [^]
2018-06-21 17:01vmromanosReview Assigned To => vmromanos
2018-06-21 17:01vmromanosNote Added: 0105314
2018-06-21 17:01vmromanosStatusresolved => closed
2018-07-19 17:50hgbotCheckin
2018-07-19 17:50hgbotNote Added: 0105813
2018-08-30 10:19hgbotCheckin
2018-08-30 10:19hgbotNote Added: 0106530
2018-09-14 14:56hgbotCheckin
2018-09-14 14:56hgbotNote Added: 0106778
2018-09-20 10:23hgbotCheckin
2018-09-20 10:23hgbotNote Added: 0106872
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0105296)
hgbot   
2018-06-21 11:36   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 318b9474a3517e4d016aca4e7ba8686365177dc7
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 21 11:36:43 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/318b9474a3517e4d016aca4e7ba8686365177dc7 [^]

Fixes Issue 38803: Allow to Issue a SO that has been boxed

Changed query that retrieves the reservations associated to a
Sales Order Line to correctly choose the existing reservation

* When a Picking is done, an allocated reservation is created and
  when the Picking is confirmed, the reservation remains but it is
  un-linked to the Picking Task
* When creating a Box, the attributeSetValue id is changed
* This means that, the part of the query that retrieves the reservations
  previously associated to the Picking Task must check for the
  correct attribute
  * The one from the Reservation
  * Or the Parent of the one from the Reservation (the Parent is the
    original attribute of something that has been boxed)

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/IssueSalesOrder_ITTAlgorithmDao.java
---
(0105298)
hgbot   
2018-06-21 11:40   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 128237c5054f464d24b6d482c4ed0f48acddd822
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 21 11:40:32 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/128237c5054f464d24b6d482c4ed0f48acddd822 [^]

Fixes Issue 38802: Allow to Issue a DO that has been partially issued

The problem was that the query was trying to create an Issue Task for
stock that is in a pending to confirm Picking Task. This ones should be
ommited.

But also needs to support same scenario as of issue 38803: Allow to
Issue something thas has been Picked and then Boxed

* Chaned 'or not exists' parte of the query to 'and not exists' and take into
  account the status of the Task to exclude the stock that is in a
  not confirmed Picking Task

Also:

* When a Picking is done, an allocated reservation is created and
  when the Picking is confirmed, the reservation remains but it is
  un-linked to the Picking Task
* When creating a Box, the attributeSetValue id is changed
* This means that, the part of the query that retrieves the reservations
  previously associated to the Picking Task must check for the
  correct attribute
  * The one from the Reservation
  * Or the Parent of the one from the Reservation (the Parent is the
    original attribute of something that has been boxed)

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithmDao.java
---
(0105310)
hgbot   
2018-06-21 17:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0feffb760782bf7dde617e32b94a13bc0d74a1c5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 21 16:53:02 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^]

Fixed bug 38802 Fixed bug 38803: code review improvements

Centralized all the common logic related to the Issue in a new abstract class IssueITTDao.
Concrete implementations of this class must override several methods that point to the right document l
ine property (in task and reservation) and to the right picking and issue ITT ids.

At this point the Distribution Order and Sales Order issue implement this class.

The old static methods in *Dao class have been replaced by normal methods. The dao object is now injected directly to the class that consumes it.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/IssueSalesOrder_ITTAlgorithm.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/IssueSalesOrder_ITTAlgorithmDao.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/dao/IssueITTDao.java
---
(0105312)
hgbot   
2018-06-21 17:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: ceedfcc75cc4ef99a78136ab4aeabc8286608a02
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 21 16:53:06 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/ceedfcc75cc4ef99a78136ab4aeabc8286608a02 [^]

Fixed bug 38802 Fixed bug 38803: code review improvements

Centralized all the common logic related to the Issue in a new abstract class IssueITTDao.
Concrete implementations of this class must override several methods that point to the right document l
ine property (in task and reservation) and to the right picking and issue ITT ids.

At this point the Distribution Order and Sales Order issue implement this class.

The old static methods in *Dao class have been replaced by normal methods. The dao object is now injected directly to the class that consumes it.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithm.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithmDao.java
---
(0105314)
vmromanos   
2018-06-21 17:01   
Code review + testing OK
(0105813)
hgbot   
2018-07-19 17:50   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: bff2766aa81da526b089ac7bae9b2ac2fc743210
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Sun Jul 15 16:16:58 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/bff2766aa81da526b089ac7bae9b2ac2fc743210 [^]

Adds automated test for issue 38803

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOt_Issue38803Test.java
---
(0106530)
hgbot   
2018-08-30 10:19   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a40238d2533609fd493dc2468fead2d5b442f94d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Sun Jul 15 16:16:58 2018 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/a40238d2533609fd493dc2468fead2d5b442f94d [^]

Adds automated test for issue 38803

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOt_Issue38803Test.java
---
(0106778)
hgbot   
2018-09-14 14:56   
Repository: retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: a40238d2533609fd493dc2468fead2d5b442f94d
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Sun Jul 15 16:16:58 2018 -0400
URL: http://code.openbravo.com/retail/backports/AWO/3.0RR18Q3/org.openbravo.warehouse.advancedwarehouseoperations/rev/a40238d2533609fd493dc2468fead2d5b442f94d [^]

Adds automated test for issue 38803

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOTestSuite.java
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/test/AWOt_Issue38803Test.java
---
(0106872)
hgbot   
2018-09-20 10:23   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata
Changeset: a7053e519924b4f5f20dc76056816fba4cb748c9
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Sep 20 09:49:39 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/rev/a7053e519924b4f5f20dc76056816fba4cb748c9 [^]

[AWO Tests] Added new data for test for issue 38803

---
M referencedata/sampledata/AWO_QA/C_ORDER.xml
M referencedata/sampledata/AWO_QA/C_ORDERLINE.xml
M referencedata/sampledata/AWO_QA/C_ORDERLINETAX.xml
M referencedata/sampledata/AWO_QA/C_ORDERTAX.xml
M referencedata/sampledata/AWO_QA/C_ORDER_DISCOUNT.xml
---