Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038802ModulesAdvanced Warehouse Operationspublic2018-06-21 11:242018-09-20 10:23
Reporterdmiguelez 
Assigned Todmiguelez 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0038802: Not possible to Issue a DO after a partial Issue has been done first
DescriptionIf a partial Issue for a DO has already been done, it is not possible to Issue the pending quantity
Steps To ReproduceWith AWO SampleData installed

Go to Distribution Order Issue window and create a new record with:
  - Organization: US
  - Warehouse Issue: US West Coast
  - Warehouse Receipt: US East Coast
Move to lines and create a new record with:
  - Product: Apple
  - Operative Quantity: 10
Book the document
Click on Pick and Done
Move to the Task Tab under the lines and set 5 as confirmed Quantity.
Click on Confirm and Done (Make sure that Delta Response is Same in the Confirm PopUp)
Move to the header and click on Issue
The following error message is shown:
No Routing Assignment found for: Warehouse: US West Coast. Product: Apple. Quantity: 5. Attribute: Few_Red. Inventory Transaction Type: Issue Distribution Order
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038352 closed vmromanos Cannot Issue a partially issued sales order, there are errors with reserved stock 
related to defect 0038803 closed dmiguelez Not possible to Issue a Sales Order after it has been Boxed (and a Picking has been done first) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-21 11:24dmiguelezNew Issue
2018-06-21 11:24dmiguelezAssigned To => dmiguelez
2018-06-21 11:24dmiguelezNote Added: 0105295
2018-06-21 11:25dmiguelezRelationship addedrelated to 0038352
2018-06-21 11:30dmiguelezRelationship addedrelated to 0038803
2018-06-21 11:40hgbotCheckin
2018-06-21 11:40hgbotNote Added: 0105299
2018-06-21 11:40hgbotStatusnew => resolved
2018-06-21 11:40hgbotResolutionopen => fixed
2018-06-21 11:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/128237c5054f464d24b6d482c4ed0f48acddd822 [^]
2018-06-21 17:00hgbotCheckin
2018-06-21 17:00hgbotNote Added: 0105309
2018-06-21 17:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/128237c5054f464d24b6d482c4ed0f48acddd822 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^]
2018-06-21 17:00hgbotCheckin
2018-06-21 17:00hgbotNote Added: 0105311
2018-06-21 17:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/ceedfcc75cc4ef99a78136ab4aeabc8286608a02 [^]
2018-06-21 17:01vmromanosReview Assigned To => vmromanos
2018-06-21 17:01vmromanosNote Added: 0105313
2018-06-21 17:01vmromanosStatusresolved => closed
2018-09-20 10:23hgbotCheckin
2018-09-20 10:23hgbotNote Added: 0106870
2018-09-20 10:23hgbotCheckin
2018-09-20 10:23hgbotNote Added: 0106871
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0105295)
dmiguelez   
2018-06-21 11:24   
Test Plan:

With AWO SampleData installed

Go to Distribution Order Issue window and create a new record with:
  - Organization: US
  - Warehouse Issue: US West Coast
  - Warehouse Receipt: US East Coast
Move to lines and create a new record with:
  - Product: Apple
  - Operative Quantity: 10
Book the document
Click on Pick and Done
Move to the Task Tab under the lines and set 5 as confirmed Quantity.
Click on Confirm and Done (Make sure that Delta Response is Same in the Confirm PopUp)
Move to the header and click on Issue
Move again to the Task Tab and confirm the Issue Task

Confirm the pending Picking Task
Move to Warehouse Operations Window and filter to see the stock of the Product Apple that is located in SHP301 Bin
Click on Box and select Big Box as Referenced Inventory Type and SHP301 as Storage Bin. Click on Done.
Move to the Task Tab below and confirm the Task

Go back to Distribution Order Issue window and click on Issue
Move to the Task Tab and confirm the existing Issue Task (check in the Expected Attribute that the Stock is included in a Box)
(0105299)
hgbot   
2018-06-21 11:40   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 128237c5054f464d24b6d482c4ed0f48acddd822
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 21 11:40:32 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/128237c5054f464d24b6d482c4ed0f48acddd822 [^]

Fixes Issue 38802: Allow to Issue a DO that has been partially issued

The problem was that the query was trying to create an Issue Task for
stock that is in a pending to confirm Picking Task. This ones should be
ommited.

But also needs to support same scenario as of issue 38803: Allow to
Issue something thas has been Picked and then Boxed

* Chaned 'or not exists' parte of the query to 'and not exists' and take into
  account the status of the Task to exclude the stock that is in a
  not confirmed Picking Task

Also:

* When a Picking is done, an allocated reservation is created and
  when the Picking is confirmed, the reservation remains but it is
  un-linked to the Picking Task
* When creating a Box, the attributeSetValue id is changed
* This means that, the part of the query that retrieves the reservations
  previously associated to the Picking Task must check for the
  correct attribute
  * The one from the Reservation
  * Or the Parent of the one from the Reservation (the Parent is the
    original attribute of something that has been boxed)

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithmDao.java
---
(0105309)
hgbot   
2018-06-21 17:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 0feffb760782bf7dde617e32b94a13bc0d74a1c5
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 21 16:53:02 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/0feffb760782bf7dde617e32b94a13bc0d74a1c5 [^]

Fixed bug 38802 Fixed bug 38803: code review improvements

Centralized all the common logic related to the Issue in a new abstract class IssueITTDao.
Concrete implementations of this class must override several methods that point to the right document l
ine property (in task and reservation) and to the right picking and issue ITT ids.

At this point the Distribution Order and Sales Order issue implement this class.

The old static methods in *Dao class have been replaced by normal methods. The dao object is now injected directly to the class that consumes it.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/IssueSalesOrder_ITTAlgorithm.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/implementation/IssueSalesOrder_ITTAlgorithmDao.java
A src/org/openbravo/warehouse/advancedwarehouseoperations/ittalgorithm/dao/IssueITTDao.java
---
(0105311)
hgbot   
2018-06-21 17:00   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: ceedfcc75cc4ef99a78136ab4aeabc8286608a02
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jun 21 16:53:06 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/ceedfcc75cc4ef99a78136ab4aeabc8286608a02 [^]

Fixed bug 38802 Fixed bug 38803: code review improvements

Centralized all the common logic related to the Issue in a new abstract class IssueITTDao.
Concrete implementations of this class must override several methods that point to the right document l
ine property (in task and reservation) and to the right picking and issue ITT ids.

At this point the Distribution Order and Sales Order issue implement this class.

The old static methods in *Dao class have been replaced by normal methods. The dao object is now injected directly to the class that consumes it.

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithm.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/ittalgorithm/implementation/IssueDistributionOrderIssue_ITTAlgorithmDao.java
---
(0105313)
vmromanos   
2018-06-21 17:01   
Code review + testing OK
(0106870)
hgbot   
2018-09-20 10:23   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: 6349ce3cc0c88de710200b914a906be3b6bdfe66
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Sep 20 09:53:02 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/6349ce3cc0c88de710200b914a906be3b6bdfe66 [^]

Adds automated test for issue 38802

---
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOTestSuite.java
M src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/utils/DistributionOrdersWithAWOTestUtils.java
A src-test/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/test/OBDOWithAWOIssuesTest.java
---
(0106871)
hgbot   
2018-09-20 10:23   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata
Changeset: 08ff56c591a454b991bfbafd07fdc0b1b479fccf
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Thu Sep 20 09:49:16 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/rev/08ff56c591a454b991bfbafd07fdc0b1b479fccf [^]

[AWO Tests] Added new data for test for issue 38802

---
M referencedata/sampledata/AWO_QA/OBDO_DISTORDER.xml
M referencedata/sampledata/AWO_QA/OBDO_DISTORDERLINE.xml
---