Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038779Retail ModulesWeb POSpublic2018-06-18 12:292018-10-23 16:36
Reporterumartirena 
Assigned Toadrianromero 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038779: Change payments having big difference conversion rates between currencies are created in positive when should be negative
DescriptionChange payments having big difference conversion rates between currencies are created in positive when should be negative.
Steps To Reproduce    * First update the Format.xml configuration file with the following entries and rebuild the instance:
   <Number name="generalQtyRelation"
       decimal="." grouping="," formatOutput="#,##0.############" formatInternal="#0.000000000000" />
   <Number name="generalQtyEdition"
       decimal="." grouping="," formatOutput="#0.############" formatInternal="#0.000000000000" />
   <Number name="generalQtyExcel"
       decimal="." grouping="," formatOutput="#,##0.############" formatInternal="#0.000000000000" />

In https://livebuilds.openbravo.com/retail_pi_pgsql: [^]
 * Go to Conversion Rates window and change following currency conversions:
   - AUD-EUR:
      * Multiply by Rate: 4500
      * Divide by Rate: 0.000222222222
   - EUR-AUD:
      * Multiply by Rate: 0.000222222222
      * Divide by Rate: 4500
 * Log in in Web POS in terminal VBS1001CR
 * Add a "All Mountain ski board Cham"
 * Go to payments and pay 250 EUR
 * Select AUD as change payment.
 * Check change is $0.00
 * Close the ticket.

 * Go to backoffice:
 * In Sales Order window find the created order.
 * Go to payment plan and check that there is -9.00 outstanding amount, when it should be 0.00.
 * Go to Payment Plan details and check that there is one payment of 4.50€ that should be -4.50€.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-18 12:29umartirenaNew Issue
2018-06-18 12:29umartirenaAssigned To => Retail
2018-06-18 12:29umartirenaOBNetwork customer => No
2018-06-18 12:29umartirenaTriggers an Emergency Pack => No
2018-06-18 12:29umartirenaOBNetwork customerNo => Yes
2018-06-18 12:29umartirenaResolution time => 1531087200
2018-06-21 13:56ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-06-21 13:56ranjith_qualiantech_comStatusnew => scheduled
2018-07-06 08:00migueldejuanaResolution time1531087200 => 1532296800
2018-07-26 11:56marvintmResolution time1532296800 => 1534284000
2018-08-16 14:33marvintmResolution time1534284000 => 1535234400
2018-08-23 10:23marvintmResolution time1535234400 => 1536962400
2018-09-12 17:44marvintmOBNetwork customerYes => No
2018-09-12 17:44marvintmResolution time1536962400 =>
2018-09-12 17:44marvintmAssigned Toranjith_qualiantech_com => adrianromero
2018-10-15 10:23hgbotCheckin
2018-10-15 10:23hgbotNote Added: 0107273
2018-10-15 10:23hgbotStatusscheduled => resolved
2018-10-15 10:23hgbotResolutionopen => fixed
2018-10-15 10:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ca29e7e59d15f4115c03bea1ec86d139df89d7 [^]
2018-10-15 10:23hgbotCheckin
2018-10-15 10:23hgbotNote Added: 0107274
2018-10-23 09:29adrianromeroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17806#r17806
2018-10-23 16:36migueldejuanaReview Assigned To => migueldejuana
2018-10-23 16:36migueldejuanaNote Added: 0107530
2018-10-23 16:36migueldejuanaStatusresolved => closed

Notes
(0107273)
hgbot   
2018-10-15 10:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a8ca29e7e59d15f4115c03bea1ec86d139df89d7
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jun 20 12:52:51 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a8ca29e7e59d15f4115c03bea1ec86d139df89d7 [^]

Fixes bug 38779: Change payments with multicurrency difference are created with proper sign

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0107274)
hgbot   
2018-10-15 10:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ef6f94efb3ce7b3445c2c9bd50873af4999a8607
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jun 20 13:00:35 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef6f94efb3ce7b3445c2c9bd50873af4999a8607 [^]

Related to issue 38779: Fix mul operation, don't use bigdecimal library

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0107530)
migueldejuana   
2018-10-23 16:36   
Tested and reviewed