Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038771Retail ModulesWeb POSpublic2018-06-15 14:522019-02-11 12:49
Reportergorka_gil 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Togorka_gil
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038771: Test ReimburseCard is failing, not clear if failure of the test or failure in the pos
DescriptionERROR:
The test is failing in line 186 : assertEquals(31.1, rs.getDouble("totaldeposits"), DELTA);

Right now is getting totaldeposits : 0 instead 31.1

DESCRIPTION:
The test do a reimburse of a gift card, and the question if it should create a cash event or not.


DETAILS:
- The tests is in unstable status, so not running at least from February 2.
So a change in the code could be from time ago.
- The tests assumes that it should create a cash event, and this is probably correct, but need to verify if this is correct. Or the functionally has change for a reason, or accident, or simply the test was wrong from the beggining.
Steps To ReproduceRun test ReimburseCard in local.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039780 closed ranjith_qualiantech_com Giftcards are not consumed in a reimburse until the related cash management is finally processed in the server 
depends on backport 0040034RR19Q1 closed gorka_gil Test ReimburseCard is failing, not clear if failure of the test or failure in the pos 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-15 14:52gorka_gilNew Issue
2018-06-15 14:52gorka_gilAssigned To => Retail
2018-06-15 14:52gorka_gilTriggers an Emergency Pack => No
2018-10-15 11:07ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-10-15 11:08ranjith_qualiantech_comStatusnew => scheduled
2018-10-16 13:52hgbotCheckin
2018-10-16 13:52hgbotNote Added: 0107332
2018-10-19 07:57hgbotCheckin
2018-10-19 07:57hgbotNote Added: 0107451
2018-10-19 08:39ranjith_qualiantech_comStatusscheduled => resolved
2018-10-19 08:39ranjith_qualiantech_comResolutionopen => fixed
2018-10-29 11:55marvintmReview Assigned To => marvintm
2018-10-29 11:55marvintmStatusresolved => closed
2018-10-29 11:55marvintmFixed in Version => RR19Q1
2019-01-02 15:15gorka_gilNote Added: 0108787
2019-01-02 15:15gorka_gilStatusclosed => new
2019-01-02 15:15gorka_gilResolutionfixed => open
2019-01-02 15:15gorka_gilFixed in VersionRR19Q1 =>
2019-01-03 12:00hgbotCheckin
2019-01-03 12:00hgbotNote Added: 0108811
2019-01-04 07:52ranjith_qualiantech_comRelationship addedrelated to 0039780
2019-01-04 10:46ranjith_qualiantech_comStatusnew => scheduled
2019-01-07 18:02hgbotCheckin
2019-01-07 18:02hgbotNote Added: 0108848
2019-01-07 18:03ranjith_qualiantech_comStatusscheduled => resolved
2019-01-07 18:03ranjith_qualiantech_comResolutionopen => fixed
2019-01-08 13:51hgbotCheckin
2019-01-08 13:51hgbotNote Added: 0108853
2019-01-25 11:54gorka_gilStatusresolved => new
2019-01-25 11:54gorka_gilResolutionfixed => open
2019-01-25 11:55gorka_gilStatusnew => scheduled
2019-01-25 11:55gorka_gilStatusscheduled => resolved
2019-01-25 11:55gorka_gilResolutionopen => fixed
2019-02-05 13:15gorka_gilReview Assigned Tomarvintm => gorka_gil
2019-02-11 12:49gorka_gilStatusresolved => closed
2019-02-11 12:49gorka_gilFixed in Version => RR19Q2

Notes
(0107332)
hgbot   
2018-10-16 13:52   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 7e8784db93445ce848d86fa2766e0f6922664476
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Oct 16 17:22:24 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/7e8784db93445ce848d86fa2766e0f6922664476 [^]

Related to issue 38771 : Cash Total Drop should be updated whe reimburse the gift certificate

* When Gift Certificate is reimburse in Cash Management, reimbursed amount should be added to Cash Withdrawal(totalDrops)

---
M web/org.openbravo.retail.giftcards/js/hooks/preSaveCashManagementsHook.js
---
(0107451)
hgbot   
2018-10-19 07:57   
Repository: tools/automation/pi-mobile
Changeset: 0a39f998b03bc70423fe8be2678d737dd06770c0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Oct 17 11:29:17 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0a39f998b03bc70423fe8be2678d737dd06770c0 [^]

Verifies issue 38771 : Modified Test 'ReimburseCard'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
---
(0108787)
gorka_gil   
2019-01-02 15:15   
Now in quarantine is failing the opposite:
Is expecting 0 but it gets 31.1.


https://ci.openbravo.com/view/retail-qa/job/ret-qa-modules-pgsql-suite1/4546/testReport/junit/org.openbravo.test.mobile.retail.extmodules.selenium.tests.giftcards/ReimburseCard/test/ [^]
(0108811)
hgbot   
2019-01-03 12:00   
Repository: tools/automation/pi-mobile
Changeset: 009c5e008b882968d89e140566fd7fa18b4b12ef
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Jan 03 11:59:44 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/009c5e008b882968d89e140566fd7fa18b4b12ef [^]

Related to issue 38771: disable test till the issue is fixed

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
---
(0108848)
hgbot   
2019-01-07 18:02   
Repository: tools/automation/pi-mobile
Changeset: 83f8e020c5f827bba66d60e52daeb36916d74aa3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jan 07 22:31:34 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/83f8e020c5f827bba66d60e52daeb36916d74aa3 [^]

Verifies issue 38771 : Enabled Automated Test 'ReimburseCard'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
---
(0108853)
hgbot   
2019-01-08 13:51   
Repository: tools/automation/pi-mobile
Changeset: b4dc96109050ee93ec3f1490a014343e364276b9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 08 18:20:47 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b4dc96109050ee93ec3f1490a014343e364276b9 [^]

Verifies issue 38771 : Modified Automated Test 'ReimburseCard'

* Removed waitFixOf annotation

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/ReimburseCard.java
---