Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0038768 | Retail Modules | Web POS | public | 2018-06-15 13:44 | 2018-06-21 08:56 |
|
| Reporter | marvintm | |
| Assigned To | rqueralta | |
| Priority | high | Severity | major | Reproducibility | random |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q3 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0038768: Invoice generation in cashup may fail randomly if multiple invoices are generated |
| Description | Currently the cashup generates invoices with a temporary document number, and at the end of the process this temporary number is replaced by the final one. The reason it works in this way is to maximize performance by reducing contention, as generating the final document number requires acquiring a lock over a record in the AD_Sequence table, and it's in our best interest to try to minimise the duration of this lock.
However, there is a problem currently with the way this works. The cashup may generate more than one invoice (as multiple business partners may have generated orders, or different invoices for orders and returns may also be generated). A random document number is generated for each, but the random numbers generated for these document numbers are not very large, and there is a possibility of collision. If the same number is generated for two invoices in the same cashup, then the second one will fail because of the unique constraint in the document number column of the C_Invoice table. |
| Steps To Reproduce | The only way to reproduce this problem reliably is to change this line in OrderGroupingProcessor:
final String strExecutionId = "WebPOS_CashUp_" + String.valueOf(rnd.nextInt(1000000));
so that it generates the same value and then create a cashup with more than one invoice. |
| Proposed Solution | The temporary document number should contain a longer random component based on a UUID (to try to minimise the chances of locking), and also a fixed part (1, 2, 3, ...) to guarantee that even in the case of random collision, the invoices in the same cashup are correctly created. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-06-15 13:44 | marvintm | New Issue | |
| 2018-06-15 13:44 | marvintm | Assigned To | => Retail |
| 2018-06-15 13:44 | marvintm | Resolution time | => 1530828000 |
| 2018-06-15 13:44 | marvintm | Triggers an Emergency Pack | => No |
| 2018-06-15 15:12 | marvintm | Proposed Solution updated | |
| 2018-06-15 20:39 | rqueralta | Assigned To | Retail => rqueralta |
| 2018-06-15 20:39 | rqueralta | Status | new => scheduled |
| 2018-06-19 17:48 | hgbot | Checkin | |
| 2018-06-19 17:48 | hgbot | Note Added: 0105264 | |
| 2018-06-19 17:48 | hgbot | Status | scheduled => resolved |
| 2018-06-19 17:48 | hgbot | Resolution | open => fixed |
| 2018-06-19 17:48 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a63bd8fd12192f63525f89c75351ce7a8b9b19ea [^] |
| 2018-06-21 08:55 | hgbot | Checkin | |
| 2018-06-21 08:55 | hgbot | Note Added: 0105291 | |
| 2018-06-21 08:56 | marvintm | Review Assigned To | => marvintm |
| 2018-06-21 08:56 | marvintm | Status | resolved => closed |
| 2018-06-21 08:56 | marvintm | Fixed in Version | => RR18Q3 |