Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0038767Openbravo ERP03. Procurement managementpublic2018-06-15 12:382018-06-29 21:06
maite 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
3.0PR18Q3 
Sandrahuguet
Core
No
0038767: Should not be possible to save record with same currency from and currency to in Exchange Rate tab
Situation is properly controlled in Conversion Rates window and when you try to define a record with same Currency and Currency To this message is shown:
Saving failed. Currency must be different from To Currency

However, situation is not controlled in Exchange Rate tabs
0. Access Purchase Invoice window select last created record and Unpost it
1. Access Exchange Rate tab and create new record setting "To currency"="Currency" and any rate. Realize that you are able to save it

NOTE: this will not affect to purchase invoice's posting but to next event's (payment/transaction/reconciliation) posting
No tags attached.
Issue History
2018-06-15 12:38maiteNew Issue
2018-06-15 12:38maiteAssigned To => Triage Finance
2018-06-15 12:38maiteModules => Core
2018-06-15 12:38maiteResolution time => 1530828000
2018-06-15 12:38maiteTriggers an Emergency Pack => No
2018-06-15 12:41maiteIssue Monitored: networkb
2018-06-19 12:41dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2018-06-25 19:29AtulOpenbravoStatusnew => scheduled
2018-06-25 19:50AtulOpenbravoNote Added: 0105373
2018-06-28 17:09hgbotCheckin
2018-06-28 17:09hgbotNote Added: 0105499
2018-06-28 17:09hgbotStatusscheduled => resolved
2018-06-28 17:09hgbotResolutionopen => fixed
2018-06-28 17:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/43053d247d6157b4607d1fdb270da7ff502f8781 [^]
2018-06-28 17:10SandrahuguetReview Assigned To => Sandrahuguet
2018-06-28 17:10SandrahuguetNote Added: 0105500
2018-06-28 17:10SandrahuguetStatusresolved => closed
2018-06-28 17:10SandrahuguetFixed in Version => 3.0PR18Q3
2018-06-29 21:06hudsonbotCheckin
2018-06-29 21:06hudsonbotNote Added: 0105518

Notes
(0105373)
AtulOpenbravo   
2018-06-25 19:50   
Test Plan

- Login as F&B International Group Admin
- Access Purchase Invoice window select last created record and Unpost it
- Access Exchange Rate tab and create new record setting "To currency"="Currency" and any rate.
- Realize that record cannot be saved. Error msg is shown "Currency must be different from To Currency".
- Set To Currency with a different from Currency field for eg: Currency = EUR, To Currency = USD
- Record is saved successfully.
- Try to modify earlier saved record such that Currency = To Currency, again error message is as "Currency must be different from To Currency".

Similar test done for Payment In / Out, Sales Invoice.
(0105499)
hgbot   
2018-06-28 17:09   
Repository: erp/devel/pi
Changeset: 43053d247d6157b4607d1fdb270da7ff502f8781
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Jun 28 12:17:43 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/43053d247d6157b4607d1fdb270da7ff502f8781 [^]

Fixes Issue 0038767: Should not be possible to save record with
same currency from and currency to in Exchange Rate tab

Avoid same currency conversion rate for the invoice and payment
document

---
M src-db/database/model/triggers/C_CONVERSION_RATE_DOCUMENT_TRG.xml
---
(0105500)
Sandrahuguet   
2018-06-28 17:10   
Code review + testing OK
(0105518)
hudsonbot   
2018-06-29 21:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0338e029f9f8 [^]
Maturity status: Test