0038757: Strange characters like "line break" are being accepted as attribute value

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038757

Openbravo ERP

04. Warehouse management

public

2018-06-14 11:04

2018-06-14 11:34

Reporter

guilleaer

Assigned To

AtulOpenbravo

Priority

normal

Severity

minor

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038757: Strange characters like "line break" are being accepted as attribute value

Description

When a user is trying to give value to a certain attribute, some "control" characters are being allowed.

I think that we should restrict the information which can be inserted in thats field. Even more taking into account that these information now can be edited/changed from other mobile applications like web POS and AWO. Apart from that, I think that from a functional and UI perspective does not make sense.

I would recommend to define a set of character accepted and restrict any other character in every UI which can update this values

[a-z][A-Z][0-9](+,-,_,#,*,@,<,>)

Steps To Reproduce

With AWO and AWO SampleData installed

Go to Goods Receipt Window and create a record with:
  * Organization: US West Coast
  * Business Partner: Be Soft Drinker
  * Warehouse: US West Coast
Move to lines and create a new one with:
  * Product: Apple
  * Operative Quantity: 10
  * Attribute Set Value:
    - First, click on the X to remove existing attribute
    - Create a new one with: 'Test [Enter]'. By clicking on enter it will introduce a '\n' character
Complete the Document

As you can see enter is accepted and saved in the database. Ui is not ready to show that. Mobile app with manage this value as json data will suffer

Proposed Solution

define a set of character accepted and restrict any other character in every UI which can update this value

Additional Information