Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038749Openbravo ERPA. Platformpublic2018-06-13 12:142018-06-15 10:49
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038749: InventoryCountProcess registers SQL functions in a non-standard way
DescriptionInventoryCountProcess registers SQL functions in a non-standard way[1]. It is was manually registering the functions into the dialect. This is wrong because:

a) Duplicates the code. Performs the same actions done by the OBDal.registerSQLFunction
b) This will not work in Hibernate 5.3

Note that this is a change we missed when fixing 0038520, due to the fact that the code does not use the OBDal.registerSQLFunction.
Steps To ReproduceIn description
Proposed SolutionRegister the required functions using a SQLFunctionRegister
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038520 closed caristu Deprecate OBDal.registerSQLFunction 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-13 12:14caristuNew Issue
2018-06-13 12:14caristuAssigned To => caristu
2018-06-13 12:14caristuOBNetwork customer => No
2018-06-13 12:14caristuModules => Core
2018-06-13 12:14caristuTriggers an Emergency Pack => No
2018-06-13 12:15caristuDescription Updatedbug_revision_view_page.php?rev_id=17292#r17292
2018-06-13 12:15caristuRelationship addedrelated to 0038520
2018-06-13 12:16caristuDescription Updatedbug_revision_view_page.php?rev_id=17293#r17293
2018-06-13 17:34hgbotCheckin
2018-06-13 17:34hgbotNote Added: 0105132
2018-06-13 17:34hgbotStatusnew => resolved
2018-06-13 17:34hgbotResolutionopen => fixed
2018-06-13 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^]
2018-06-13 17:34caristuReview Assigned To => alostale
2018-06-13 21:36hudsonbotCheckin
2018-06-13 21:36hudsonbotNote Added: 0105134
2018-06-15 10:49alostaleNote Added: 0105171
2018-06-15 10:49alostaleStatusresolved => closed
2018-06-15 10:49alostaleFixed in Version => 3.0PR18Q3

Notes
(0105132)
hgbot   
2018-06-13 17:34   
Repository: erp/devel/pi
Changeset: 12232bee10ef58d11743de979fdfa0dd9e4614ba
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jun 13 17:18:35 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/12232bee10ef58d11743de979fdfa0dd9e4614ba [^]

fixes issue 38749: InventoryCountProcess registers SQL functions in a non-standard way

  Register in Hibernate the SQL functions required by the InventoryCountProcess class during the initialization of the DAL layer:

  - get_uuid: being already registered in the KernelSQLFunctionRegister
  - to_date: there is no need of explicitly registering it, it is already registered by the corresponding PostgreSQL and Oracle dialects
  - to_timestamp: being registered by default with the PostgreSQL but not with the Oracle dialect. So for PostgreSQL we are overriding the registry of this function. For this reason we are registering it in the same way as done by the PostgreSQL dialect.
  - now: the same as to_timestamp function

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelSQLFunctionRegister.java
M src/org/openbravo/materialmgmt/InventoryCountProcess.java
---
(0105134)
hudsonbot   
2018-06-13 21:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3aea2ba95cc7 [^]
Maturity status: Test
(0105171)
alostale   
2018-06-15 10:49   
reviewed