0038745: In case currencyFormat is set a precision 0 foreign currency precision should override it

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038745

Retail Modules

Web POS

public

2018-06-13 09:12

2018-06-13 09:15

Reporter

guillermogil

Assigned To

Retail

Priority

high

Severity

major

Reproducibility

always

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038745: In case currencyFormat is set a precision 0 foreign currency precision should override it

Description

In case currencyFormat is set a precision 0 foreign currency precision should override it.

Steps To Reproduce

- Configure Format.xml with 2 decimals
- Configure currency format as 0 decimals
- Set EUR currency as precision 0
- Set USD currency as precision 2

Login on WebPOS
Add a product
Pay with USD

We have lost all that information

Proposed Solution

In will be needed to add a new parameter in OB.I18N.formatCurrency to send the precision of the currency.
e.g.-
  OB.I18N.formatCurrency = function (number, precision) {
     var maskNumeric = OB.Format.formats.priceInform,
         decSeparator = OB.Format.defaultDecimalSymbol,
         groupSeparator = OB.Format.defaultGroupingSymbol,
         groupInterval = OB.Format.defaultGroupingSize;

    if (precision) {
      var maskNumericSplitted = maskNumeric.split('.');
      if (maskNumericSplitted.length = 1 || maskNumericSplitted[1].length !== precision) {
        if (precision > 0) {
          maskNumeric = maskNumericSplitted[0] + '.' + ''.padStart(precision, 0);
        } else {
          maskNumeric = maskNumericSplitted[0];
        }
      }
    }

     maskNumeric = maskNumeric.replace(',', 'dummy').replace('.', decSeparator).replace('dummy', groupSeparator);

     return OB.Utilities.Number.JSToOBMasked(number, maskNumeric, decSeparator, groupSeparator, groupInterval);
   };

Additional Information