Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038724Retail ModulesWeb POSpublic2018-06-08 06:392018-10-29 11:35
Reporterguillermogil 
Assigned Toguillermogil 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038724: It is not possible to set a reason for price modification
DescriptionIt is needed to have the possibility to set a reason for price modification as Reject Quotations or Returns Reasons.
A new window called Price Modification Reasons will have the records of this functionality. If there is any record active, this behavior will be enabled.
Steps To ReproduceN/A
Proposed SolutionSee diff attached
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039917 closed guillermogil Missing sync table for OBPOS_PriceReason 
Attached Filesdiff PriceModificationReason.diff (122,722) 2018-10-16 07:16
https://issues.openbravo.com/file_download.php?file_id=12269&type=bug
diff TestPriceModificationReason.diff (12,892) 2018-10-16 07:16
https://issues.openbravo.com/file_download.php?file_id=12270&type=bug
diff SampledataPriceModificationReason.diff (7,569) 2018-10-16 07:16
https://issues.openbravo.com/file_download.php?file_id=12271&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-06-08 06:39guillermogilNew Issue
2018-06-08 06:39guillermogilAssigned To => guillermogil
2018-06-08 06:39guillermogilOBNetwork customer => No
2018-06-08 06:39guillermogilTriggers an Emergency Pack => No
2018-06-08 06:40guillermogilFile Added: issue38724.diff
2018-06-08 09:10guillermogilFile Deleted: issue38724.diff
2018-06-08 09:10guillermogilFile Added: issue38724.diff
2018-06-08 11:48guillermogilFile Deleted: issue38724.diff
2018-06-08 11:48guillermogilFile Added: issue38724.diff
2018-06-11 07:09guillermogilFile Deleted: issue38724.diff
2018-06-11 07:10guillermogilFile Added: issue38724.diff
2018-06-11 07:10guillermogilFile Added: sampleData.diff
2018-06-11 08:56guillermogilFile Added: testPriceReason.diff
2018-06-11 10:25guillermogilDescription Updatedbug_revision_view_page.php?rev_id=17277#r17277
2018-07-02 15:28guillermogilFile Added: approvalHook.diff
2018-10-09 14:43guillermogilFile Added: issue0038724Final.diff
2018-10-11 07:42guillermogilFile Deleted: issue38724.diff
2018-10-11 07:42guillermogilFile Deleted: approvalHook.diff
2018-10-11 07:42guillermogilFile Deleted: issue0038724Final.diff
2018-10-11 07:42guillermogilFile Added: 38724.diff
2018-10-11 08:09guillermogilFile Deleted: testPriceReason.diff
2018-10-11 08:10guillermogilFile Added: tests.diff
2018-10-11 09:17guillermogilFile Deleted: tests.diff
2018-10-11 09:17guillermogilFile Added: tests
2018-10-11 11:01guillermogilFile Deleted: tests
2018-10-11 11:01guillermogilFile Deleted: 38724.diff
2018-10-11 11:01guillermogilFile Added: 38724.diff
2018-10-11 11:01guillermogilFile Added: tests
2018-10-11 11:42guillermogilFile Deleted: 38724.diff
2018-10-11 11:42guillermogilFile Added: 38724.diff
2018-10-16 07:16guillermogilFile Added: PriceModificationReason.diff
2018-10-16 07:16guillermogilFile Added: TestPriceModificationReason.diff
2018-10-16 07:16guillermogilFile Added: SampledataPriceModificationReason.diff
2018-10-16 07:16guillermogilFile Deleted: sampleData.diff
2018-10-16 07:17guillermogilFile Deleted: tests
2018-10-16 07:17guillermogilFile Deleted: 38724.diff
2018-10-17 07:01hgbotCheckin
2018-10-17 07:01hgbotNote Added: 0107350
2018-10-17 07:01hgbotCheckin
2018-10-17 07:01hgbotNote Added: 0107351
2018-10-17 07:01hgbotCheckin
2018-10-17 07:01hgbotNote Added: 0107352
2018-10-17 07:01hgbotStatusnew => resolved
2018-10-17 07:01hgbotResolutionopen => fixed
2018-10-17 07:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fec7e877be463eb59a2e482cdb0d349d0c99347b [^]
2018-10-17 07:02guillermogilReview Assigned To => jorge-garcia
2018-10-29 11:35marvintmStatusresolved => closed
2018-10-29 11:35marvintmFixed in Version => RR19Q1
2019-01-10 15:59guillermogilRelationship addedrelated to 0039917

Notes
(0107350)
hgbot   
2018-10-17 07:01   
Repository: tools/automation/pi-mobile
Changeset: d70601a764f2894bc4435084cf8741635266a510
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Oct 17 06:58:59 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d70601a764f2894bc4435084cf8741635266a510 [^]

Related to issue 38724: Added tests for Price Modification Reason

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I38724_AllowPriceModificationVerifiedReturns.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I38724_PriceModificationReason.java
---
(0107351)
hgbot   
2018-10-17 07:01   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 21fd41fd9fc1938355f4a3d57853bc89ccccf392
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Oct 17 07:00:41 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/21fd41fd9fc1938355f4a3d57853bc89ccccf392 [^]

Related to issue 38724: Added Sampledata for Price Modification

---
M referencedata/sampledata/The_White_Valley_Group/AD_WINDOW_ACCESS.xml
A referencedata/sampledata/The_White_Valley_Group/OBPOS_PRICEREASON.xml
---
(0107352)
hgbot   
2018-10-17 07:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fec7e877be463eb59a2e482cdb0d349d0c99347b
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed Oct 17 07:01:28 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fec7e877be463eb59a2e482cdb0d349d0c99347b [^]

Fixed Issue 38724: Price Modification Project

Added tablaes to show Price Modification
Added the possibility to modify the price of a verified return

---
M src-db/database/model/modifiedTables/C_ORDERLINE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src-db/database/sourcedata/AD_WINDOW.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/components/modalreceiptlineproperties.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
A src-db/database/model/tables/OBPOS_PRICEREASON.xml
A src/org/openbravo/retail/posterminal/term/PriceModificationReason.java
A web/org.openbravo.retail.posterminal/js/components/modalPriceModification.js
---