Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038706Retail ModulesWeb POSpublic2018-06-05 17:272018-06-21 09:45
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038706: lastUpdatedTimestamp from models are not correctly remove in some cases
DescriptionIn ob-dal.js exists this piece code:
  OB.UTIL.localStorage.removeItem('POSLastTotalRefresh');
  _.forEach(models, function (model) {
    OB.UTIL.localStorage.removeItem('lastUpdatedTimestamp' + model.modelName);
  });

The problem is that not all the models has modelName defined, so theitem is never removed in case a full refresh fails
Steps To Reproduce-
Proposed SolutionThe solution is to verify the modelName exists, and, if not, search it into the prototype of the model
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-06-05 17:27jorge-garciaNew Issue
2018-06-05 17:27jorge-garciaAssigned To => jorge-garcia
2018-06-05 17:27jorge-garciaOBNetwork customer => No
2018-06-05 17:27jorge-garciaTriggers an Emergency Pack => No
2018-06-06 10:36jorge-garciaStatusnew => scheduled
2018-06-08 08:33hgbotCheckin
2018-06-08 08:33hgbotNote Added: 0105024
2018-06-08 08:33hgbotStatusscheduled => resolved
2018-06-08 08:33hgbotResolutionopen => fixed
2018-06-08 08:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5032c616bede6356831215d6957c23dac8a8b6fd [^]
2018-06-21 09:45marvintmReview Assigned To => marvintm
2018-06-21 09:45marvintmStatusresolved => closed
2018-06-21 09:45marvintmFixed in Version => RR18Q3

Notes
(0105024)
hgbot   
2018-06-08 08:33   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5032c616bede6356831215d6957c23dac8a8b6fd
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 06 09:33:37 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5032c616bede6356831215d6957c23dac8a8b6fd [^]

Fixed issue 38706: lastUpdatedTimestamp from models are not correctly remove
in some cases

The solution is to verify the modelName exists, and, if not, search the
modelName into the prototype of the model

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---