Openbravo Issue Tracking System - Retail Modules
View Issue Details
0038683Retail ModulesWeb POSpublic2018-05-14 13:592018-07-12 11:36
maite 
ranjith_qualiantech_com 
immediatemajoralways
closedfixed 
5
 
RR18Q2.1RR18Q2.1 
marvintm
No
0038683: Wrong payment documents registered in backoffice when giving change in another currency from WebPOS
In case the cashier gives the change in different currency that receipt's currency, credit is generated to the customer (which is wrong)


Due to some problems related with the approach used to fix issue 38038 has been decided to go for a new approach to solve the situation

1. Access POS terminal and create receipt for "Avalanche transceiver" and pay it using "USA cash". Purpose of this step is to have cash in USD
2. Create new receipt setting "Invoice this receipt" for "Insect repellent" pay it using 20 EUR and select "USA Cash" to give the change in USD
3. Access to backoffice to review registered documents and realize that they have some errors:

 a) the sales order document has erroneous Payment Plan info as "received Amount" is higher than "Expected amount" and negative amount appears as "outstanding amount" (when receipt has been fully paid)

 b) from Payment Details tab you can see that 2 payment documents have been created. One is generating credit to anonymous customer, which was not happening before and this credit is not being consumed.
NEW approach:

- No credit should be generated
- All details should be associated with sales order
No tags attached.
blocks defect 0038544 closed ranjith_qualiantech_com Wrong payment documents registered in backoffice when giving change in another currency from WebPOS 
Issue History
2018-06-01 13:10marvintmTypedefect => backport
2018-06-01 13:10marvintmTarget Version => RR18Q2.1
2018-06-02 08:47hgbotCheckin
2018-06-02 08:47hgbotNote Added: 0104889
2018-06-02 08:47hgbotStatusscheduled => resolved
2018-06-02 08:47hgbotResolutionopen => fixed
2018-06-02 08:47hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/a95012cd5ffa57b3cd32533f7076570829c40fcd [^]
2018-06-02 08:47hgbotCheckin
2018-06-02 08:47hgbotNote Added: 0104890
2018-06-25 09:02marvintmReview Assigned To => marvintm
2018-06-25 09:02marvintmStatusresolved => closed
2018-06-25 09:02marvintmFixed in Version => RR18Q2.1
2018-07-12 11:36hgbotCheckin
2018-07-12 11:36hgbotNote Added: 0105712

Notes
(0104889)
hgbot   
2018-06-02 08:47   
Repository: retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal
Changeset: a95012cd5ffa57b3cd32533f7076570829c40fcd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 02 12:16:28 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/org.openbravo.retail.posterminal/rev/a95012cd5ffa57b3cd32533f7076570829c40fcd [^]

Fixed issue 38683 : Change payment in different currency should be associated with payment details

* Credit should not be generated for Change amount
* Reverted changes for the issue 38038

Backed out changeset: f4fb9c07eb35

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0104890)
hgbot   
2018-06-02 08:47   
Repository: retail/backports/3.0RR18Q2.1/pi-mobile
Changeset: 5953a3c245c7b68fa07c610bbc118cc6e4108cae
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 02 12:16:54 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2.1/pi-mobile/rev/5953a3c245c7b68fa07c610bbc118cc6e4108cae [^]

Verifies issue 38683 : Modified automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I38038_VerifyReceiptChangeWithDiffCurrency.java
---
(0105712)
hgbot   
2018-07-12 11:36   
Repository: tools/automation/pi-mobile
Changeset: 5953a3c245c7b68fa07c610bbc118cc6e4108cae
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sat Jun 02 12:16:54 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5953a3c245c7b68fa07c610bbc118cc6e4108cae [^]

Verifies issue 38683 : Modified automated test 'I38038_VerifyReceiptChangeWithDiffCurrency'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I38038_VerifyReceiptChangeWithDiffCurrency.java
---