Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038635Openbravo ERPA. Platformpublic2018-05-25 14:132018-06-08 07:29
Reporterlorenzofidalgo 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2018-02-23
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4a1f3df29564b6dd12259981f941d0d5d74bebab [^]
Triggers an Emergency PackNo
Summary0038635: Wrong values sent while creating a record under specific circumstances
DescriptionCreating records, it is possible send different data than the values that are selected by the user. It seems to be induced by a callout launched using the backspace key to remove the default value.
Steps To Reproduce0-Login ERP and, using F&B International Group Admin role, go to "Role" window.
1-In the Header tab, select "F&B España, S.A - Finance" (column: name) record.
2-Go to "Org Access" tab.
3-If present, delete "F&B España, S.A" record.
4-Click "Create a new record in form view" button.
5-Click in "Organization" input field and remove the "*" character using the backspace key. Now, click at the arrow key to select a value, and choose "F&B España, S.A". Click Save button.
6-DEFECT: The following error will be shown: "Saving failed. There is already a Role Organization Access with the same (Organization, Role). (Organization, Role) must be unique. You must change the values entered." The role that has been sent by the application is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00386533.0PR18Q2.1 closed caristu Wrong values sent while creating a record under specific circumstances 
caused by feature request 0037980 closed alostale Improve organization cache in session 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-25 14:13lorenzofidalgoNew Issue
2018-05-25 14:13lorenzofidalgoAssigned To => platform
2018-05-25 14:13lorenzofidalgoModules => Core
2018-05-25 14:13lorenzofidalgoRegression level => Production - QA Approved
2018-05-25 14:13lorenzofidalgoRegression introduced in release => 3.0PR18Q2
2018-05-25 14:13lorenzofidalgoTriggers an Emergency Pack => No
2018-05-25 14:14lorenzofidalgoSummaryWrong role sent while creating a record under specific circumstances => Wrong values sent while creating a record under specific circumstances
2018-05-25 14:15lorenzofidalgoDescription Updatedbug_revision_view_page.php?rev_id=17194#r17194
2018-05-25 14:17lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17196#r17196
2018-05-29 17:35caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4a1f3df29564b6dd12259981f941d0d5d74bebab [^]
2018-05-29 17:35caristuRelationship addedcaused by 0037980
2018-05-29 17:36caristuRegression date => 2018-02-23
2018-05-29 17:43caristuNote Added: 0104781
2018-05-29 17:43caristuAssigned Toplatform => caristu
2018-05-29 17:43caristuStatusnew => acknowledged
2018-05-29 17:44caristuStatusacknowledged => scheduled
2018-05-30 10:41caristuNote Edited: 0104781bug_revision_view_page.php?bugnote_id=0104781#r17220
2018-05-30 10:55hgbotCheckin
2018-05-30 10:55hgbotNote Added: 0104801
2018-05-30 10:55hgbotStatusscheduled => resolved
2018-05-30 10:55hgbotResolutionopen => fixed
2018-05-30 10:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3b8a64571ce8c66944a72e062fab9f57000693be [^]
2018-05-30 10:58caristuReview Assigned To => alostale
2018-05-30 17:11hudsonbotCheckin
2018-05-30 17:11hudsonbotNote Added: 0104813
2018-06-01 09:46alostaleNote Added: 0104858
2018-06-01 09:46alostaleStatusresolved => closed
2018-06-01 09:46alostaleFixed in Version => 3.0PR18Q3
2018-06-05 13:19hgbotCheckin
2018-06-05 13:19hgbotNote Added: 0104939
2018-06-08 07:29hudsonbotCheckin
2018-06-08 07:29hudsonbotNote Added: 0105012

Notes
(0104781)
caristu   
2018-05-29 17:43   
(edited on: 2018-05-30 10:41)
The issue is caused by a change in the behavior of the UIDefinition.getValueInComboReference() method. This change can happen when clearing an Organization (AD_Org) combo.

Before 0037980 when retrieving an empty organization in the FIC, the query to calculate the combo was filtering by every organization. Now the query to calculate the combo is adding the following clause:

..AND td0.AD_Org_ID IN ('').

Note that we are filtering by an empty list (''). Therefore, no values are calculated, causing subsequent problems like the reported in this issue.
(0104801)
hgbot   
2018-05-30 10:55   
Repository: erp/devel/pi
Changeset: 3b8a64571ce8c66944a72e062fab9f57000693be
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed May 30 10:43:21 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3b8a64571ce8c66944a72e062fab9f57000693be [^]

fixes issue 38635: Wrong combo values if the org id is not received by the FIC

  Before the changes on issue 0037980 when retrieving an empty organization in the FIC, the query to calculate the selected combo value was filtering by every organization in the client. After that changes, the query to calculate the combo is filtering by an empty organization list, avoiding to retrieve the correct value.

  This is eventually caused by a change on how the Utility.getReferenceableOrg() method behaves. It now returns an empty list ('') if no organization is provided.

  To fix the problem we are now not including the org filtering in the query generated by UIDefinition.getValueInComboReference() method if an empty organization list is provided when building the query. In this case, filtering by client should be enough.

---
M src/org/openbravo/erpCommon/utility/ComboTableData.java
M src/org/openbravo/erpCommon/utility/StringCollectionUtils.java
---
(0104813)
hudsonbot   
2018-05-30 17:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/10bad01a186a [^]
Maturity status: Test
(0104858)
alostale   
2018-06-01 09:46   
reviewed + tested
(0104939)
hgbot   
2018-06-05 13:19   
Repository: erp/devel/pi
Changeset: cf31b874f2d21cca2fbea33e6d8e68ab7791e4fb
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jun 05 13:19:34 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cf31b874f2d21cca2fbea33e6d8e68ab7791e4fb [^]

related to issue 38635: added test case

---
M src-test/src/org/openbravo/test/datasource/FICTest.java
---
(0105012)
hudsonbot   
2018-06-08 07:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4e0c05c97edf [^]
Maturity status: Test