Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038612Localization Pack: SpainSpain Professional Localization Packpublic2018-05-24 09:302018-07-03 13:46
Reporterimonferrer 
Assigned ToTriage Finance 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0038612: INTRASTAT - Correct value assigned to the fields Consignment/Destination country in case of an end-user manually insert a line
DescriptionCorrect value assigned to the fields Consignment/Destination country in case of an end-user manually insert a new line.
Steps To Reproduce(In spanish)

En la generación del fichero de intrastat con líneas manuales, está incluyendo el país en la declaración de forma aleatoria, tomando la primera línea independientemente de la dirección de facturación que tenga ese tercero ya que el código en la línea 82 en la que obtiene el país indica:

// Manual line introduced by the user

bpLocation = line.getBusinessPartner().getBusinessPartnerLocationList().get(0).getLocationAddress();

Proposed SolutionImplantación en Openbravo

Cuando se inserte una línea de declaración de intrastat de forma manual, una vez se haya seleccionado el tercero añadir un nuevo campo en el que el usuario tenga que cumplimentar/elegir la dirección del tercero correcta. Este campo sugerirá la dirección marcada como dirección de factura por defecto siendo posible que el usuario la modifique. De este campo tomará la información del país para trasladarlo al fichero.

Observaciones:

* Crear el campo Dirección al lado del tercero en la línea de la declaración del intrastat

* Filtrar por las direcciones del tercero

* Se añade un callout que al seleccionar el tercero pone UNA de las direcciones del tercero marcadas como dirección de factura

* El campo "dirección" se muestra cuando el campo línea de factura NO está relleno

* Al generar el fichero se toma la dirección de:

- En caso de tener línea de factura asociada, de la factura

- En caso de no tener línea de factura asociada, se toma del campo de la línea de la declaración

- En caso que NO esté rellenado este caso, se mostrará un error que indicará que se tiene que rellenar el campo de dirección
Additional Information
TagsNo tags attached.
Relationships
Attached Filesxlsx TC 2018-06-07 Consignment, destination country (manually).xlsx (17,696) 2018-06-25 16:58
https://issues.openbravo.com/file_download.php?file_id=11897&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-05-24 09:30imonferrerNew Issue
2018-05-24 09:30imonferrerAssigned To => Triage Finance
2018-06-07 10:16psanjuanSummaryINTRASTAT - Correct value assigned to the fields Consignment/Destination country in case of an end-user manually insert a new t => INTRASTAT - Correct value assigned to the fields Consignment/Destination country in case of an end-user manually insert a line
2018-06-07 10:16psanjuanDescription Updatedbug_revision_view_page.php?rev_id=17259#r17259
2018-06-07 10:18psanjuanNote Added: 0104995
2018-06-07 10:18psanjuanNote Added: 0104996
2018-06-07 10:18psanjuanNote Deleted: 0104996
2018-06-07 10:18psanjuanNote Edited: 0104995bug_revision_view_page.php?bugnote_id=0104995#r17261
2018-06-07 10:18Opentix-TestNote Edited: 0104995bug_revision_view_page.php?bugnote_id=0104995#r17262
2018-06-07 10:18psanjuanNote Edited: 0104995bug_revision_view_page.php?bugnote_id=0104995#r17263
2018-06-07 10:19psanjuanFile Added: Clientes_Importados.jpg
2018-06-07 10:19psanjuanFile Deleted: Clientes_Importados.jpg
2018-06-07 10:20Opentix-TestNote Edited: 0104995bug_revision_view_page.php?bugnote_id=0104995#r17264
2018-06-07 10:25psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17266#r17266
2018-06-07 10:25psanjuanProposed Solution updated
2018-06-07 10:26psanjuanNote Edited: 0104995bug_revision_view_page.php?bugnote_id=0104995#r17267
2018-06-25 16:28Opentix-TestNote Added: 0105364
2018-06-25 16:28Opentix-TestNote Deleted: 0105364
2018-06-25 16:58Opentix-TestFile Added: TC 2018-06-07 Consignment, destination country (manually).xlsx
2018-07-02 12:41vmromanosStatusnew => scheduled
2018-07-03 13:44hgbotCheckin
2018-07-03 13:44hgbotNote Added: 0105549
2018-07-03 13:44hgbotStatusscheduled => resolved
2018-07-03 13:44hgbotResolutionopen => fixed
2018-07-03 13:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/4aed2aa3fe24f08db0b73f45ab921d7519d96a56 [^]
2018-07-03 13:44hgbotCheckin
2018-07-03 13:44hgbotNote Added: 0105550
2018-07-03 13:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/4aed2aa3fe24f08db0b73f45ab921d7519d96a56 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/e40ea54777809505b9df525cc151d39719f2c7da [^]
2018-07-03 13:44hgbotCheckin
2018-07-03 13:44hgbotNote Added: 0105552
2018-07-03 13:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/e40ea54777809505b9df525cc151d39719f2c7da [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat.es_ES/rev/83d5f547fd37a62f52c92c59cddad8121b3e1a81 [^]
2018-07-03 13:44hgbotCheckin
2018-07-03 13:44hgbotNote Added: 0105553
2018-07-03 13:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat.es_ES/rev/83d5f547fd37a62f52c92c59cddad8121b3e1a81 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat.spain/rev/a73f473032c68fe9edb4d8b12f827a7783b7f285 [^]
2018-07-03 13:46vmromanosReview Assigned To => vmromanos
2018-07-03 13:46vmromanosNote Added: 0105555
2018-07-03 13:46vmromanosStatusresolved => closed

Notes
(0104995)
psanjuan   
2018-06-07 10:18   
(edited on: 2018-06-07 10:26)
Test plan can be reviewed in the field attached
(0105549)
hgbot   
2018-07-03 13:44   
Repository: erp/pmods/org.openbravo.module.intrastat
Changeset: 4aed2aa3fe24f08db0b73f45ab921d7519d96a56
Author: Iñaki Monferrer Altava <imonferrer <at> opentix.es>
Date: Fri Jun 22 11:33:27 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/4aed2aa3fe24f08db0b73f45ab921d7519d96a56 [^]

Fixed bug 38612: Correct value assigned to Consignment/Destination country
BPartner location field created in Intrastat Line. New callout created to get bpartner location when business partner is selected.

---
M src-db/database/model/tables/INTR_LINES.xml
M src-db/database/model/triggers/INTR_HEADER_TRG.xml
M src-db/database/sourcedata/AD_CALLOUT.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src/org/openbravo/module/intrastat/exception/IntrastatException.java
M src/org/openbravo/module/intrastat/exception/IntrastatExceptionHandler.java
A src-db/database/sourcedata/OBUISEL_SELECTOR.xml
A src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
A src/org/openbravo/module/intrastat/erpCommon/ad_callouts/INTR_LINE_BPartner.java
---
(0105550)
hgbot   
2018-07-03 13:44   
Repository: erp/pmods/org.openbravo.module.intrastat
Changeset: e40ea54777809505b9df525cc151d39719f2c7da
Author: Iñaki Monferrer Altava <imonferrer <at> opentix.es>
Date: Tue Jul 03 12:06:58 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat/rev/e40ea54777809505b9df525cc151d39719f2c7da [^]

Fixed bug 38612: Correct value assigned to Consignment/Destination country
Added try/catch at INTR_LINE_BPartner. Executed Synchronize Terminology process.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/module/intrastat/erpCommon/ad_callouts/INTR_LINE_BPartner.java
---
(0105552)
hgbot   
2018-07-03 13:44   
Repository: erp/pmods/org.openbravo.module.intrastat.es_ES
Changeset: 83d5f547fd37a62f52c92c59cddad8121b3e1a81
Author: Ignacio Monferrer Altava <imonferrer <at> opentix.es>
Date: Wed Jun 06 16:33:12 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat.es_ES/rev/83d5f547fd37a62f52c92c59cddad8121b3e1a81 [^]

Fixed bug 38612: Correct value assigned to Consignment/Destination country
Created new message and modified translations of some old messages.

---
M referencedata/translation/AD_MESSAGE_TRL_es_ES.xml
M referencedata/translation/AD_REFERENCE_TRL_es_ES.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
A referencedata/translation/OBUISEL_SELECTOR_FIELD_TRL_es_ES.xml
A referencedata/translation/OBUISEL_SELECTOR_TRL_es_ES.xml
---
(0105553)
hgbot   
2018-07-03 13:44   
Repository: erp/pmods/org.openbravo.module.intrastat.spain
Changeset: a73f473032c68fe9edb4d8b12f827a7783b7f285
Author: Ignacio Monferrer Altava <imonferrer <at> opentix.es>
Date: Wed Jun 06 16:37:21 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.intrastat.spain/rev/a73f473032c68fe9edb4d8b12f827a7783b7f285 [^]

Fixed bug 38612: Correct value assigned to Consignment/Destination country
Modified how to get bparter location (auto/manual).

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/module/intrastat/spain/ProcessAndGenerateIntrastat_Spain.java
---
(0105555)
vmromanos   
2018-07-03 13:46   
Code review OK.

Fixed in Intrastat 3.0.400 and Intrastat for Spain 1.0.100