Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038610Retail ModulesWeb POSpublic2018-05-24 08:452018-11-28 07:17
Reportermarvintm 
Assigned Tojorge-garcia 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038610: Products should not necessarily have a price in the main pricelist to be loaded in the WebPOS
DescriptionCurrently, it is mandatory for a product to have a price defined in the pricelist of the store for it to be loaded in the WebPOS. This is an inconvenience in case some products must be available for some specific customers, but not be available across the board.

It is therefore proposed to implement the following development:
- A new preference must be defined: "WebPOS Allow products not to have a price in the main pricelist"
- If this preference is defined and set to "Y", then the Product query should no longer do an "inner join" with the pricelist, but a left join should be done instead, and should return null prices in case the product doesn't have a price defined in the store pricelist.
- In the WebPOS, with customers which use the main store pricelist, the behaviour should be the same than with customers which have a different pricelist: that is, when using SEARCH and BROWSE, the proposed products should be the ones which have price in the main store pricelist, and those which don't should not be shown when browsing or searching.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 38610_17Q4_mobilecore.diff (8,483) 2018-06-22 10:23
https://issues.openbravo.com/file_download.php?file_id=11883&type=bug
diff 38610_17Q4_posterminal.diff (11,129) 2018-06-22 10:24
https://issues.openbravo.com/file_download.php?file_id=11884&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-05-24 08:45marvintmNew Issue
2018-05-24 08:45marvintmAssigned To => Retail
2018-05-24 08:45marvintmTriggers an Emergency Pack => No
2018-05-24 13:33galderromoIssue Monitored: galderromo
2018-05-24 13:41jfrancesIssue Monitored: jfrances
2018-05-25 08:57egoitzIssue Monitored: maite
2018-05-31 10:57jorge-garciaStatusnew => scheduled
2018-05-31 10:57jorge-garciaAssigned ToRetail => jorge-garcia
2018-06-22 10:23jorge-garciaFile Added: 38610_17Q4_mobilecore.diff
2018-06-22 10:24jorge-garciaFile Added: 38610_17Q4_posterminal.diff
2018-07-05 10:55hgbotCheckin
2018-07-05 10:55hgbotNote Added: 0105627
2018-07-05 10:56hgbotCheckin
2018-07-05 10:56hgbotNote Added: 0105628
2018-07-05 10:56hgbotStatusscheduled => resolved
2018-07-05 10:56hgbotResolutionopen => fixed
2018-07-05 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/adbaa8552b99fef17dac4771fef4b966f85482e9 [^]
2018-07-05 10:56hgbotCheckin
2018-07-05 10:56hgbotNote Added: 0105629
2018-07-05 10:56hgbotCheckin
2018-07-05 10:56hgbotNote Added: 0105630
2018-07-05 10:56hgbotCheckin
2018-07-05 10:56hgbotNote Added: 0105631
2018-07-05 10:57hgbotCheckin
2018-07-05 10:57hgbotNote Added: 0105632
2018-08-16 08:25marvintmReview Assigned To => marvintm
2018-08-16 08:25marvintmStatusresolved => closed
2018-08-16 08:25marvintmFixed in Version => RR18Q4
2018-11-28 07:17martinsdanIssue Monitored: martinsdan

Notes
(0105627)
hgbot   
2018-07-05 10:55   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3ee76f881e4fa5eed9db94124cdf18011a3ea62c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jun 18 13:37:57 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3ee76f881e4fa5eed9db94124cdf18011a3ea62c [^]

Related to issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

This commit includes:
 * Added in ob-dal is not null operator and is null operator.
 * In search and browse of products, the logic only shows those products which
   have price in the current pricelist.
 * Add order by in case multipricelist is enabled and the current pricelist is
   different from the default pricelist.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-product-browser.js
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0105628)
hgbot   
2018-07-05 10:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: adbaa8552b99fef17dac4771fef4b966f85482e9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jun 18 13:46:49 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/adbaa8552b99fef17dac4771fef4b966f85482e9 [^]

Fixed issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

This commit includes:
 * A new message to show to the user indicating the product has not been
   added because it has not price in the current pricelist.
 * Definition and default value for a new preference to allow a product
   to no have a price in the terminal's default pricelist.
 * Change Product.java query:
    * In remote search, the product is not loaded if it has no price in
      the current pricelist
    * In local search, the product is loaded even if it has no price in
      the default pricelist
 * In Product.java, method getRegularProductHql has been overloaded to avoid
   API change.
 * In WebPOS, the product is not shown if it has no price in the current
   pricelist. The product is also deleted if the user changes the customer
   and the new pricelist has no price in the new pricelist.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105629)
hgbot   
2018-07-05 10:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 08f76f6df89dab1593cbbb0e613cd10f7bd48dbc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 20 11:15:50 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/08f76f6df89dab1593cbbb0e613cd10f7bd48dbc [^]

Related to issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

With this project in remote for products, it's possible the remote search for a
product in the mainpricelist could return no results, in this case, the logic
should assume like it is not included in the pricelist.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105630)
hgbot   
2018-07-05 10:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3cc2b9576a5962997e0db38886b9734d08b5c00e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jun 21 09:49:14 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3cc2b9576a5962997e0db38886b9734d08b5c00e [^]

Related to issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

Move empty function to OB.Dal.get function.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105631)
hgbot   
2018-07-05 10:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bc70d06accd5117475c1f463d64980a50532de92
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jul 04 17:05:30 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bc70d06accd5117475c1f463d64980a50532de92 [^]

Ralted to issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

Added end of addProduct process controller.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0105632)
hgbot   
2018-07-05 10:57   
Repository: tools/automation/pi-mobile
Changeset: a4a68e6a73a1f3d0cad796676f67ed77e75a61fd
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jun 18 14:54:19 2018 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a4a68e6a73a1f3d0cad796676f67ed77e75a61fd [^]

Related to issue 38610: Products should not necessarily have a price in the main
pricelist to be loaded in the WebPOS

Change some tests of multipricelist due to the new order by in
multipricelist products.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/MPLLoadPrice.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/MPLModifyPriceList.java
---