Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038582Openbravo ERPA. Platformpublic2018-05-18 12:312018-05-30 09:40
Reporterkchoperena 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038582: [SERQA 4076]:In back-end, if we modify a date filter after make a search, it cannot be launch another search without clean filte
DescriptionIn back-end, if we have enabled lazy filtering functionality the date filters does not work properly. Used config in the attached image
Steps To ReproduceSteps:
 1.- Apply any value in a date filter (Ej.: Since 16-05-2018)
 2.- Search the data, click on V
 3.- Modify the value of the same filter (Ej.: Since 17-05-2018)
 Expected results: It is not possible launch another search without clean the filter. Also, the image of V tick will be not available.

Video: https://drive.google.com/file/d/1QZ7bN-266saznAl4nwHOj8Vw9K-DR1Is/view [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng LazyConfig.png (27,928) 2018-05-18 12:31
https://issues.openbravo.com/file_download.php?file_id=11805&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-05-18 12:31kchoperenaNew Issue
2018-05-18 12:31kchoperenaAssigned To => caristu
2018-05-18 12:31kchoperenaFile Added: LazyConfig.png
2018-05-18 12:31kchoperenaOBNetwork customer => Yes
2018-05-18 12:31kchoperenaModules => Core
2018-05-18 12:31kchoperenaResolution time => 1527804000
2018-05-18 12:31kchoperenaTriggers an Emergency Pack => No
2018-05-25 15:41caristuStatusnew => scheduled
2018-05-28 11:45hgbotCheckin
2018-05-28 11:45hgbotNote Added: 0104743
2018-05-28 11:45hgbotStatusscheduled => resolved
2018-05-28 11:45hgbotResolutionopen => fixed
2018-05-28 11:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c412dd9e950d263589ff6efbcf06589e8a1e2f29 [^]
2018-05-28 13:30hgbotCheckin
2018-05-28 13:30hgbotNote Added: 0104747
2018-05-28 13:33hgbotCheckin
2018-05-28 13:33hgbotNote Added: 0104748
2018-05-28 13:34caristuReview Assigned To => alostale
2018-05-28 16:08hudsonbotCheckin
2018-05-28 16:08hudsonbotNote Added: 0104753
2018-05-29 14:42alostaleNote Added: 0104770
2018-05-29 14:42alostaleStatusresolved => new
2018-05-29 14:42alostaleResolutionfixed => open
2018-05-29 17:12hudsonbotCheckin
2018-05-29 17:12hudsonbotNote Added: 0104777
2018-05-29 17:12hudsonbotCheckin
2018-05-29 17:12hudsonbotNote Added: 0104778
2018-05-29 18:44hgbotCheckin
2018-05-29 18:44hgbotNote Added: 0104788
2018-05-29 18:44caristuStatusnew => scheduled
2018-05-29 18:44caristuStatusscheduled => resolved
2018-05-29 18:44caristuResolutionopen => fixed
2018-05-30 00:14hudsonbotCheckin
2018-05-30 00:14hudsonbotNote Added: 0104796
2018-05-30 09:40alostaleNote Added: 0104800
2018-05-30 09:40alostaleStatusresolved => closed
2018-05-30 09:40alostaleFixed in Version => 3.0PR18Q3

Notes
(0104743)
hgbot   
2018-05-28 11:45   
Repository: erp/devel/pi
Changeset: c412dd9e950d263589ff6efbcf06589e8a1e2f29
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 28 09:03:30 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c412dd9e950d263589ff6efbcf06589e8a1e2f29 [^]

fixes bug 38582: wrong behavior after setting a date filter having lazy filtering

  The grid was not being set as ready to filter after setting a date filter using the date range dialog. Now, we explicitly put the grid in the correct status in that case.

  Together with this, a new function called getSourceGrid() has been added, which provides the reference to the parent (source) grid of the date filter. And we are using it where needed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-minidaterange.js
---
(0104747)
hgbot   
2018-05-28 13:30   
Repository: erp/devel/pi
Changeset: d6e036ff58fe1a7818919e819b1c7acfe2cf1476
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 28 13:29:53 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d6e036ff58fe1a7818919e819b1c7acfe2cf1476 [^]

related to issue 38582: properly check whether the range has changed

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-minidaterange.js
---
(0104748)
hgbot   
2018-05-28 13:33   
Repository: erp/devel/pi
Changeset: 4bc8745f6b75c8370f98f7045c8e2391c8bc036c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon May 28 13:33:35 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4bc8745f6b75c8370f98f7045c8e2391c8bc036c [^]

related to issue 38582: check first if lazy filtering is enabled

  Micro-optimization to avoid checking the changes in the date range if lazy filtering is not enabled

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-minidaterange.js
---
(0104753)
hudsonbot   
2018-05-28 16:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/816950756de8 [^]
Maturity status: Test
(0104770)
alostale   
2018-05-29 14:42   
Reopening.

Test cases:
OK - 1. Fill date directly in grid's text box
OK - 2. Fill date from in popup
OK - 3. Fill date to in poup
OK - 4. Change date from in popup
OK - 5. Change date to in popup
OK - 6. Change filter in grid's text box
OK - 7. Remove entered filter in grid's text box
FAIL - 8. Use the Clear button in poup
    -> the apply tick is not enabled
(0104777)
hudsonbot   
2018-05-29 17:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a5c637c20093 [^]
Maturity status: Test
(0104778)
hudsonbot   
2018-05-29 17:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a5c637c20093 [^]
Maturity status: Test
(0104788)
hgbot   
2018-05-29 18:44   
Repository: erp/devel/pi
Changeset: 8818ecc71e135f5076058471d85db1e8e8b412f5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue May 29 18:33:30 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8818ecc71e135f5076058471d85db1e8e8b412f5 [^]

related to issue 38582: enable apply tick when the range is cleared

  Check rangeItemValue if there is no new range defined:

  - If rangeItemValue is not null, it means that the range has been cleared: apply tick should be enabled
  - If rangeItemValue is null, the range has not changed (it is still empty): apply tick should not be enabled

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-minidaterange.js
---
(0104796)
hudsonbot   
2018-05-30 00:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/08f13cf1fa33 [^]
Maturity status: Test
(0104800)
alostale   
2018-05-30 09:40   
Reviewed.

Tested
OK - 1. Fill date directly in grid's text box
OK - 2. Fill date from in popup
OK - 3. Fill date to in poup
OK - 4. Change date from in popup
OK - 5. Change date to in popup
OK - 6. Change filter in grid's text box
OK - 7. Remove entered filter in grid's text box
OK - 8. Use the Clear button in poup