Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038556Openbravo ERPA. Platformpublic2018-05-14 18:572018-05-18 09:06
ReporterAtulOpenbravo 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q2.1Fixed in Version3.0PR18Q2.1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2018-03-07
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/2a79f597da83 [^]
Triggers an Emergency PackNo
Summary0038556: Default Expression in Selector Field does not work properly
DescriptionDefault expression in the selector field does not work properly.

for eg: In Goods Movement window, Stocked column in grid of Product selector should have default filter as Stocked = Yes

Expression used in reference: "Product Complete" | Defined Selector | Field | Stocked

if (OB.getWindowId() == '800051' ||
    OB.getWindowId() == '800052' ||
    OB.getWindowId() == '800096' ||
    OB.getWindowId() == '800027') {
  false
} else {
    if (OB.isSalesTransaction() == true || OB.getWindowId() == '170') {
      true
    } else {
        false
    }
}

However it does not work in latest pi.
Steps To ReproduceTest Plan

- Go to Goods Movement window and create a new record. Fill mandatory fields
- Go to Lines tab and create a new record.
- Press magnifying glass in Product selector.
- Check default filter in Stocked column of selector does not have filter applied as Stocked = Yes.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038548 closed caristu Default Expression in Selector Field does not work properly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-16 09:28caristuTypedefect => backport
2018-05-16 09:28caristuTarget Version => 3.0PR18Q2.1
2018-05-17 16:47hgbotCheckin
2018-05-17 16:47hgbotNote Added: 0104567
2018-05-17 16:47hgbotStatusscheduled => resolved
2018-05-17 16:47hgbotResolutionopen => fixed
2018-05-17 16:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q2.1/rev/554dc31721c056dd2345a5fd1b3d152f8093a4b3 [^]
2018-05-17 16:48caristuReview Assigned To => alostale
2018-05-18 09:06alostaleNote Added: 0104586
2018-05-18 09:06alostaleStatusresolved => closed
2018-05-18 09:06alostaleFixed in Version => 3.0PR18Q2.1

Notes
(0104567)
hgbot   
2018-05-17 16:47   
Repository: erp/backports/3.0PR18Q2.1
Changeset: 554dc31721c056dd2345a5fd1b3d152f8093a4b3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu May 17 10:05:57 2018 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR18Q2.1/rev/554dc31721c056dd2345a5fd1b3d152f8093a4b3 [^]

fixes issue 38556: Default Expression in Selector Field does not work properly

  After the changes introduced with[1] the request data is sent to the SelectorDefaultFilterActionHandler as part of the POST payload rather than in the query string. This caused that the selector id was not being found in that handler, avoiding the correct processing of the data.

  The problem has been fixed by retrieving the data to process both from the request parameters and content.

[1] https://code.openbravo.com/erp/devel/pi/rev/2a79f597da83870d152ee3176ffa679a01ac19d5 [^]

---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDefaultFilterActionHandler.java
---
(0104586)
alostale   
2018-05-18 09:06   
reviewed + tested