Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038551Openbravo ERP09. Financial managementpublic2018-05-15 09:552018-05-30 00:14
ReporterSandrahuguet 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038551: Improve performance of Add Multiple Payments process in Financial Account window
DescriptionImprove performance of Add Multiple Payments process in Financial Account window.
In a high volume environment.
Having 1000 payments pending to deposit in the financial account:
 - Select all: 6 min
 - Done: 3 min
Steps To ReproduceIn a high volume environment and having 1000 payments pending to deposit.
Login ERP
Go to Financial account and click on add multiple payments button
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0036180 closed markmm82 Add Multiple payments pick and execute performance 
related to defect 0035664 closed markmm82 Performance of Add Multiple Payments P&E grid should be improved 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-15 09:55SandrahuguetNew Issue
2018-05-15 09:55SandrahuguetAssigned To => Triage Finance
2018-05-15 09:55SandrahuguetModules => Core
2018-05-15 09:55SandrahuguetTriggers an Emergency Pack => No
2018-05-15 09:55SandrahuguetTag Attached: Performance
2018-05-15 10:06SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=17141#r17141
2018-05-15 10:06SandrahuguetSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17143#r17143
2018-05-15 10:23aferrazAssigned ToTriage Finance => AtulOpenbravo
2018-05-17 09:22vmromanosRelationship addedrelated to 0036180
2018-05-17 09:22vmromanosRelationship addedrelated to 0035664
2018-05-18 21:36AtulOpenbravoStatusnew => scheduled
2018-05-25 17:40AtulOpenbravoNote Added: 0104721
2018-05-25 17:43AtulOpenbravoNote Edited: 0104721bug_revision_view_page.php?bugnote_id=0104721#r17198
2018-05-25 17:44AtulOpenbravoNote Deleted: 0104721
2018-05-25 17:51AtulOpenbravoNote Added: 0104722
2018-05-25 17:51AtulOpenbravoNote Edited: 0104722bug_revision_view_page.php?bugnote_id=0104722#r17200
2018-05-25 17:56AtulOpenbravoNote Edited: 0104722bug_revision_view_page.php?bugnote_id=0104722#r17201
2018-05-29 17:56hgbotCheckin
2018-05-29 17:56hgbotNote Added: 0104782
2018-05-29 17:56hgbotStatusscheduled => resolved
2018-05-29 17:56hgbotResolutionopen => fixed
2018-05-29 17:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f8bc7fbdf77ec2fcdc170275744db362a2c97946 [^]
2018-05-29 17:57dmiguelezReview Assigned To => dmiguelez
2018-05-29 17:57dmiguelezNote Added: 0104783
2018-05-29 17:57dmiguelezStatusresolved => closed
2018-05-29 17:57dmiguelezFixed in Version => 3.0PR18Q3
2018-05-30 00:14hudsonbotCheckin
2018-05-30 00:14hudsonbotNote Added: 0104794

Notes
(0104722)
AtulOpenbravo   
2018-05-25 17:51   
(edited on: 2018-05-25 17:56)
In Local environment, Add Multiple Payments process

Before Change

doExecute--------------: (1538961 ms)
getTransactionMaxLineNo: (4000 ms) approx. as it was not captured.

 
After Change

doExecute--------------: (1538961 ms)
getTransactionMaxLineNo: (2239 ms)

% Improvement in doExecute: 83.63%

In BUT big environment, Add Multiple Payments process


Before Change

doExecute--------------: (1198728 ms)
getTransactionMaxLineNo: (2047 ms)
AD_GET_DOC_LE_BU-------: (7289 ms)


 
After Change

doExecute--------------: (369412 ms)
getTransactionMaxLineNo: (1293 ms)
AD_GET_DOC_LE_BU-------: (491 ms)


% Improvement in doExecute--------------: 69.18%
% Improvement in getTransactionMaxLineNo: 36.83%
% Improvement in AD_GET_DOC_LE_BU-------: 93.26%

Note: AD_GET_DOC_LE_BU improvement is achieved by applying Persist Org Info issue 33650 fixes.
(0104782)
hgbot   
2018-05-29 17:56   
Repository: erp/devel/pi
Changeset: f8bc7fbdf77ec2fcdc170275744db362a2c97946
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 25 21:00:17 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f8bc7fbdf77ec2fcdc170275744db362a2c97946 [^]

Fixes Issue 38551: Improve performance of Add Multiple Payments process
in Financial Account window

** Clear session after processing each payment being used to create
Financial Account Transaction.
** getTransactionMaxLineNo is already called to set Line No in
TransactionsDao's createFinAccTransaction method so avoid it again
in AddMultiplePaymentsHandler

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddMultiplePaymentsHandler.java
---
(0104783)
dmiguelez   
2018-05-29 17:57   
Code Review + Testing Ok
(0104794)
hudsonbot   
2018-05-30 00:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/08f13cf1fa33 [^]
Maturity status: Test