0038524: can't configure timeout for sending emails

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038524

Openbravo ERP

A. Platform

public

2018-05-11 13:29

2018-08-08 13:06

Reporter

alostale

Assigned To

jarmendariz

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q4

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038524: can't configure timeout for sending emails

Description

It's not possible to configure any timeout for sending emails. In case the email server doesn't respond, it is possible to reach a situation where the thread sending the email is indefinitely stuck.

Steps To Reproduce

1. Configure a very slow smtp server
You can use, ie., a fake smpt server like dumbster [1]

           SimpleSmtpServer.start(8025);

    and add breakpoints to simulate slowness

2. Configure Client in Openbravo to make use of it
3. Open a completed Sales Order
4. Click on send email
  -> Check the threads gets stuck while the email server is not responding:
"ajp-bio-127.0.0.1-8009-exec-678" daemon prio=10 tid=0x00007fd2800cf800 nid=0x1f7ff runnable [0x00007fd38befb000]
   java.lang.Thread.State: RUNNABLE
    at java.net.SocketInputStream.socketRead0(Native Method)
    at java.net.SocketInputStream.read(SocketInputStream.java:153)
    at java.net.SocketInputStream.read(SocketInputStream.java:122)
    at com.sun.mail.util.TraceInputStream.read(TraceInputStream.java:110)
    at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
    at java.io.BufferedInputStream.read(BufferedInputStream.java:254)
    - locked <0x00000001efd082a0> (a java.io.BufferedInputStream)
    at com.sun.mail.util.LineInputStream.readLine(LineInputStream.java:89)
    at com.sun.mail.smtp.SMTPTransport.readServerResponse(SMTPTransport.java:2131)
    at com.sun.mail.smtp.SMTPTransport.openServer(SMTPTransport.java:1912)
    at com.sun.mail.smtp.SMTPTransport.protocolConnect(SMTPTransport.java:638)
    at javax.mail.Service.connect(Service.java:317)
    - locked <0x00000001efd083f0> (a com.sun.mail.smtp.SMTPTransport)
    at javax.mail.Service.connect(Service.java:176)
    at javax.mail.Service.connect(Service.java:125)
    at org.openbravo.erpCommon.utility.poc.EmailManager.sendEmail(EmailManager.java:170)
    at org.openbravo.erpCommon.utility.reporting.printing.PrintController.sendDocumentEmail(PrintController.java:815)

---
[1] https://github.com/kirviq/dumbster [^]

Proposed Solution

* Make it possible to configure email to include timeouts
* Although JavaMail supports up to 3 different timeouts (timeout, connectiontimeout, writetimeout), I think this shouldn't be exposed to end user, a single timeout field should configure (with the same value?) all of them.
* Note current 1.4.4 JavaMail version, released in 2011, only supports connectiontimeout. We might need to upgrade to latest version to do a better support. Attached patch is tested with current latest version (1.6.1) and I found no issues, using gmail as smtp server.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0038567	closed	alostale	Openbravo ERP	can get stuck sending emails
related to	defect	0038934	new	Retail	Retail Modules	Emails are no longer sent via POS
related to	feature request	0040622	new	Triage Platform Base	Openbravo ERP	Improve testing coverage on mail configuration
causes	defect	0039649	closed	caristu	Openbravo ERP	Cannot send mail using EmailEventManager
causes	defect	0040603	closed	jarmendariz	Openbravo ERP	NPE sending email if timeout not set