0038518: Ability of compiling subreports with HttpSecureAppServlet.renderJR

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038518

Openbravo ERP

A. Platform

public

2018-05-10 17:49

2018-08-30 14:12

Reporter

vmromanos

Assigned To

caristu

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q3

Merge Request Status

Review Assigned To

alostale

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038518: Ability of compiling subreports with HttpSecureAppServlet.renderJR

Description

When a jrxml has a parameter that starts with SUBREP_<subreportfilename> the system should automatically compile the subreport on the fly.

This feature is not working when called from HttpSecureAppServlet.renderJR().

HttpSecureAppServlet.renderJR() line 1274 calls ReportingUtils.exportJR() that calls another implementation of ReportingUtils.exportJR():

exportJR(jasperFilePath, expType, parameters, target, addProcessDefinitionParameters,
connectionProvider, data, additionalExportParameters, false);

The last parameter (false) controls the subreport compilation process. Since it's hardcoded to false, the subreports are never compiled.

There is no renderJR method in HttpSecureAppServlet that ends calling ReportingUtils.exportJR() to force compiling subreports

Steps To Reproduce

This can be reproduced in core with a hack.

Open RptM_Requisition.jrxml and add a SUBREP_RptM_Requisition_Lines parameter.
Open RptM_Requisition.java and remove subreport compilation lines:
JasperReport jasperReportLines;
    try {
      jasperReportLines = ReportingUtils.compileReport(strBaseDesign
          + "/org/openbravo/erpReports/RptM_Requisition_Lines.jrxml");
    } catch (JRException e) {
      e.printStackTrace();
      throw new ServletException(e.getMessage());
    }

    parameters.put("SR_LINES", jasperReportLines);

Try to print a requisition from the UI. No lines will be printed

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	design defect	0034796	closed	caristu	Openbravo ERP	Not possible to compile subreports automatically in process definition reports
related to	feature request	0037741	closed	caristu	Openbravo ERP	Ability to keep in cache the compiled Jasper Reports
related to	feature request	0032329	closed	platform	Openbravo ERP	Overload the renderJr method on HttpSecureAppServlet to allow specify to compile the subreports
related to	defect	0038647	closed	caristu	Retail Modules	Do not compile the subreport of the CashUp report manually
blocks	defect	0038340	closed	vmromanos	Modules	There is no possibility to put a report template for Distribution Orders in the Document Type
blocks	feature request	0038588	new	Triage Omni OMS	Openbravo ERP	Refactor reports based on HttpSecureAppServlet.renderJR to avoid manual subreport compilation
causes	defect	0039859	closed	AugustoMauch	Openbravo ERP	Reconciliation reports not generated