Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038516Openbravo ERPA. Platformpublic2018-05-10 13:112020-10-01 16:49
ReporterSandrahuguet 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038516: Add a feature to allow to disable transactional filters in transactional windows easily without code changes
DescriptionThe filter being present by default in transactional windows[1] filters by not process or modified in last x days was intended to reduce set of rows shown by default and improve performance.

However without extra matching indexes that filter in fact can hurt performance in high data volumes.

It would be nice if it would be possible to deactivate that filter.

Note:
The window type (Maintain vs. Transactional) also controls that filter but changing it affects other areas (UI template, Utility.getContext) so does not seem a good choice just to disable the filter

See project page for additional information: http://wiki.openbravo.com/wiki/Projects:Disable_Transactional_Filters [^]

[1] http://wiki.openbravo.com/wiki/Standard_Windows#Transactional_Windows [^]
Steps To ReproduceN/A
Proposed SolutionIt should be possible to disable it per configuration. As most window configuration is already centralized in the "Grid configuration" that seems to be a good place for such an option.
Alternative could be a preference similar to "Disabling Linked Items".
Additional Information
TagsNOR, Performance
Relationships
related to defect 0038697 acknowledged Triage Platform Base in transactional filters incorrect range is displayed after modifying it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-10 13:11SandrahuguetNew Issue
2018-05-10 13:11SandrahuguetAssigned To => platform
2018-05-10 13:11SandrahuguetModules => Core
2018-05-10 13:11SandrahuguetTriggers an Emergency Pack => No
2018-05-10 13:12SandrahuguetTag Attached: Performance
2018-05-10 13:13SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=17115#r17115
2018-05-10 13:19shuehnerSummaryIt would be fine to be able to disable implicit filters in transactional windows => Add a feature to allow to disable implicit filters in transactional windows easily without code changes
2018-05-10 13:19shuehnerDescription Updatedbug_revision_view_page.php?rev_id=17116#r17116
2018-06-05 09:52alostaleRelationship addedrelated to 0038697
2019-01-18 11:24caristuAssigned Toplatform => caristu
2019-01-18 11:24caristuSummaryAdd a feature to allow to disable implicit filters in transactional windows easily without code changes => Add a feature to allow to disable transactional filters in transactional windows easily without code changes
2019-01-18 11:24caristuDescription Updatedbug_revision_view_page.php?rev_id=18145#r18145
2019-01-18 11:24caristuProposed Solution updated
2019-01-18 11:24caristuProposed Solution updated
2019-01-18 11:25caristuDescription Updatedbug_revision_view_page.php?rev_id=18146#r18146
2019-01-18 12:57hgbotCheckin
2019-01-18 12:57hgbotNote Added: 0109015
2019-01-21 10:04hgbotCheckin
2019-01-21 10:04hgbotNote Added: 0109031
2019-01-21 10:04hgbotStatusnew => resolved
2019-01-21 10:04hgbotResolutionopen => fixed
2019-01-21 10:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/66f246023571bda1da290c9c43195b7cc5e77dbf [^]
2019-01-21 10:04hgbotCheckin
2019-01-21 10:04hgbotNote Added: 0109032
2019-01-21 10:10hgbotCheckin
2019-01-21 10:10hgbotNote Added: 0109033
2019-01-21 10:25caristuNote Added: 0109035
2019-01-21 10:25caristuReview Assigned To => alostale
2019-01-21 11:31caristuDescription Updatedbug_revision_view_page.php?rev_id=18163#r18163
2019-01-23 17:42caristuDescription Updatedbug_revision_view_page.php?rev_id=18177#r18177
2019-01-25 10:22alostaleNote Added: 0109244
2019-01-25 10:22alostaleStatusresolved => closed
2019-01-25 10:22alostaleFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110738
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110742
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110743
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110744
2020-10-01 16:49rafarodaTag Attached: NOR

Notes
(0109015)
hgbot   
2019-01-18 12:57   
Repository: erp/devel/pi
Changeset: 75217c44f638dfc833f567ca030c219478ea4ff3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 18 12:54:55 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/75217c44f638dfc833f567ca030c219478ea4ff3 [^]

related to issue 38516: Initial code cleanup

  - Use diamond operator
  - Remove the usage of the literal "false" boolean value.
  - Replaced if-then-else statement by a single return statement in isDataSourceTable()
  - Use isEmpty() to check whether the collection is empty or not
  - Removed commented-out line of code
  - Add missing "@Override" annotation above getComponentTemplate() signature
  - Iterate over the "entrySet" instead of the "keySet"
  - Put single-quotes around '/' to use the faster "indexOf(char)" method.
  - Define a constant instead of duplicating literal "OBUIAPP_PickAndExecute" 5 times

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
(0109031)
hgbot   
2019-01-21 10:04   
Repository: erp/devel/pi
Changeset: 66f246023571bda1da290c9c43195b7cc5e77dbf
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 21 10:01:56 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/66f246023571bda1da290c9c43195b7cc5e77dbf [^]

fixes issue 38516: Add ability to disable the transactional filters

---
M modules/org.openbravo.client.application/src-db/database/model/tables/OBUIAPP_GC_SYSTEM.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
---
(0109032)
hgbot   
2019-01-21 10:04   
Repository: erp/devel/pi
Changeset: 9865035f0712040c0fb3c9e7b4b02795a21fcf22
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 21 10:03:30 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9865035f0712040c0fb3c9e7b4b02795a21fcf22 [^]

related to issue 38516: Add test cases

  - Add new ViewGenerationTest base test that can be extended when testing view generation features
  - The existing ViewGeneration test now extends ViewGenerationTest
  - Add new ConfigurableTransactionalFilters test class

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src-test/src/org/openbravo/test/base/TestConstants.java
M src-test/src/org/openbravo/test/views/ViewGeneration.java
M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java
A src-test/src/org/openbravo/test/views/ConfigurableTransactionalFilters.java
A src-test/src/org/openbravo/test/views/ViewGenerationTest.java
---
(0109033)
hgbot   
2019-01-21 10:10   
Repository: erp/devel/pi
Changeset: 46f6eb5a22dc360a75a0a4853056da9fb763a003
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 21 10:10:25 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/46f6eb5a22dc360a75a0a4853056da9fb763a003 [^]

related to issue 38516: revert unintended change

---
M src-test/src/org/openbravo/test/views/ViewGenerationWithDifferentConfigLevelTest.java
---
(0109035)
caristu   
2019-01-21 10:25   
Documentation: http://wiki.openbravo.com/wiki/User_Interface_Introduction#Grid_Configuration [^]
(0109244)
alostale   
2019-01-25 10:22   
reviewed + tested
(0110738)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110742)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110743)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110744)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test