Openbravo Issue Tracking System - Modules |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0038509 | Modules | Remittance | public | 2018-05-09 16:12 | 2018-05-15 17:47 |
|
Reporter | ngarcia | |
Assigned To | AtulOpenbravo | |
Priority | urgent | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | | |
Merge Request Status | |
Regression date | |
Regression introduced by commit | |
Regression level | |
Review Assigned To | aferraz |
Support ticket | |
OBNetwork customer | |
Regression introduced in release | |
|
Summary | 0038509: Sales Invoice Payment Plan Due date cannot be modified when related remitted payment has been protested and voided |
Description | Sales Invoice Payment Plan Due date cannot be modified when related remitted payment has been protested and voided |
Steps To Reproduce | As system admin role:
Set as Displayed the 'Sales Invoice - Payment Plan - Modify Payment Plan'
Compile the tab and restart tomcat
As group admin role:
Create a Sales Invoice, set Remittance as its payment method, add a line to it and complete it
Add a payment to it, execute it and include it on a remittance
Go to Settle/Protest Remittance and protest the previous payment
Go to Payment In window, check the payment is in Awaiting Execution status
Void it (Reactivate button, Void option)
Return to the Sales Invoice, select the payment plan record and Modify Payment Plan
Check you cannot increase the due date and you should
The following error message is shown
"The invoice is already included in a Remittance." |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | caused by | defect | 0038288 | | closed | collazoandy4 | Sales Invoice Payment Plan Due date can be modified when related payment is in Remitted status |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2018-05-09 16:12 | ngarcia | New Issue | |
2018-05-09 16:12 | ngarcia | Assigned To | => Triage Finance |
2018-05-09 16:12 | ngarcia | Resolution time | => 1527631200 |
2018-05-09 16:12 | ngarcia | Issue generated from | 0038288 |
2018-05-09 16:12 | ngarcia | Relationship added | causes 0038288 |
2018-05-09 16:12 | ngarcia | Relationship replaced | caused by 0038288 |
2018-05-09 16:12 | ngarcia | Issue Monitored: networkb | |
2018-05-09 16:20 | Practics | Issue Monitored: Practics | |
2018-05-09 18:05 | aferraz | Assigned To | Triage Finance => AtulOpenbravo |
2018-05-10 09:22 | AtulOpenbravo | Status | new => scheduled |
2018-05-15 15:58 | AtulOpenbravo | Note Added: 0104520 | |
2018-05-15 17:26 | hgbot | Checkin | |
2018-05-15 17:26 | hgbot | Note Added: 0104528 | |
2018-05-15 17:26 | hgbot | Status | scheduled => resolved |
2018-05-15 17:26 | hgbot | Resolution | open => fixed |
2018-05-15 17:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/dde72550fc6db493bfcf97de7bf5604f3b859f57 [^] |
2018-05-15 17:26 | hgbot | Checkin | |
2018-05-15 17:26 | hgbot | Note Added: 0104529 | |
2018-05-15 17:46 | hgbot | Checkin | |
2018-05-15 17:46 | hgbot | Note Added: 0104530 | |
2018-05-15 17:47 | aferraz | Review Assigned To | => aferraz |
2018-05-15 17:47 | aferraz | Note Added: 0104531 | |
2018-05-15 17:47 | aferraz | Status | resolved => closed |
2018-05-15 17:47 | aferraz | Note Added: 0104532 | |
Notes |
|
|
Test Plan
** Pre-requisite:Install Remittance module and apply data set in F&B Espana Organization.
- Login as System admin role:
- Set Displayed =Yes in 'Sales Invoice - Payment Plan - Modify Payment Plan'
- If required compile the tab and restart tomcat
- Login as F&B International Group admin role:
- In Financial Account "Cuenta de Banco" add payment method for Remittance.
- Create a Sales Invoice, set Remittance as its payment method, add a line to it and complete it
- Add a payment to it, execute it.
- Go to Remittance window and search for the one created by executing earlier payment. Process it.
- Go to Settle/Protest Remittance and protest the previous payment
- Go to Payment In window, check the payment is in Awaiting Execution status
- Void it (Reactivate button, Void option)
- Return to the Sales Invoice, select the payment plan record and Modify Payment Plan, Try to set a different due date from one is existing in the line.
- Realize that you can modify the due date. |
|
|
(0104528)
|
hgbot
|
2018-05-15 17:26
|
|
Repository: erp/mods/org.openbravo.module.remittance
Changeset: dde72550fc6db493bfcf97de7bf5604f3b859f57
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 15 19:21:53 2018 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/dde72550fc6db493bfcf97de7bf5604f3b859f57 [^]
Fixes Issue 0038509: Sales Invoice Payment Plan Due date cannot be
modified when related remitted payment has been protested and voided
While checking whether there exists a payment schedule detail for
payment linked with invoices are included in remittance, consider only
those payment schedule details which are not cancelled so that user
can modify payment plan of such invoices.
---
M src/org/openbravo/module/remittance/hooks/REMModifyPaymentPlanHook.java
---
|
|
|
(0104529)
|
hgbot
|
2018-05-15 17:26
|
|
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 0a91ed6552bc53aab513317481f321f552289c5e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 15 17:07:41 2018 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/0a91ed6552bc53aab513317481f321f552289c5e [^]
Related to issue 38509: Code review improvements
Fix copyright.
Remove unneeded throws OBException.
Use query.uniqueResult() != null instead of !query.list().isEmpty().
---
M src/org/openbravo/module/remittance/hooks/REMModifyPaymentPlanHook.java
---
|
|
|
(0104530)
|
hgbot
|
2018-05-15 17:46
|
|
|
|
|
|
|
|
OBX will be published once dependency is updated to 18Q3 |
|