0038496: Exception in ProcessHQLQuery can result in error JSON response being not properly formatted

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038496

Retail Modules

Web POS

public

2018-05-07 15:24

2018-10-08 20:58

Reporter

AugustoMauch

Assigned To

rqueralta

Priority

normal

Severity

major

Reproducibility

have not tried

Status

scheduled

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038496: Exception in ProcessHQLQuery can result in error JSON response being not properly formatted

Description

If there is an exception in the ProcessHQLQuery after this line [1] but before this line [2], the resulting error JSON response will not be properly formatted, because it will contain the start of the data json array declaration but will not contain the closing brace.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java#l277 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java#l318 [^]

Steps To Reproduce

Force any runtime exception between these two lines [1], [2]. Login in in the POS, and check that the exception is captured and that the resulting JSON response is not properly formatted. It will look like this:

{
    "response": {
        "data": ["status": -1, "error": {
                "message": "",
                "title": "",
                "className": "java.lang.ClassCastException"
            }, "totalRows": 0
        }
    }

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java#l277 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/tip/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java#l318 [^]

Proposed Solution

Additional Information