Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038490Openbravo ERP04. Warehouse managementpublic2018-05-04 12:352018-05-14 13:09
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket1702
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038490: Empty error message is shown when processing a stock reservation without available stock and without attribute set value
DescriptionEmpty error message is shown when processing a stock reservation without available stock and without attribute set value

The problem is in M_RESERVATION_POST database function:

RAISE EXCEPTION '%', '@NotEnoughAvailableStock@ : ' || cur_not_available.locatorName || ' - ' || cur_not_available.attributeName;

The description for '0' record is empty in m_attributesetinstance table and a null value is being concatenated with the message
Steps To ReproduceAs group admin role:
   Set 'Enable Stock Reservations' preference to Y
   Log out and log in
   Create a Stock Reservation for 'F&B España - Región Norte' and 'Cerveza Ale 0,5L' product
   Manage Stock and select the whole stocked quantity
   Do not process it
   Create a goods shipment
   Add 'Cerveza Ale 0,5L' product and ship the whole stocked quantity
   Complete it

   Return to Stock Reservations window and try to process the reservation
   An empty error message is shown and the log does not show any information
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-05-04 12:35ngarciaNew Issue
2018-05-04 12:35ngarciaAssigned To => Triage Finance
2018-05-04 12:35ngarciaOBNetwork customer => Yes
2018-05-04 12:35ngarciaModules => Core
2018-05-04 12:35ngarciaSupport ticket => 1702
2018-05-04 12:35ngarciaResolution time => 1527199200
2018-05-04 12:35ngarciaTriggers an Emergency Pack => No
2018-05-04 12:35ngarciaIssue Monitored: networkb
2018-05-04 12:37ngarciaDescription Updatedbug_revision_view_page.php?rev_id=17090#r17090
2018-05-08 08:50vmromanosAssigned ToTriage Finance => AtulOpenbravo
2018-05-08 19:52AtulOpenbravoStatusnew => scheduled
2018-05-09 10:16AtulOpenbravoNote Added: 0104343
2018-05-11 13:58hgbotCheckin
2018-05-11 13:58hgbotNote Added: 0104478
2018-05-11 13:58hgbotStatusscheduled => resolved
2018-05-11 13:58hgbotResolutionopen => fixed
2018-05-11 13:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/324ddcc5adc96092a47f4fa1ad5d5421b08bfda3 [^]
2018-05-11 14:22aferrazReview Assigned To => aferraz
2018-05-11 14:22aferrazNote Added: 0104483
2018-05-11 14:22aferrazStatusresolved => closed
2018-05-11 14:22aferrazFixed in Version => 3.0PR18Q3
2018-05-14 13:09hudsonbotCheckin
2018-05-14 13:09hudsonbotNote Added: 0104498

Notes
(0104343)
AtulOpenbravo   
2018-05-09 10:16   
- Login as F&B International Group Admin role.
- Set 'Enable Stock Reservations' preference to Y
- Log out and log in
- Create a Stock Reservation for 'F&B España - Región Norte' and 'Cerveza Ale 0,5L' product, Quantity = (Stocked quantity)
- Manage Stock and select the whole stocked quantity
- Do not process it
- Create a goods shipment for business partner.
- Add 'Cerveza Ale 0,5L' product and ship the whole stocked quantity
- Complete it
- Return to Stock Reservations window and try to process the reservation
- Realize that proper error message is shown about not enough stock available with locator name and blank attribute name.
(0104478)
hgbot   
2018-05-11 13:58   
Repository: erp/devel/pi
Changeset: 324ddcc5adc96092a47f4fa1ad5d5421b08bfda3
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri May 11 00:45:46 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/324ddcc5adc96092a47f4fa1ad5d5421b08bfda3 [^]

Fixes Issue 0038490: Empty error message is shown when processing a
stock reservation without available stock and without attribute set
value

Use COALESCE(TO_CHAR(cur_not_available.attributeName), '') to avoid null
value in the description of attribute set instance with id 0

---
M src-db/database/model/functions/M_RESERVATION_POST.xml
---
(0104483)
aferraz   
2018-05-11 14:22   
Code review + Testing OK
(0104498)
hudsonbot   
2018-05-14 13:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ed385e0e027b [^]
Maturity status: Test