Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038467Retail ModulesWeb POSpublic2018-04-27 13:532018-05-10 11:05
Reportermaite 
Assigned Togorka_gil 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q2Fixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in releasemain
Regression introduced by commithttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f4fb9c07eb350e512bafe7547473d226da3b7efa [^]
Triggers an Emergency PackNo
Summary0038467: getPaymentAmount() is not being rounded and causes ticket is identified as "hasReceiptChange"=true
DescriptionWhen ticket is paid using higher amount but change is given in same currency, it should not be identified as "change"
Steps To Reproduce0. Access Terminal, select any product and set price=1500.40
1. Pay ticket setting amount=1550 (so change of 49.6 is calculated) and press done
2. Access backoffice to review the sales order and realize that payment plan information is incorrect as change amount has been identified as outstanding amount. Also, navigate to Payment document and realize that details are incorrect as gl item has been used when it should not.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0038466 closed gorka_gil getPaymentAmount() is not being rounded and causes ticket is identified as "hasReceiptChange"=true 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-27 14:01marvintmTypedefect => backport
2018-04-27 14:01marvintmTarget Version => RR18Q2
2018-05-02 14:12hgbotCheckin
2018-05-02 14:12hgbotNote Added: 0104203
2018-05-02 14:12hgbotStatusscheduled => resolved
2018-05-02 14:12hgbotResolutionopen => fixed
2018-05-02 14:12hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR18Q2/org.openbravo.retail.posterminal/rev/f36c33e349c70ea3b4371e65867007c62b37c783 [^]
2018-05-04 14:45marvintmReview Assigned To => marvintm
2018-05-04 14:45marvintmStatusresolved => closed
2018-05-04 14:45marvintmFixed in Version => RR18Q2
2018-05-10 11:05marvintmAssigned ToRetail => gorka_gil

Notes
(0104203)
hgbot   
2018-05-02 14:12   
Repository: retail/backports/3.0RR18Q2/org.openbravo.retail.posterminal
Changeset: f36c33e349c70ea3b4371e65867007c62b37c783
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed May 02 12:26:25 2018 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR18Q2/org.openbravo.retail.posterminal/rev/f36c33e349c70ea3b4371e65867007c62b37c783 [^]

Fixes issue 38467: Fix precision of payment amount read from json in the order loader.

Payment amount when read from json was passed to Double and then to BigDecimal which produce precision problems.
The precision problems makes that the check if there is change to be true, when in really there isn't change,
which produce the behaviour reported in the issue.

Now readed as string from json and passed directly to BigDecimal.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---