Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038450Openbravo ERPA. Platformpublic2018-04-25 14:182018-05-09 19:29
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038450: Allow to download attachments in temporary files using the attachment name without concurrency problems
DescriptionAllow to download attachments in temporary files using the attachment name itself without having (possible) concurrency problems in case two users download the same attachment at the same time.

Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038188 closed caristu Concurrency problem when downloading attachments with attachment methods that downloads temp files 
depends on backport 00384513.0PR18Q2 closed caristu Allow to download attachments in temporary files using the attachment name without concurrency problems 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-25 14:18caristuNew Issue
2018-04-25 14:18caristuAssigned To => platform
2018-04-25 14:18caristuModules => Core
2018-04-25 14:18caristuTriggers an Emergency Pack => No
2018-04-25 14:18caristuStatusnew => scheduled
2018-04-25 15:48caristuRelationship addedrelated to 0038188
2018-04-25 15:59hgbotCheckin
2018-04-25 15:59hgbotNote Added: 0104080
2018-04-25 15:59hgbotStatusscheduled => resolved
2018-04-25 15:59hgbotResolutionopen => fixed
2018-04-25 15:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/87ee63f96d1f75f0539a54f9c340e8e83571a43e [^]
2018-04-25 16:00caristuAssigned Toplatform => caristu
2018-04-25 16:00caristuReview Assigned To => alostale
2018-04-25 16:15hgbotCheckin
2018-04-25 16:15hgbotNote Added: 0104082
2018-04-27 13:09alostaleNote Added: 0104158
2018-04-27 13:09alostaleStatusresolved => closed
2018-04-27 13:09alostaleFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104398
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104399

Notes
(0104080)
hgbot   
2018-04-25 15:59   
Repository: erp/devel/pi
Changeset: 87ee63f96d1f75f0539a54f9c340e8e83571a43e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 25 15:50:10 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/87ee63f96d1f75f0539a54f9c340e8e83571a43e [^]

fixes bug 38450: Remove temp file's directory used to download the attachment

  Now the AttachImplementationManager deletes also the temp file's directory used to download the attachment. This change only affects to those attach implementations which return the downloaded attachment inside a temporary file.

  With this change now that attach implementations are able generate those temporary files with any name by creating them inside folders with random names. This is intended to avoid concurrency problems in case two users download the same attachment at the same time.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
---
(0104082)
hgbot   
2018-04-25 16:15   
Repository: erp/devel/pi
Changeset: d79617fce296c7e92706dddb63d4459dda7959c2
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 25 16:14:22 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d79617fce296c7e92706dddb63d4459dda7959c2 [^]

related to issue 38450: apply the logic on "Download All" also

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
---
(0104158)
alostale   
2018-04-27 13:09   
reviewed + tested
(0104398)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test
(0104399)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test