Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038445Openbravo ERPA. Platformpublic2018-04-25 13:212018-06-08 11:30
Reportercaristu 
Assigned Tojarmendariz 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q3Fixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038445: Do not use positional query parameters with Query (Retail)
DescriptionLegacy-style query parameters ('?') are no longer supported in Hibernate 5.3[1].

Therefore, queries generated with Query class using such kind of parameters are not working anymore starting from that Hibernate version. This issue affects to the methods using an int that determines the parameter position:

 - setParameter(int, Object)
 - setString(int, String)
 - setInteger(int, int)
 - setDate(int, Date)
 - etc

Named parameters should be used instead.

[1] https://hibernate.atlassian.net/browse/HHH-12101 [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038442 closed caristu Do not use positional query parameters with Query 
related to defect 00384463.0PR18Q3 closed jarmendariz Do not use positional query parameters with Query (Modules) 
related to feature request 0037064 closed caristu upgrade hibernate to 5.3.2 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-25 13:21caristuNew Issue
2018-04-25 13:21caristuAssigned To => jarmendariz
2018-04-25 13:21caristuModules => Core
2018-04-25 13:21caristuTriggers an Emergency Pack => No
2018-04-25 13:21caristuIssue generated from0038442
2018-04-25 13:21caristuRelationship addedrelated to 0038442
2018-04-25 13:23caristuTarget Version => 3.0PR18Q3
2018-04-25 13:24caristuRelationship addedrelated to 0038446
2018-04-27 13:25alostaleRelationship addedrelated to 0037064
2018-06-04 11:24jarmendarizStatusnew => scheduled
2018-06-05 18:11hgbotCheckin
2018-06-05 18:11hgbotNote Added: 0104961
2018-06-05 18:11hgbotStatusscheduled => resolved
2018-06-05 18:11hgbotResolutionopen => fixed
2018-06-05 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e8ecd06a02ebdf906a6a4ddda5027e6a6f80b23 [^]
2018-06-05 18:11hgbotCheckin
2018-06-05 18:11hgbotNote Added: 0104962
2018-06-05 18:12hgbotCheckin
2018-06-05 18:12hgbotNote Added: 0104963
2018-06-05 18:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e8ecd06a02ebdf906a6a4ddda5027e6a6f80b23 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c9a4a5d95eb50f02832051a9d5dc2ecf66eee99e [^]
2018-06-05 18:12hgbotCheckin
2018-06-05 18:12hgbotNote Added: 0104964
2018-06-06 08:58jarmendarizReview Assigned To => caristu
2018-06-08 11:30caristuNote Added: 0105031
2018-06-08 11:30caristuStatusresolved => closed
2018-06-08 11:30caristuFixed in Version => 3.0PR18Q3

Notes
(0104961)
hgbot   
2018-06-05 18:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0e8ecd06a02ebdf906a6a4ddda5027e6a6f80b23
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Mon Jun 04 11:25:36 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e8ecd06a02ebdf906a6a4ddda5027e6a6f80b23 [^]

Fixed issue 38445: Removed positional parameters in Queries.

Positional parameters will be deprecated in future versions of Hibernate, so
its better not using it to make transition smoother.

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
---
(0104962)
hgbot   
2018-06-05 18:11   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 9d5c895e2bfc2d430fc044dacb5232d993310105
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Jun 05 11:21:01 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9d5c895e2bfc2d430fc044dacb5232d993310105 [^]

Related to issue 38445: Replaced Query.setString to setParameter.

Starting from Hibernate 5.2, setString(String, String) is marked as deprecated.

---
M src/org/openbravo/mobile/core/listener/StatusBackgroundProcessScheduler.java
M src/org/openbravo/mobile/core/login/MobileCoreLoginHandler.java
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
M src/org/openbravo/mobile/core/servercontroller/ForceTransitionToOnline.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerStatusInformation.java
---
(0104963)
hgbot   
2018-06-05 18:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c9a4a5d95eb50f02832051a9d5dc2ecf66eee99e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Mon Jun 04 11:35:08 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c9a4a5d95eb50f02832051a9d5dc2ecf66eee99e [^]

Fixed issue 38445: Removed positional parameters in Queries.

Positional parameters will be deprecated in future versions of Hibernate, so
its better not using it to make transition smoother.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M src/org/openbravo/retail/posterminal/term/CashCloseReport.java
---
(0104964)
hgbot   
2018-06-05 18:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a4f9ba15a7e9f11dc31496a8bef9430b25155692
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Jun 05 11:22:07 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a4f9ba15a7e9f11dc31496a8bef9430b25155692 [^]

Related to issue 38445: Replaced Query.setString to setParameter.

Starting from Hibernate 5.2, setString(String, String) is marked as deprecated.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M src/org/openbravo/retail/posterminal/term/CashCloseReport.java
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0105031)
caristu   
2018-06-08 11:30   
Reviewed