Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038442Openbravo ERPA. Platformpublic2018-04-25 09:192018-05-09 19:29
Reportercaristu 
Assigned Tocaristu 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038442: Do not use positional query parameters with Query
DescriptionLegacy-style query parameters ('?') are no longer supported in Hibernate 5.3[1].

Therefore, queries generated with Query class using such kind of parameters are not working anymore starting from that Hibernate version. This issue affects to the methods using an int that determines the parameter position:

 - setParameter(int, Object)
 - setString(int, String)
 - setInteger(int, int)
 - setDate(int, Date)
 - etc

Named parameters should be used instead.

[1] https://hibernate.atlassian.net/browse/HHH-12101 [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038382 closed caristu Deprecate usage of positional query parameters in OBQuery 
related to feature request 0037064 closed caristu upgrade hibernate to 5.3.2 
related to defect 00384453.0PR18Q3 closed jarmendariz Do not use positional query parameters with Query (Retail) 
related to defect 00384463.0PR18Q3 closed jarmendariz Do not use positional query parameters with Query (Modules) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-25 09:19caristuNew Issue
2018-04-25 09:19caristuAssigned To => caristu
2018-04-25 09:19caristuModules => Core
2018-04-25 09:19caristuTriggers an Emergency Pack => No
2018-04-25 09:19caristuIssue generated from0038382
2018-04-25 09:20caristuRelationship addedrelated to 0038382
2018-04-25 10:10caristuDescription Updatedbug_revision_view_page.php?rev_id=17055#r17055
2018-04-25 10:10caristuDescription Updatedbug_revision_view_page.php?rev_id=17056#r17056
2018-04-25 10:11hgbotCheckin
2018-04-25 10:11hgbotNote Added: 0104068
2018-04-25 10:11hgbotStatusnew => resolved
2018-04-25 10:11hgbotResolutionopen => fixed
2018-04-25 10:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/582660de04fd0d217fed8bd4fdf5e6c9a69cbfe2 [^]
2018-04-25 10:11hgbotCheckin
2018-04-25 10:11hgbotNote Added: 0104069
2018-04-25 10:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/582660de04fd0d217fed8bd4fdf5e6c9a69cbfe2 [^] => http://code.openbravo.com/erp/devel/pi/rev/c5d8fbd7e953259aa3bab391b2931d6a9436939e [^]
2018-04-25 10:15hgbotCheckin
2018-04-25 10:15hgbotNote Added: 0104070
2018-04-25 10:16caristuDescription Updatedbug_revision_view_page.php?rev_id=17057#r17057
2018-04-25 10:22caristuReview Assigned To => alostale
2018-04-25 13:21caristuIssue cloned0038445
2018-04-25 13:21caristuRelationship addedrelated to 0038445
2018-04-25 13:22caristuIssue cloned0038446
2018-04-25 13:22caristuRelationship addedrelated to 0038446
2018-04-27 13:24alostaleRelationship addedrelated to 0037064
2018-04-27 13:25alostaleNote Added: 0104160
2018-04-27 13:25alostaleStatusresolved => closed
2018-04-27 13:25alostaleFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104393
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104394
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104395

Notes
(0104068)
hgbot   
2018-04-25 10:11   
Repository: erp/devel/pi
Changeset: 582660de04fd0d217fed8bd4fdf5e6c9a69cbfe2
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 25 09:49:14 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/582660de04fd0d217fed8bd4fdf5e6c9a69cbfe2 [^]

fixes issue 38442: replace setParameter(int, Object) with setParameter(String, Object)

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
M src-test/src/org/openbravo/test/dal/DalComplexQueryTestOrderLine.java
M src/org/openbravo/base/structure/BaseOBObject.java
M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java
---
(0104069)
hgbot   
2018-04-25 10:11   
Repository: erp/devel/pi
Changeset: c5d8fbd7e953259aa3bab391b2931d6a9436939e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 25 10:06:27 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c5d8fbd7e953259aa3bab391b2931d6a9436939e [^]

fixes issue 38442: replace setString(int, String) with setParameter(String, Object)

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
M modules/org.openbravo.client.myob/src/org/openbravo/client/myob/WidgetProvider.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceProperty.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M src-test/src/org/openbravo/test/dal/IssuesTest.java
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
M src/org/openbravo/materialmgmt/InventoryCountProcess.java
---
(0104070)
hgbot   
2018-04-25 10:15   
Repository: erp/devel/pi
Changeset: b83da0b5cd1b8030eb1b3b5ab2176f7c299551a4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Apr 25 10:15:44 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b83da0b5cd1b8030eb1b3b5ab2176f7c299551a4 [^]

related to issue 38442: fix typo

---
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
---
(0104160)
alostale   
2018-04-27 13:25   
reviewed
(0104393)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test
(0104394)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test
(0104395)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test