Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038441Retail ModulesWeb POSpublic2018-04-25 09:032018-05-18 15:04
ReporterAugustoMauch 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038441: The creationDate of the invoices is not set properly in the OrderLoader
DescriptionThere are two problems with how the creationDate of the invoices is set in the OrderLoader [1]:
- The timezone conversion is done the other way around. Instead of converting the given UTC date to the server timezone, it is converted to the client timezone. This is evident when the server is in another timezone. For instance, when an order with its invoice is created using the POS of this server [2], the creation date of the invoice will be set two hours into the future.
- If the clock of the server differs with the clock of the client, it is possible that the creationDate of the invoice will be a previous date than the updated date, which don't make sense


[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/src/org/openbravo/retail/posterminal/OrderLoader.java#l1135 [^]
[2] http://ec2-35-170-240-78.compute-1.amazonaws.com/openbravo/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login [^]
Steps To Reproduce- Using the POS, create an order and its invoice in this server [1] from a computer in the CEST timezone.
- Go to the backend and check the audit fields of the invoice. Check that the creation date is wrong

[1] http://ec2-35-170-240-78.compute-1.amazonaws.com/openbravo/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue38441.diff (957) 2018-04-25 09:11
https://issues.openbravo.com/file_download.php?file_id=11766&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-04-25 09:03AugustoMauchNew Issue
2018-04-25 09:03AugustoMauchAssigned To => Retail
2018-04-25 09:03AugustoMauchOBNetwork customer => No
2018-04-25 09:03AugustoMauchTriggers an Emergency Pack => No
2018-04-25 09:11AugustoMauchFile Added: issue38441.diff
2018-04-25 09:33marvintmOBNetwork customerNo => Yes
2018-04-25 09:33marvintmResolution time => 1526767200
2018-05-11 14:48marvintmSeverityminor => major
2018-05-16 14:45ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-05-16 14:45ranjith_qualiantech_comStatusnew => scheduled
2018-05-18 06:50hgbotCheckin
2018-05-18 06:50hgbotNote Added: 0104583
2018-05-18 06:50hgbotStatusscheduled => resolved
2018-05-18 06:50hgbotResolutionopen => fixed
2018-05-18 06:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/92cd7acd2ae68c38385204b6129932386dc0afac [^]
2018-05-18 15:04marvintmReview Assigned To => marvintm
2018-05-18 15:04marvintmStatusresolved => closed
2018-05-18 15:04marvintmFixed in Version => RR18Q3

Notes
(0104583)
hgbot   
2018-05-18 06:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 92cd7acd2ae68c38385204b6129932386dc0afac
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu May 17 18:49:11 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/92cd7acd2ae68c38385204b6129932386dc0afac [^]

Fixed issue 38441 : Invoice Creation date should be updated based on Server Time and Timezone

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---