Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038401Openbravo ERPB. User interfacepublic2018-04-18 11:442018-05-09 19:29
Reporterkchoperena 
Assigned Tocaristu 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038401: [SERQA 3982]: Grid Configuration filtering does not work correctly for foreign key filters
DescriptionWhen we use a filter to filtering foreign key values, if we use the mouse to launch the search, when we click on V the value of the filter will be lost. Also, if after select the value we click out of the box will be lost.
Steps To Reproduce1.- Log into the backend
2.- Config any window grid using the configuration of the attached image.
3.- Go to the configured window and select a value from the list and click on search [Also happens clicking out of the search box]

Video: https://drive.google.com/file/d/1ItbxGvHkn_bgRCNVPop5hjQy8OuDvTOR [^]

Expected: The value of the filter will be lost.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng GridConfiguration.png (86,148) 2018-04-23 19:00
https://issues.openbravo.com/file_download.php?file_id=11759&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-04-18 11:44kchoperenaNew Issue
2018-04-18 11:44kchoperenaAssigned To => platform
2018-04-18 11:44kchoperenaModules => Core
2018-04-18 11:44kchoperenaResolution time => 1525212000
2018-04-18 11:44kchoperenaTriggers an Emergency Pack => No
2018-04-23 18:21caristuNote Added: 0104040
2018-04-23 18:21caristuAssigned Toplatform => kchoperena
2018-04-23 18:21caristuStatusnew => feedback
2018-04-23 18:58kchoperenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=17047#r17047
2018-04-23 19:00kchoperenaFile Added: GridConfiguration.png
2018-04-23 19:01kchoperenaNote Added: 0104041
2018-04-23 19:05caristuAssigned Tokchoperena => caristu
2018-04-24 19:25hgbotCheckin
2018-04-24 19:25hgbotNote Added: 0104064
2018-04-24 19:25hgbotStatusfeedback => resolved
2018-04-24 19:25hgbotResolutionopen => fixed
2018-04-24 19:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f7a294ef4724c956020cb5c2b4be3d816cfadc6a [^]
2018-04-24 19:25caristuReview Assigned To => AugustoMauch
2018-04-24 19:26caristuNote Edited: 0104064bug_revision_view_page.php?bugnote_id=0104064#r17051
2018-04-26 16:58AugustoMauchNote Added: 0104110
2018-04-26 16:58AugustoMauchStatusresolved => closed
2018-04-26 16:58AugustoMauchFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104392

Notes
(0104040)
caristu   
2018-04-23 18:21   
For the moment, we are not reproducing this issue.

Can you please provide how you define your grid configuration in detail? According to the steps to reproduce it seems that we should configure the "Lazy Filtering". Is any other configuration required?
(0104041)
kchoperena   
2018-04-23 19:01   
Added a screenshot of the configuration and a video with the steps to reproduce it
(0104064)
hgbot   
2018-04-24 19:25   
(edited on: 2018-04-24 19:26)
Repository: erp/devel/pi
Changeset: f7a294ef4724c956020cb5c2b4be3d816cfadc6a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Apr 24 18:47:33 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f7a294ef4724c956020cb5c2b4be3d816cfadc6a [^]

fixes issue 38401: Wrong filter behavior depending on the grid configuration

  Having a grid configuration which both enables lazy filtering and does not allow filtering foreign keys by its identifier, it was not possible to apply a filter in a foreign key combo using the mouse.

  This was happening because when it is allowed to filter foreign keys by its identifier, there is some code that restores the filter editor with the previous criteria in case the entered criteria is not valid when the editor loses the focus (on blur).

  This logic was causing the lose of the filter criteria because it was restoring it with an empty criteria (the grid was not containing any criteria applied because of the lazy filtering). Therefore, to fix this issue we are not restoring the criteria if the lazy filtering is enabled in the grid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk-filter.js
---
(0104110)
AugustoMauch   
2018-04-26 16:58   
Code reviewed and verified
(0104392)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test