Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038386Openbravo ERP04. Warehouse managementpublic2018-04-17 11:162018-05-15 20:43
ReporterVictorVillar 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038386: Same search key can be used twice in warehouse definition
DescriptionSame search key can be used twice in warehouse definition and it should not.
Steps To ReproduceGo to Warehouse Definition window
  Create two new warehouses with the same Search Keys.

Same search key can be used twice in warehouse definition and it should not.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0038504 closed AtulOpenbravo API Change request 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-17 11:16VictorVillarNew Issue
2018-04-17 11:16VictorVillarAssigned To => dmiguelez
2018-04-17 11:16VictorVillarResolution time => 1525730400
2018-04-17 12:28ngarciaIssue Monitored: ngarcia
2018-04-18 16:45dmiguelezAssigned Todmiguelez => Triage Finance
2018-04-19 13:18dmiguelezProjectModules => Openbravo ERP
2018-04-19 13:21dmiguelezModules => Core
2018-04-19 13:21dmiguelezTriggers an Emergency Pack => No
2018-04-19 13:21dmiguelezCategoryAdvance Warehouse Operations => 04. Warehouse management
2018-04-20 11:20dmiguelezAssigned ToTriage Finance => collazoandy4
2018-04-25 10:08dmiguelezAssigned Tocollazoandy4 => AtulOpenbravo
2018-04-30 23:27collazoandy4Assigned ToAtulOpenbravo => collazoandy4
2018-04-30 23:27collazoandy4Statusnew => scheduled
2018-05-02 17:33collazoandy4Note Added: 0104210
2018-05-08 17:31collazoandy4Relationship addedblocks 0038504
2018-05-08 17:52aferrazRelationship replaceddepends on 0038504
2018-05-11 11:08aferrazAssigned Tocollazoandy4 => AtulOpenbravo
2018-05-11 11:15aferrazNote Added: 0104467
2018-05-11 11:15aferrazStatusscheduled => feedback
2018-05-11 11:15aferrazStatusfeedback => new
2018-05-13 14:31dmiguelezResolution time1525730400 => 1528408800
2018-05-13 14:32dmiguelezResolution time1528408800 => 1525730400
2018-05-14 10:16AtulOpenbravoStatusnew => scheduled
2018-05-15 12:17AtulOpenbravoNote Added: 0104518
2018-05-15 16:24hgbotCheckin
2018-05-15 16:24hgbotNote Added: 0104521
2018-05-15 16:24hgbotCheckin
2018-05-15 16:24hgbotNote Added: 0104523
2018-05-15 16:24hgbotStatusscheduled => resolved
2018-05-15 16:24hgbotResolutionopen => fixed
2018-05-15 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4bf53115b63752e1c7a0053811aae3a9e12e0965 [^]
2018-05-15 16:24hgbotCheckin
2018-05-15 16:24hgbotNote Added: 0104524
2018-05-15 16:34aferrazReview Assigned To => aferraz
2018-05-15 16:34aferrazNote Added: 0104526
2018-05-15 16:34aferrazStatusresolved => closed
2018-05-15 16:34aferrazFixed in Version => 3.0PR18Q3
2018-05-15 20:43hudsonbotCheckin
2018-05-15 20:43hudsonbotNote Added: 0104535
2018-05-15 20:43hudsonbotCheckin
2018-05-15 20:43hudsonbotNote Added: 0104536

Notes
(0104210)
collazoandy4   
2018-05-02 17:33   
Go to Warehouse Definition window
  Create two new warehouses with the same Search Keys and check when you try to save the second an error message is shown indicating an unique constraints
(0104467)
aferraz   
2018-05-11 11:15   
We need to include a build validation to check if exists data violating the new contraint.
(0104518)
AtulOpenbravo   
2018-05-15 12:17   
Test plan to test build validation

- In a latest pi instance with Core Module version 3.0.33954, apply the patch.
- In database or from GUI, navigate to warehouse record with name "España Región Sur" and search key (value) as RN.
- Run update.database or smartbuild -Dlocal=no -Dforce=true task.
- Realize that in the console following error is shown

Due to a database constraint modification, is no longer allowed to have the same Warehouse search key more than once within client. There exists data in your database that do not fit this new constraint. Please review following:-

Client: F&B International Group, Search Key: RN, Warehouse: España Región Norte
Client: F&B International Group, Search Key: RN, Warehouse: España Región Sur

- In database or GUI, navigate to warehouse record with name "España Región Sur" and set search key (value) back to RS.
- Run update.database or smartbuild -Dlocal=no -Dforce=true task.
- Realize that compilation is executed further without any error.

Above test plan executed successfully in oracle instance.
(0104521)
hgbot   
2018-05-15 16:24   
Repository: erp/devel/api-checks
Changeset: 572d07a104069869dd0a0ae27b00cb9b278dd3cd
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 15 16:07:23 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/572d07a104069869dd0a0ae27b00cb9b278dd3cd [^]

Fixes issue 38504: API change for issue 38386

---
M model/src-db/database/model/tables/M_WAREHOUSE.xml
---
(0104523)
hgbot   
2018-05-15 16:24   
Repository: erp/devel/pi
Changeset: 4bf53115b63752e1c7a0053811aae3a9e12e0965
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue May 01 18:01:20 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/4bf53115b63752e1c7a0053811aae3a9e12e0965 [^]

Fixes issue 38386: Same search key can be used twice in warehouse definition

The same Search Key in warehouse and storage bin can be used twice because a missing
constraint

An unique constraints was added to warehouse definition.

---
M src-db/database/model/tables/M_WAREHOUSE.xml
---
(0104524)
hgbot   
2018-05-15 16:24   
Repository: erp/devel/pi
Changeset: 78f6e305eb5e34f21d1c36d1f0f4fb1f40eba378
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 15 15:33:25 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/78f6e305eb5e34f21d1c36d1f0f4fb1f40eba378 [^]

Related to issue 38386: Same search key can be used twice in
warehouse definition

A build validation to check whether there exists a warehouse
with same value within client to avoid failure of build
when adding a unique constraint for client and value in
m_warehouse table.

---
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedClientWarehouseValue.class
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/DuplicatedClientWarehouseValueData.class
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedClientWarehouseValue.java
A src-util/buildvalidation/src/org/openbravo/buildvalidation/DuplicatedClientWarehouseValue_data.xsql
---
(0104526)
aferraz   
2018-05-15 16:34   
Code review + Testing OK
(0104535)
hudsonbot   
2018-05-15 20:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/79b08258a2aa [^]
Maturity status: Test
(0104536)
hudsonbot   
2018-05-15 20:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/79b08258a2aa [^]
Maturity status: Test