Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0038383 | Openbravo ERP | A. Platform | public | 2018-04-16 18:31 | 2018-04-20 09:42 |
|
| Reporter | caristu | |
| Assigned To | caristu | |
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0038383: API Change: declare OBQuery.getParameters() method as private |
| Description | With issue 0038382 OBQuery.setParameters(List) is deprecated in order to discourage the usage of positional legacy-style query parameters ('?').
For this reason it would be appropriate to declare the related getter, getParameters(), as private as it is only used internally. |
| Steps To Reproduce | . |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0038382 | | closed | caristu | Deprecate usage of positional query parameters in OBQuery |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-04-16 18:31 | caristu | New Issue | |
| 2018-04-16 18:31 | caristu | Assigned To | => platform |
| 2018-04-16 18:31 | caristu | OBNetwork customer | => No |
| 2018-04-16 18:31 | caristu | Modules | => Core |
| 2018-04-16 18:31 | caristu | Triggers an Emergency Pack | => No |
| 2018-04-16 18:32 | caristu | Description Updated | bug_revision_view_page.php?rev_id=17003#r17003 |
| 2018-04-16 18:32 | caristu | Relationship added | related to 0038382 |
| 2018-04-16 18:32 | caristu | Description Updated | bug_revision_view_page.php?rev_id=17004#r17004 |
| 2018-04-17 08:30 | caristu | Summary | API Change: deprecate OBquery.setParameters(List) method => API Change: declare OBQuery.getParameters() method as private |
| 2018-04-17 08:30 | caristu | Description Updated | bug_revision_view_page.php?rev_id=17010#r17010 |
| 2018-04-17 09:23 | caristu | Description Updated | bug_revision_view_page.php?rev_id=17011#r17011 |
| 2018-04-18 09:41 | hgbot | Checkin | |
| 2018-04-18 09:41 | hgbot | Note Added: 0103956 | |
| 2018-04-18 09:41 | hgbot | Status | new => resolved |
| 2018-04-18 09:41 | hgbot | Resolution | open => fixed |
| 2018-04-18 09:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/api-checks/rev/a0d08941dba26670f63ec41a85257229ef75fbf3 [^] |
| 2018-04-18 09:47 | caristu | Review Assigned To | => alostale |
| 2018-04-18 10:59 | caristu | Assigned To | platform => caristu |
| 2018-04-20 09:42 | alostale | Status | resolved => closed |