Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038372Retail ModulesDiscounts by Payment Methodpublic2018-04-16 10:112019-02-06 15:35
Reportermalsasua 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket1356
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038372: In Discount By Payment Method, "Validate Date To" property is not working
DescriptionIn Discount By Payment Method, The property "Validate Date To" is not working, and the discounts with a previous "valid to" date are applied in the POS
Steps To ReproduceBO:
. create a new Discount by Payment Method
. date from: 01/04/2018
. date to: 15/04/2018 (previous date)
. Payment Method: Cash

POS:
. do login
. new receipt, pay using Cash
Error: discount is applied
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038384 closed jorge-garcia OB.Dal.queryUsingCache is not working if pass params parameter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-16 10:11malsasuaNew Issue
2018-04-16 10:11malsasuaAssigned To => Retail
2018-04-16 10:11malsasuaOBNetwork customer => Yes
2018-04-16 10:11malsasuaSupport ticket => 1356
2018-04-16 10:11malsasuaResolution time => 1525644000
2018-04-16 10:11malsasuaTriggers an Emergency Pack => No
2018-04-16 10:32jfrancesIssue Monitored: jfrances
2018-04-16 15:00achavesIssue Monitored: achaves
2018-04-16 16:47jorge-garciaStatusnew => scheduled
2018-04-16 16:47jorge-garciaAssigned ToRetail => jorge-garcia
2018-04-17 11:15jorge-garciaRelationship addedrelated to 0038384
2018-04-17 11:19hgbotCheckin
2018-04-17 11:19hgbotNote Added: 0103929
2018-04-17 11:19hgbotStatusscheduled => resolved
2018-04-17 11:19hgbotResolutionopen => fixed
2018-04-17 11:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/7c340bb09b7e81892e5a1e810a2869fb2fc5661d [^]
2018-05-04 14:41marvintmReview Assigned To => marvintm
2018-05-04 14:41marvintmStatusresolved => closed
2018-05-04 14:41marvintmFixed in Version => RR18Q3
2018-07-06 15:17hgbotCheckin
2018-07-06 15:17hgbotNote Added: 0105666
2019-02-06 15:35hgbotCheckin
2019-02-06 15:35hgbotNote Added: 0109646

Notes
(0103929)
hgbot   
2018-04-17 11:19   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: 7c340bb09b7e81892e5a1e810a2869fb2fc5661d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Apr 17 10:55:40 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/7c340bb09b7e81892e5a1e810a2869fb2fc5661d [^]

Fixed issue 38372: In Discount By Payment Method, "Validate Date To"
property is not working

Discounts by payment method implementation doesn’t use the standard discounts
query to retrieve the promotion candidates.

The solution is to use DateTo and DateFrom filters in payment method query.

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0105666)
hgbot   
2018-07-06 15:17   
Repository: tools/automation/pi-mobile
Changeset: e6da928c6e3fcccf64c010e3d7c5a76cdec299ab
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jul 02 16:34:53 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e6da928c6e3fcccf64c010e3d7c5a76cdec299ab [^]

Related to issue 38372: added automated test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I38372_VerifyValidateDateToProperty.java
---
(0109646)
hgbot   
2019-02-06 15:35   
Repository: tools/automation/pi-mobile
Changeset: 6c9985d170b9613b56a0960b0bf0320a932ec903
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Jan 31 11:55:18 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c9985d170b9613b56a0960b0bf0320a932ec903 [^]

Related to issue 38372: test has been refactored due to it no longer creates its
own sampledata

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I38372_VerifyValidateDateToProperty.java
---