Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038370Openbravo ERPA. Platformpublic2018-04-14 15:162018-04-20 09:57
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038370: Stop auto-adding new html mapping for every new callout (in ad_callout_trg)
DescriptionURL mapping for callout are no longer required/used and all old ones have been removed in pi in issue: 34213

However the ad_callout_trg trigger is still inserting new html mappings for every callout re-adding new mappings which is not useful.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 00323663.0PR16Q4 closed inigosanchez callout invocation ineficiencies 
related to defect 0034213 closed shuehner clean up AD_Model_Object and AD_Model_Object_Mapping 
Attached Files? 38370.hgexport (1,845) 2018-04-14 15:26
https://issues.openbravo.com/file_download.php?file_id=11733&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-04-14 15:16shuehnerNew Issue
2018-04-14 15:16shuehnerAssigned To => shuehner
2018-04-14 15:16shuehnerModules => Core
2018-04-14 15:16shuehnerTriggers an Emergency Pack => No
2018-04-14 15:16shuehnerRelationship addedrelated to 0034213
2018-04-14 15:24shuehnerSummaryRemove trigger to generate ad_model_object_mapping for every new callout. => Stop auto-adding new html mapping for every new callout (in ad_callout_trg)
2018-04-14 15:26shuehnerFile Added: 38370.hgexport
2018-04-14 15:30shuehnerNote Added: 0103890
2018-04-19 09:41alostaleRelationship addedrelated to 0032366
2018-04-20 09:57hgbotCheckin
2018-04-20 09:57hgbotNote Added: 0104006
2018-04-20 09:57hgbotStatusnew => resolved
2018-04-20 09:57hgbotResolutionopen => fixed
2018-04-20 09:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dd78fd2113508b43f62e9f9cf2f6be528b4c5f92 [^]
2018-04-20 09:57alostaleReview Assigned To => alostale
2018-04-20 09:57alostaleNote Added: 0104007
2018-04-20 09:57alostaleStatusresolved => closed
2018-04-20 09:57alostaleFixed in Version => 3.0PR18Q3

Notes
(0103890)
shuehner   
2018-04-14 15:30   
Doing this change has following side-effects:
a.) Using >=18Q3 release to develop new old-style servlet non SimpleCallouts will require to manually insert html mapping
b.) Using >=18Q3 to edit old-style servlet ad_callout entries will delete + not re-create the mapping so make the callout unusable unless the mapping is manually re-addded (As the code to delete mappings on 'edit' stays).

Given timing with this published in 18Q3 only:
- No new callouts should be created not being SimpleCallout based
- Developing new code compatible with <17Q1 using 18Q3 is highly unlikely.
- Editing ad_callout entry for old-style callout with 18Q3 and wanting to to keep 17Q3 compat is also quite unlikely.

So those side-effect should be acceptable.
(0104006)
hgbot   
2018-04-20 09:57   
Repository: erp/devel/pi
Changeset: dd78fd2113508b43f62e9f9cf2f6be528b4c5f92
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Apr 14 15:25:14 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/dd78fd2113508b43f62e9f9cf2f6be528b4c5f92 [^]

Fixed 38370. Don't add new html mapping for new callouts.

Remove code to auto-insert into ad_model_object_mapping in ad_callout_trg.
As those mappings are no longer useful since 17Q1.

---
M src-db/database/model/triggers/AD_CALLOUT_TRG.xml
---
(0104007)
alostale   
2018-04-20 09:57   
reviewed