Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038357Openbravo ERPA. Platformpublic2018-04-12 16:492018-05-09 19:29
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038357: Unused connection pool created on module installation
DescriptionA unused connection pool[1] is being created on module installation (one per installed module).

This can lead to problems with connection availability if the number of modules to be installed is big.

We have been able to reproduce it with CI[2], as there are some jobs like try-initial-pgsql which tries to install several modules, running the jobs with the following parameters: TRY_PARAMS###TC8=yes###JAVA_HOME=/usr/local/jvm/java-9.0.4-openjdk-amd64###DESC=try_java9


[1] https://code.openbravo.com/erp/devel/pi/file/60a2a309d225/src/org/openbravo/erpCommon/modules/ImportModule.java#l1284 [^]
[2] https://ci.openbravo.com//job/try-initial-pgsql/6736/artifact/SANDBOX/tomcat-logs/ci04.148_tc8.log/*view*/ [^]
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038344 closed caristu Restart tomcat 8.0 not working after installing a module through MMC using JDK9 
depends on backport 00383583.0PR18Q2 closed caristu Unused connection pool created on module installation 
related to feature request 0037083 closed alostale support JDK 9 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-12 16:49caristuNew Issue
2018-04-12 16:49caristuAssigned To => platform
2018-04-12 16:49caristuModules => Core
2018-04-12 16:49caristuTriggers an Emergency Pack => No
2018-04-12 16:49caristuRelationship addedrelated to 0038344
2018-04-12 16:49caristuStatusnew => scheduled
2018-04-12 16:49caristuAssigned Toplatform => caristu
2018-04-12 16:55caristuDescription Updatedbug_revision_view_page.php?rev_id=16973#r16973
2018-04-12 16:55caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16975#r16975
2018-04-12 16:58caristuDescription Updatedbug_revision_view_page.php?rev_id=16979#r16979
2018-04-12 17:05hgbotCheckin
2018-04-12 17:05hgbotNote Added: 0103852
2018-04-12 17:05hgbotStatusscheduled => resolved
2018-04-12 17:05hgbotResolutionopen => fixed
2018-04-12 17:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1828446d8690e1c1eceee90d00d0feb668faae83 [^]
2018-04-12 17:13caristuReview Assigned To => alostale
2018-04-13 08:14alostaleNote Added: 0103863
2018-04-13 08:14alostaleStatusresolved => closed
2018-04-13 08:14alostaleFixed in Version => 3.0PR18Q3
2018-04-13 08:23alostaleRelationship addedrelated to 0037083
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104377

Notes
(0103852)
hgbot   
2018-04-12 17:05   
Repository: erp/devel/pi
Changeset: 1828446d8690e1c1eceee90d00d0feb668faae83
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Apr 12 17:04:43 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1828446d8690e1c1eceee90d00d0feb668faae83 [^]

fixes issue 38357: Unused connection pool created on module installation

---
M src/org/openbravo/erpCommon/modules/ImportModule.java
---
(0103863)
alostale   
2018-04-13 08:14   
reviewed
(0104377)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test