Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038353Retail ModulesWeb POSpublic2018-04-12 15:362018-05-21 09:28
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038353: Add Human Actions to javascript errors and Avoid double click on buttons
DescriptionWe can register clicks and key down by the user. It would be interesting if we put inside the js error the actions done by the user to help to understand the error.

Try to avoid double click on buttons with a general solution and a way to avoid this restriction.
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-12 15:36migueldejuanaNew Issue
2018-04-12 15:36migueldejuanaAssigned To => migueldejuana
2018-04-12 15:36migueldejuanaTriggers an Emergency Pack => No
2018-04-12 15:59migueldejuanaFile Added: mobileCore.diff
2018-04-20 09:20hgbotCheckin
2018-04-20 09:20hgbotNote Added: 0104000
2018-04-20 09:20hgbotStatusnew => resolved
2018-04-20 09:20hgbotResolutionopen => fixed
2018-04-20 09:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/95a5ae43be3dbbdc861682332145103bfe018bb7 [^]
2018-04-20 09:20hgbotCheckin
2018-04-20 09:20hgbotNote Added: 0104001
2018-04-20 09:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/95a5ae43be3dbbdc861682332145103bfe018bb7 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/89d8598471d17a1c37892051bb859cad689c7c41 [^]
2018-04-20 09:20hgbotCheckin
2018-04-20 09:20hgbotNote Added: 0104002
2018-04-20 09:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/89d8598471d17a1c37892051bb859cad689c7c41 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f6773fc7ac6fccfe090e6eb3f3d79ec028d571b [^]
2018-04-20 09:20hgbotCheckin
2018-04-20 09:20hgbotNote Added: 0104003
2018-04-20 09:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f6773fc7ac6fccfe090e6eb3f3d79ec028d571b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5657aec4a432929b0cb486f2358e4c46cb9dbfec [^]
2018-04-20 09:23migueldejuanaFile Deleted: mobileCore.diff
2018-04-20 09:26migueldejuanaSummaryAdd Human Actions to javascript errors => Add Human Actions to javascript errors and Avoid double click on buttons
2018-04-20 09:26migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=17037#r17037
2018-05-21 09:28marvintmReview Assigned To => marvintm
2018-05-21 09:28marvintmStatusresolved => closed
2018-05-21 09:28marvintmFixed in Version => RR18Q3

Notes
(0104000)
hgbot   
2018-04-20 09:20   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 95a5ae43be3dbbdc861682332145103bfe018bb7
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Apr 17 14:33:41 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/95a5ae43be3dbbdc861682332145103bfe018bb7 [^]

Fixed issue 0038353: Add Human Actions to javascript errors

. Extend DOM nodes for BUTTON type components

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
A web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js
---
(0104001)
hgbot   
2018-04-20 09:20   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 89d8598471d17a1c37892051bb859cad689c7c41
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Apr 17 14:54:42 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/89d8598471d17a1c37892051bb859cad689c7c41 [^]

Fixed issue 0038353: Add Human Actions to javascript errors

- Using DOM extension, avoid double click (in less than 200 milliseconds) for all mobile application buttons using debounce
- If we get a javascript error, log the last 50 human actions and attach this info to the error in the console and in the client Log.

---
M src/org/openbravo/mobile/core/MobileCoreComponentProvider.java
M web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
A web/org.openbravo.mobile.core/source/utils/ob-loghumanaction.js
---
(0104002)
hgbot   
2018-04-20 09:20   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7f6773fc7ac6fccfe090e6eb3f3d79ec028d571b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Apr 18 14:39:25 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f6773fc7ac6fccfe090e6eb3f3d79ec028d571b [^]

Fixed issue 0038353: Add Human Actions to javascript errors

- Add the ability to do not avoid double clicks. There are some buttons that want be clicked several times in short time. Adding products for example.

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
M web/org.openbravo.mobile.core/source/utils/ob-dom-extension.js
---
(0104003)
hgbot   
2018-04-20 09:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5657aec4a432929b0cb486f2358e4c46cb9dbfec
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Apr 18 14:40:28 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5657aec4a432929b0cb486f2358e4c46cb9dbfec [^]

Fixed issue 0038353: Add Human Actions to javascript errors

- Add the ability to do not avoid double clicks. There are some buttons that want be clicked several times in short time. Adding products for example.

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabcashpayments.js
M web/org.openbravo.retail.posterminal/js/components/keypadcoins.js
M web/org.openbravo.retail.posterminal/js/components/renderproduct.js
M web/org.openbravo.retail.posterminal/js/components/renderproductch.js
---