Openbravo Issue Tracking System - Retail Modules
View Issue Details
0038333Retail ModulesWeb POSpublic2018-04-11 15:432018-05-11 12:45
rafaroda 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
RR18Q3 
marvintm
No
0038333: Wrong Payment Details created in backend when paying Layaway with Cash first then overpaying with Digital Coupon
Wrong Payment Details created in backend when paying Layaway with Cash first then overpaying with Digital Coupon
Reproduce in LIVE BUILDS https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11 [^]

1) Open terminal YS-11 which has digital coupons enabled (overpayment allowed)
2) Click on Layaway this Receipt
3) Add Avalanche transceiver product: Total Amount = 150,50€
4) Click on Total Amount
5) Select payment method: Cash and add 100€ payment
6) Click on Layaway button
7) Reopen the Layaway
8) Click on total Amount: 50,50€ remain to pay
9) Select Digital Coupon payment method
10) Add a digital coupon of 60€
There is a red error message saying, should this message be displayed? See screenshot: Only cash payment methods are allowed to return change.
11) We select cash as Payment Method: 9,50€ are displayed to be returned, wrong?
See screenshot: Only cash payment methods are allowed to return change

12) Click on Done
13) Go to backend and search for the Sales Order:
* Payment Plan: Expected Amount: 150,50 OK, Received: 160 OK, Outstanding: -9,50 NOK
* Payment Details:
** Cash: Expected Amount: 150,50 OK, Received Amount: 100 OK
** Wire transfer: Expected Amount: 150,50 OK, Received Amount: 60 OK
See screenshot: Sales order Backend Payments-1

14) Reopen the layaway ticket: still 9,50€ remain to pay: you can keep adding cash bys electing Cash payment method and the OK V icon plus Done
15) Reopen the ticket again: now 10,50€ remain to pay, you can go back to step 14 again and again
16) In backend, in the sales order:
* Payment Plan: Expected Amount: 150,50 OK, Received: 161 NOK, Outstanding: -10,50 NOK
* Payment Details:
** Cash: Expected Amount: 150,50 OK, Received Amount: 100 OK
** Wire transfer: Expected Amount: 150,50 OK, Received Amount: 60 OK
** Cash: Expected Amount: 150,50 OK, Received Amount: 1 NOK
See screenshot: Sales order Backend Payments-2
SER-QA
related to defect 0038038 closed ranjith_qualiantech_com Wrong payment documents registered in backoffice when giving change in another currency from WebPOS 
related to defect 0038750 closed ranjith_qualiantech_com It is possible to generate overpayments in cash payment methods 
png Only cash payment methods are allowed to return change.png (98,620) 2018-04-11 15:43
https://issues.openbravo.com/file_download.php?file_id=11722&type=bug
png

png Sales order Backend Payments - 1.png (82,840) 2018-04-11 15:43
https://issues.openbravo.com/file_download.php?file_id=11723&type=bug
png

png Sales order Backend Payments - 2.png (90,840) 2018-04-11 15:44
https://issues.openbravo.com/file_download.php?file_id=11724&type=bug
png
Issue History
2018-04-11 15:43rafarodaNew Issue
2018-04-11 15:43rafarodaAssigned To => Retail
2018-04-11 15:43rafarodaFile Added: Only cash payment methods are allowed to return change.png
2018-04-11 15:43rafarodaTriggers an Emergency Pack => No
2018-04-11 15:43rafarodaFile Added: Sales order Backend Payments - 1.png
2018-04-11 15:44rafarodaFile Added: Sales order Backend Payments - 2.png
2018-04-12 10:48avicenteResolution time => 1525039200
2018-04-12 10:48avicenteTag Attached: SER-QA
2018-04-12 15:13ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-04-12 15:14ranjith_qualiantech_comStatusnew => scheduled
2018-04-24 08:55ranjith_qualiantech_comRelationship addedrelated to 0038038
2018-05-04 08:39hgbotCheckin
2018-05-04 08:39hgbotNote Added: 0104267
2018-05-04 08:39hgbotStatusscheduled => resolved
2018-05-04 08:39hgbotResolutionopen => fixed
2018-05-04 08:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4dc25baceae5f616c7d85492bacab988519435f0 [^]
2018-05-04 08:40hgbotCheckin
2018-05-04 08:40hgbotNote Added: 0104268
2018-05-04 14:39marvintmNote Added: 0104284
2018-05-04 14:39marvintmStatusresolved => new
2018-05-04 14:39marvintmResolutionfixed => open
2018-05-07 09:37ranjith_qualiantech_comStatusnew => scheduled
2018-05-08 14:17hgbotCheckin
2018-05-08 14:17hgbotNote Added: 0104325
2018-05-08 14:17hgbotStatusscheduled => resolved
2018-05-08 14:17hgbotResolutionopen => fixed
2018-05-08 14:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4dc25baceae5f616c7d85492bacab988519435f0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8c76bcb53704107730534ae07f77fc049a9a1f42 [^]
2018-05-08 14:17hgbotCheckin
2018-05-08 14:17hgbotNote Added: 0104326
2018-05-11 12:45marvintmReview Assigned To => marvintm
2018-05-11 12:45marvintmStatusresolved => closed
2018-05-11 12:45marvintmFixed in Version => RR18Q3
2018-06-13 15:16ranjith_qualiantech_comRelationship addedrelated to 0038750

Notes
(0104267)
hgbot   
2018-05-04 08:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4dc25baceae5f616c7d85492bacab988519435f0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 04 12:09:34 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4dc25baceae5f616c7d85492bacab988519435f0 [^]

Fixed issue 38333 : Change should not be calculated based on Prepayments

* For Partial Paid Layaway, Cash change should not given from Cash Prepayments if Card is overpaid. It should be Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0104268)
hgbot   
2018-05-04 08:40   
Repository: tools/automation/pi-mobile
Changeset: af64455e7880148cb779cf437218a6ee64cc180a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri May 04 12:09:51 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/af64455e7880148cb779cf437218a6ee64cc180a [^]

Verifies issue 38333 : Added automated test 'I38333_VerfiyCashChangeOnLayaway

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/storecurrencyexchangerate/VerifyPaymentBasedOnStoreConversionRate.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38333_VerfiyCashChangeOnLayaway.java
---
(0104284)
marvintm   
2018-05-04 14:39   
Solution doesn't seem to be correct. I can reproduce a problem doing the following steps:
- Create a layaway for total 150
- Add a payment in cash for 50
- Sync with backend.
- Open layaway again.
- Add payment in card for 200
Expected result should be: payment 50 in cash+100 in card, then overpayment of 100 in card. However, the WebPOS tries to generate change for the cash payment method, and won't allow to complete ticket.
(0104325)
hgbot   
2018-05-08 14:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8c76bcb53704107730534ae07f77fc049a9a1f42
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 08 17:47:13 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8c76bcb53704107730534ae07f77fc049a9a1f42 [^]

Fixed issue 38333 : Change should not be calculated based on Prepayments

* For Partial Paid Layaway, Cash change should not given from Cash Prepayments if Card is overpaid. Card should be Overpayment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0104326)
hgbot   
2018-05-08 14:17   
Repository: tools/automation/pi-mobile
Changeset: a0296ab3e05fa6a7d9c0e38708c9942ad8d9da32
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 08 17:47:28 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a0296ab3e05fa6a7d9c0e38708c9942ad8d9da32 [^]

Verifies issue 38333 : Added automated test 'I38333_VerfiyCashChangeOnLayawayII'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I38333_VerfiyCashChangeOnLayawayII.java
---