Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038320Openbravo ERPZ. Otherspublic2018-04-10 21:002018-04-11 17:17
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038320: API-Change for removal of 4 obsolete fop-related reports (RptM_Inout, RptM_Movement, RptC_Settlement, PromissoryNote)
DescriptionAll those 4 reports are still using the old obsolete FOP rendering technology and not jasperreports.

- RptM_Inout has an ad_process entry but it is not referenced anywhere in pi
- Rpt_Movement has an ad_process entry but it is not referenced anywhere in pi
- RptC_Settlement
  - is referenced in a window deactivated by default related to the old pre-aprm flow
  - Apart this fop report is broken since 2016 and nobody noticed/reported it since then
- PromissoryNote report is also used only in 2 tabs deactivated by default and related to the old pre-aprm flow.

Checking all modules did not find any users in any module referencing them.

So in short risk for this api change should be very low.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
related to defect 0038321 closed shuehner Retail Modules Retail issue to update all 3 retail sampledata's in relation to 4 ad_process deletions in pi. 
related to feature request 0037875 closed shuehner Openbravo ERP Delete report RptM_Inout (based on old fop, not used) 
related to feature request 0037876 closed shuehner Openbravo ERP Delete report RptM_Movement (based on old fop, no ad_menu, not used for printing) 
related to feature request 0037880 closed shuehner Openbravo ERP Remove broken report "Settlement", used in print button of old-flow window "Settlement" (pre-aprm), as uses obsolete fop 
related to feature request 0037881 closed shuehner Openbravo ERP Remove report "Promissory Note" based on old fop technology and only use for old pre-aprm flow in deactivated window. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-10 21:00shuehnerNew Issue
2018-04-10 21:00shuehnerAssigned To => shuehner
2018-04-10 21:00shuehnerModules => Core
2018-04-10 21:00shuehnerTriggers an Emergency Pack => No
2018-04-10 21:00shuehnerRelationship addedrelated to 0037875
2018-04-10 21:00shuehnerRelationship addedrelated to 0037876
2018-04-10 21:00shuehnerRelationship addedrelated to 0037880
2018-04-10 21:00shuehnerRelationship addedrelated to 0037881
2018-04-10 21:02shuehnerNote Added: 0103789
2018-04-10 21:05shuehnerTag Attached: Approved
2018-04-10 21:13hgbotCheckin
2018-04-10 21:13hgbotNote Added: 0103790
2018-04-10 21:13hgbotStatusnew => resolved
2018-04-10 21:13hgbotResolutionopen => fixed
2018-04-10 21:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^]
2018-04-10 21:18shuehnerReview Assigned To => vmromanos
2018-04-10 21:51hgbotCheckin
2018-04-10 21:51hgbotNote Added: 0103800
2018-04-10 21:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^] => http://code.openbravo.com/erp/devel/api-checks/rev/9dbfcefcae0b140a1aed57e81e1beab679887091 [^]
2018-04-11 14:11hgbotCheckin
2018-04-11 14:11hgbotNote Added: 0103810
2018-04-11 17:15vmromanosRelationship addedrelated to 0038321
2018-04-11 17:17vmromanosNote Added: 0103829
2018-04-11 17:17vmromanosStatusresolved => closed
2018-04-11 17:17vmromanosFixed in Version => 3.0PR18Q3

Notes
(0103789)
shuehner   
2018-04-10 21:02   
Note: This API change has been discussed by mail with DME & VMA and got OK to go ahead from both in the mail thread -> Adding Approved marker here accordingly.

For checking modules the following search have been done in download of all publishes modules to ensure no 'relevant references'. While (see below) a few text-matches are present none really relates to the deletes topics from this issue:
Notes: 37875 -> RptM_inout
grep -Ir RptM_Inout
-> find many text-revs but all for jrxml (not touched here) + custom stuff
grep -Ir '\[117\]' | grep AD_PROCESS_ID
grep -Ir 800794

Notes: 37876 -> RptM_Movement
-> find several text-revs but all for jrxml (not touched here) + custom stuff
grep -Ir 80050
-> none for process_id
grep -Ir 800882

Notes: 37880 -> RptC_Settlement
grep -Ir RptC_Settlement
grep -Ir 800070 | grep AD_PROCESS_ID
grep -Ir 800830

Notes: 37881 -> RptPromissoryNote
grep -Ir RptPromissoryNote
grep -Ir 800101 | grep AD_PROCESS_ID
grep -Ir 800874
(0103790)
hgbot   
2018-04-10 21:13   
Repository: erp/devel/api-checks
Changeset: 95f5cb00d058ffe77344232ac76c5baa5498b8de
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 21:06:18 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/95f5cb00d058ffe77344232ac76c5baa5498b8de [^]

Fixed 38320. Api-check commit for removal 4 obsolete reports.

---
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M model/src-db/database/sourcedata/AD_PROCESS.xml
---
(0103800)
hgbot   
2018-04-10 21:51   
Repository: erp/devel/api-checks
Changeset: 9dbfcefcae0b140a1aed57e81e1beab679887091
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Apr 10 21:51:11 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/9dbfcefcae0b140a1aed57e81e1beab679887091 [^]

Fixed 38320. 2nd part of ack removed java files.

Previous commit forgot to acknowledge the planned removal of 4 classes in api,
but had only touched the model part.

---
M java/reference/java.japi.gz
---
(0103810)
hgbot   
2018-04-11 14:11   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata
Changeset: c80b01a2ccdbd0d54366722aa86171f060a0ede3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Apr 11 14:11:41 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/rev/c80b01a2ccdbd0d54366722aa86171f060a0ede3 [^]

Related to issue 38320: removed process access after API change in 18Q3

---
M referencedata/sampledata/AWO_QA/AD_PROCESS_ACCESS.xml
---
(0103829)
vmromanos   
2018-04-11 17:17   
API-check job successfully passed.
AWO sampledata adapted too and mod-awo successfully passed.