0038307: Wrong negative correction amount when trx has no unit cost adjustments

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038307

Openbravo ERP

04. Warehouse management

public

2018-04-10 13:46

2018-05-17 21:41

Reporter

gorkaion

Assigned To

gorkaion

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q3

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038307: Wrong negative correction amount when trx has no unit cost adjustments

Description

Consider a receipt with a NO unit cost adjustment (a Landed Cost or Manual adjustment). If this receipt has to be also adjusted with the Negative Stock Correction the NO unit cost adjustment amount is not properly considered in the calculations and the effect in the Average Cost of the adjustment is lost.

When calculating the transaction price it should consider all adjustments except other negative stock corrections.

For example:

Scenario 1:

Receipt 1. 10 ud at 10EUR each. Avg Cost 10EUR/ud. (Trx Amt: 100EUR)
Shipment 1. -15 ud. (Trx Amt: -150EUR)
Receipt 2. 10 ud at 10EUR each. Landed Cost of 50EUR. (Trx Amt: 150EUR)

In this scenario the expected Avg Cost should be the price of the Receipt 2 taking into account the landed cost (100EUR+50EUR)/10 = 15 EUR/Ud.

But if Negative Stock Correction is enabled the trx Price is calculated considering only the Unit Cost adjustments so the average is reverted to 10EUR/Ud.

Scenario 2:
Receipt 1. 10 ud at 10EUR each. Avg Cost 10EUR/ud. (Trx Amt: 100EUR)
Shipment 1. -15 ud. (Trx Amt: -150EUR)
Receipt 2. 10 ud at 12EUR each. Landed Cost of 50EUR. (Trx Amt: 170EUR)

In this case the Price of the Receipt 2 should be 170EUR/10Ud = 17EUR/ud.That is the average cost that should be left after the negative stock correction.

Steps To Reproduce

1. In Costing Rules window enable the Fix Backdated Transaction for 2018 in the rule of F&B Spain.
2. In Preferences window add a new preference using property "Enable Negative Stock Corrections" and value "Y" for everyone.
Logout and login.
3. Create a new Product "Test" in F&B Spain with price 10EUR.
4. Create a Physical Inventory of 10ud with cost 10EUR.
5. Create another Physical Inventory that adds another 10ud with cost 10EUR and movement date 5 days after the first inventory.
6. Execute the Costing Background process.
7. In Product -> Transactions tab for the New product. Select the second inventory transaction and add a Manual Cost Adjustment. Amount 50EUR, incremental: Yes, unit cost: No.
8. Check that the costing of the inventory changes to 12.5 EUR/Ud.
9. Create a shipment with movement date between both physical inventories. Add the Test Product, quantity 15 Ud.
10. Execute the Costing Background process.
11. Check the Costing tab of the product and see that the second average cost has changed to 10EUR/Ud.
12. Check the Transaction Costs of the second inventory and see that there is a line related to a negative correction of -50EUR which should be -25EUR. To ensure that the average cost is 15EUR as the price of the inventory plus the manual adjustment.

Proposed Solution

When calculating the trxPrice we should also add the adjustment amounts that have Unit Cost = No and Is Negative Correction = No.

Or alternatively calculate it using the trxCost and subtracting the adjustment amounts with Unit Cost = No and Is Negative Correction = Yes

Additional Information