Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038300Openbravo ERPY. DBSourceManagerpublic2018-04-08 18:192018-05-09 19:29
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038300: export.database still reads from old obsolete ad_system_info.code_revision field
DescriptionSafety mechanism to not accidentally overwrite file changes during export.database has been changed a long time ago from 'mercurial revision' to md5 checksum of files.
See DBSMOBUtil.verifyCheckSum call in ExportDatabase code

However if the checksum comparison fails the code did still read and display the older obsolete ad_system_info.code_revision field.

As the new md5 value is not useful to do anything specific with for the user remove printing the old code_revision without replacing it with printing the new md5 checksum value from config/checksums file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0037500 closed shuehner Stop running 'hg id' during ant tasks (install.source & compilation) 
Attached Files? 38300.hgexport (5,174) 2018-04-08 20:07
https://issues.openbravo.com/file_download.php?file_id=11716&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-04-08 18:19shuehnerNew Issue
2018-04-08 18:19shuehnerAssigned To => platform
2018-04-08 18:19shuehnerModules => Core
2018-04-08 18:19shuehnerTriggers an Emergency Pack => No
2018-04-08 18:19shuehnerRelationship addedblocks 0037500
2018-04-08 18:49shuehnerAssigned Toplatform => shuehner
2018-04-08 20:07shuehnerFile Added: 38300.hgexport
2018-04-13 15:07hgbotCheckin
2018-04-13 15:07hgbotNote Added: 0103882
2018-04-13 15:07hgbotStatusnew => resolved
2018-04-13 15:07hgbotResolutionopen => fixed
2018-04-13 15:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3 [^]
2018-04-13 15:14hgbotCheckin
2018-04-13 15:14hgbotNote Added: 0103883
2018-04-13 15:15caristuReview Assigned To => caristu
2018-04-13 15:15caristuStatusresolved => closed
2018-04-13 15:15caristuFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104382

Notes
(0103882)
hgbot   
2018-04-13 15:07   
Repository: erp/devel/dbsm-main
Changeset: 7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Apr 08 18:21:36 2018 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/7f5e9e478b3725dc7ab1ce0f23ba6dcd29c883e3 [^]

fixes issue 38300: Remove using/showing obsolete ad_system_info.code_revision

Export.database safety to not overwrite files is using md5 checksum for files
for a long time. However there was a leftover of printing the old obsolete
ad_system_info.code_revision which is hereby removed.

Commit also removes the longer unused verifyRevision call on top of the
getDBRevision.

---
M src/org/openbravo/ddlutils/task/ExportDatabase.java
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
(0103883)
hgbot   
2018-04-13 15:14   
Repository: erp/devel/pi
Changeset: 734cd2862d3429fe5aed4019d107e8ce007b99df
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Apr 13 15:12:34 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/734cd2862d3429fe5aed4019d107e8ce007b99df [^]

related to issue 38300: update DBSM .jar file

---
M src-db/database/lib/dbsourcemanager.jar
---
(0104382)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test