Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038280Openbravo ERP07. Sales managementpublic2018-04-05 12:282018-05-09 19:29
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038280: Relation between product and services is not copied when cloning a sales order
DescriptionRelation between product and services is not copied by Copy Record process of Sales Order window
Steps To ReproduceAs group admin role:
   Create a new product:
      Product Type: Service
      Linked to Product: Y
      Included Products: Only those defined
      Quantity Rule: As per product
   Add a sales price to it
   Launch Relate Products process and select a product

   Create a new sales order
   Add both service product and related product to it
   Select service product line and launch Select Order Line process
   Select the other line and Done
   Check the relation is shown in Related Services and Related Products subtabs
   Book it

   Launch the Copy record process of the toolbar
   Check the relation is not shown in Related Products subtab and Related Services subtab is not shown as it does not have any record
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037938 new Triage Omni OMS Documentation about Linked To Product checkbox in Product window is missing 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-05 12:28ngarciaNew Issue
2018-04-05 12:28ngarciaAssigned To => Triage Finance
2018-04-05 12:28ngarciaModules => Core
2018-04-05 12:28ngarciaResolution time => 1524693600
2018-04-05 12:28ngarciaTriggers an Emergency Pack => No
2018-04-05 12:29ngarciaRelationship addedrelated to 0037938
2018-04-05 12:29ngarciaIssue Monitored: networkb
2018-04-05 18:02dmiguelezAssigned ToTriage Finance => collazoandy4
2018-04-06 21:46collazoandy4Statusnew => scheduled
2018-04-10 16:30collazoandy4Note Added: 0103776
2018-04-18 11:04hgbotCheckin
2018-04-18 11:04hgbotNote Added: 0103965
2018-04-18 11:04hgbotStatusscheduled => resolved
2018-04-18 11:04hgbotResolutionopen => fixed
2018-04-18 11:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f6bccb4de4db098cb5070c30755b575d04fb228d [^]
2018-04-18 11:04hgbotCheckin
2018-04-18 11:04hgbotNote Added: 0103966
2018-04-18 11:05dmiguelezReview Assigned To => dmiguelez
2018-04-18 11:05dmiguelezNote Added: 0103967
2018-04-18 11:05dmiguelezStatusresolved => closed
2018-04-18 11:05dmiguelezFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104388
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104389

Notes
(0103776)
collazoandy4   
2018-04-10 16:30   
Test Plan
  Go to Product window and create a new record:
    Search Key/Name: 38280
    Product Type: Service
    Linked to Product: Y
    Included Products: Only those defined
    Quantity Rule: As per product
    Add a sales price to it
    Launch Relate Products process and select five products
  Create a new sales order
   Add a new line with the service product created
   Add five more lines with all the products related to the service created
   Select service product line and launch Select Order Line process
   Select all the lines and Done
   Check the relation is shown in Related Services and Related Products subtabs
   Book it
  Launch the Copy record process of the toolbar and check the cloned order shown the relations in Related Services and Related Products subtabs.
  Remove the product service line
  Add a new line with the service product
  Launch the Copy record process of the toolbar and check the cloned order shown the relations in Related Services and Related Products subtabs.
  Launch the Copy record process of the toolbar and check the cloned order shown the relations in Related Services and Related Products subtabs.
(0103965)
hgbot   
2018-04-18 11:04   
Repository: erp/devel/pi
Changeset: f6bccb4de4db098cb5070c30755b575d04fb228d
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Apr 09 17:16:08 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/f6bccb4de4db098cb5070c30755b575d04fb228d [^]

Fixes issue 38280:Relation between product and services is not copied when
cloning a sales order

Relation between product and services is not copied by Copy Record process of
Sales Order window

The Copy Record process now take into account the relation between product and
services

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
---
(0103966)
hgbot   
2018-04-18 11:04   
Repository: erp/devel/pi
Changeset: 0d6f2565e5fc0558004353eaf89cf74b64c6a3dc
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Apr 17 15:59:58 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0d6f2565e5fc0558004353eaf89cf74b64c6a3dc [^]

Related to issue 38280. Code Review changes

* Removed unnecessary save, flush, refresh
* Changed variable name
* Formatted code

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/CloneOrderActionHandler.java
---
(0103967)
dmiguelez   
2018-04-18 11:05   
Code Review + Testing Ok
(0104388)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test
(0104389)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test