0038203: Permanently adjusted transactions wrongly included in Cost Adjustment process.

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0038203

Openbravo ERP

04. Warehouse management

public

2018-03-22 17:22

2018-05-09 19:29

Reporter

gorkaion

Assigned To

AtulOpenbravo

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR18Q3

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0038203: Permanently adjusted transactions wrongly included in Cost Adjustment process.

Description

When a Transaction is Permanently Adjusted its Unit Cost should not change anymore.

In some scenarios when the Cost Adjustment Process is searching related transactions it is not checking if the transaction is permanently adjusted. Later the process end with errors as it is not possible to adjust the unit cost of these kind of transactions.

For example. If a "Movement To" transaction of a Goods Movements is permanently adjusted when the "Movement From" transaction is adjusted the "To" transaction should not be included in the Cost Adjustment.

When this error happens it is not possible to adjust any transaction before the permanently adjusted transaction as any Cost Adjustment Process will finish in this error.

Steps To Reproduce

1. Go to Goods Movement window and create a new header.
2. Add a line of Cerveza Ale and move 100 Uds from RN-0-0-0 to RN-1-0-0
3. Go to Product window and select Cerveza Ale.
4. On the Transactions tab search the Movement To transaction related to the Goods Movement recently processed.
5. Click on Manual Cost Adjustment and process it with following data:
** If the button is not visible go to Process Request and ensure that Costing Background Process is executed and that the goods movement transaction has its cost calculated.
- Amount: 140 (something different than current total cost)
- Date: leave default.
- Incremental: false.
6. Check that the transaction now has the Is Cost Permanent flag true.
7. Now select the previous receipt in the transactions tab:
10000467 - 12-12-2017 - Bebidas Alegres, S.L. - 10
8. Add a Manual Cost Adjustment
- Amount: 50000
- Date: leave default.
- Incremental: true.
9. Check that the process fails and it is not possible to fix it.
It is not possible to process a Cost Adjustment that includes lines of transactions whose cost is permanently adjusted.\nLines: 50
- Unit Cost: false.

Proposed Solution

In the method CostingAlgorithmAdjustmentImp.addCostDependingTrx()

Check that the related transactions are not permanently adjusted before inserting the new Cost Adjustment Line.

The methods that have to be reviewed are:

      searchReturnShipments(costAdjLine);
      searchVoidInOut(costAdjLine);
      searchIntMovementTo(costAdjLine);
      searchVoidInternalConsumption(costAdjLine);
      searchBOMProducts(costAdjLine);
      searchManufacturingProduced(costAdjLine);
      searchOpeningInventory(costAdjLine);

Ideally a warning could be raised to the user.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0038202		closed	AtulOpenbravo	Wrong error management in Process Price Difference Adjustment
related to	defect	0038307		closed	gorkaion	Wrong negative correction amount when trx has no unit cost adjustments