Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0038202Openbravo ERP04. Warehouse managementpublic2018-03-22 17:102018-05-09 19:29
gorkaion 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
3.0PR18Q3 
aferraz
Core
No
0038202: Wrong error management in Process Price Difference Adjustment
When a Price Difference adjustment is generated using the process "Process Price Difference Adjustment. If there is an error in the process the error is shown to the user but no rollback is done leaving inconsistent data.
These steps require that issue 0038203 is not fixed:

1. Go to Goods Movement window and create a new header.
2. Add a line of Cerveza Ale and move 100 Uds from RN-0-0-0 to RN-1-0-0
3. Go to Product window and select Cerveza Ale.
4. On the Transactions tab search the Movement To transaction related to the Goods Movement recently processed.
5. Click on Manual Cost Adjustment and process it with following data:
** If the button is not visible go to Process Request and ensure that Costing Background Process is executed and that the goods movement transaction has its cost calculated.
- Amount: 140 (something different than current total cost)
- Date: leave default.
- Incremental: false.
6. Check that the transaction now has the Is Cost Permanent flag true.
7. Go to Purchase Invoice 10001142 and unpost and reactivate it.
8. On the Cerveza Ale line change the price to 3.
9. Process the Invoice again.
10. Go to Process Price Difference Adjustment and set:
- Organization F&B España
- Movement Date 1-12-2017
- Product Cerveza Ale
11. Click done.
12. The process ends with an error It is not possible to process a Cost Adjustment that includes lines of transactions whose cost is permanently adjusted.\nLines: 50
13. Go to the Cost Adjustment window and check that there is a cost adjustment created for the Price Difference process in Draft Status.
Add a rollback in the catch block of PriceDifferenceByDateProcess java class.
No tags attached.
related to defect 0038203 closed AtulOpenbravo Permanently adjusted transactions wrongly included in Cost Adjustment process. 
Issue History
2018-03-22 17:10gorkaionNew Issue
2018-03-22 17:10gorkaionAssigned To => Triage Finance
2018-03-22 17:10gorkaionModules => Core
2018-03-22 17:10gorkaionResolution time => 1523484000
2018-03-22 17:10gorkaionTriggers an Emergency Pack => No
2018-03-22 17:11ngarciaIssue Monitored: ngarcia
2018-03-22 17:23gorkaionSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=16915#r16915
2018-03-22 17:24gorkaionRelationship addedrelated to 0038203
2018-03-22 17:39dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2018-04-08 19:37AtulOpenbravoStatusnew => scheduled
2018-04-10 19:42AtulOpenbravoNote Added: 0103786
2018-04-11 14:16hgbotCheckin
2018-04-11 14:16hgbotNote Added: 0103811
2018-04-11 14:16hgbotStatusscheduled => resolved
2018-04-11 14:16hgbotResolutionopen => fixed
2018-04-11 14:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/73788ba5c162e248f4f345871003d03e127ff22d [^]
2018-04-11 14:18aferrazReview Assigned To => aferraz
2018-04-11 14:18aferrazNote Added: 0103813
2018-04-11 14:18aferrazStatusresolved => closed
2018-04-11 14:18aferrazFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104369

Notes
(0103786)
AtulOpenbravo   
2018-04-10 19:42   
Test Plan

Assuming issue 0038203 is not fixed:

1. Go to Goods Movement window and create a new header.
2. Add a line of Cerveza Ale and move 100 Uds from RN-0-0-0 to RN-1-0-0
3. Go to Product window and select Cerveza Ale.
4. On the Transactions tab search the Movement To transaction related to the Goods Movement recently processed.
5. Click on Manual Cost Adjustment and process it with following data:
   ** If the button is not visible go to Process Request and ensure that Costing Background Process is executed and that the goods movement transaction has its cost calculated.
   - Amount: 140 (something different than current total cost)
   - Date: leave default.
   - Incremental: false.
6. Check that the transaction now has the Is Cost Permanent flag true.
7. Go to Purchase Invoice 10001142 and unpost and reactivate it.
8. On the Cerveza Ale line change the price to 3.
9. Process the Invoice again.
10. Go to Process Price Difference Adjustment and set:
   - Organization F&B España
   - Movement Date 1-12-2017
   - Product Cerveza Ale
11. Click done.
12. Go to the Cost Adjustment window and check that there is no cost adjustment created for the Price Difference process in Draft Status.
(0103811)
hgbot   
2018-04-11 14:16   
Repository: erp/devel/pi
Changeset: 73788ba5c162e248f4f345871003d03e127ff22d
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Apr 10 19:19:32 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/73788ba5c162e248f4f345871003d03e127ff22d [^]

Fixes Issue 38202:Process Price Difference Adjustment creates a draft
cost adjustment record when there is error in process it.

Added rollback in catch when there is error in processing
cost adjustment to avoid creation of draft adjustment

---
M src/org/openbravo/costing/PriceDifferenceByDateProcess.java
---
(0103813)
aferraz   
2018-04-11 14:18   
Code review + Testing OK
(0104369)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test