Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038198Openbravo ERP05. Production managementpublic2018-03-22 14:582018-05-09 19:29
Reporterngarcia 
Assigned Tocollazoandy4 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket926
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038198: Required Quantity in Work Effort - Production Run is rounded to Integer, decimals are removed
DescriptionRequired Quantity in Work Effort - Production Run is rounded to Integer, decimals are removed

M_ProductionPlan.Neededquantity has Integer Reference instead of Quantity. Besides, in CreateWorkEffort class the value is being rounded:

productionPlan.setRequiredQuantity(requeriedQty.longValue());
Steps To ReproduceAs group admin role:
   Create a product, set is as Production
   Add a storage bin in Manufacturing plan
   Create a Process Plan, Version and Operation
   Add the previously created product as P+
   Create a Work Requirement for that Process Plan
   Quantity: 6.5
   Process Work Requirement
   Create Work Effort from it
   Go to Work Effort - Production Run tab and check Required Quantity shows 6 (it should be 6.5)

   Delete the Production Run
   Create a new one
   Select the WR Phase
   Check the Required Quantity shows 6 (an it should be 6.5)
Proposed SolutionAttached a possible patch to be reviewed
Additional Information
TagsNo tags attached.
Relationships
depends on defect 00382923.0PR18Q3 closed dmiguelez API Change Request: Change Required Quantity in Work Effort Reference from Integer to BigDecimal 
Attached Filespatch 38198.patch (2,707) 2018-03-22 14:59
https://issues.openbravo.com/file_download.php?file_id=11668&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-03-22 14:58ngarciaNew Issue
2018-03-22 14:58ngarciaAssigned To => Triage Finance
2018-03-22 14:58ngarciaOBNetwork customer => Yes
2018-03-22 14:58ngarciaModules => Core
2018-03-22 14:58ngarciaSupport ticket => 926
2018-03-22 14:58ngarciaResolution time => 1523484000
2018-03-22 14:58ngarciaTriggers an Emergency Pack => No
2018-03-22 14:59ngarciaFile Added: 38198.patch
2018-03-22 14:59ngarciaIssue Monitored: networkb
2018-03-22 17:39dmiguelezAssigned ToTriage Finance => collazoandy4
2018-03-23 20:47collazoandy4Statusnew => scheduled
2018-03-26 16:41collazoandy4Note Added: 0103512
2018-04-05 14:50martinsdanIssue Monitored: martinsdan
2018-04-05 17:08hgbotCheckin
2018-04-05 17:08hgbotNote Added: 0103694
2018-04-05 17:08hgbotStatusscheduled => resolved
2018-04-05 17:08hgbotResolutionopen => fixed
2018-04-05 17:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d27b7f54d0daf8885ffd9da4b6c51c7dbd572097 [^]
2018-04-05 17:08dmiguelezReview Assigned To => dmiguelez
2018-04-05 17:08dmiguelezNote Added: 0103695
2018-04-05 17:08dmiguelezStatusresolved => closed
2018-04-05 17:08dmiguelezFixed in Version => 3.0PR18Q3
2018-04-06 09:49dmiguelezNote Added: 0103708
2018-04-06 09:49dmiguelezStatusclosed => new
2018-04-06 09:49dmiguelezResolutionfixed => open
2018-04-06 09:49dmiguelezFixed in Version3.0PR18Q3 =>
2018-04-06 10:18dmiguelezStatusnew => scheduled
2018-04-06 19:00dmiguelezNote Added: 0103725
2018-04-06 19:00dmiguelezRelationship addedrelated to 0038292
2018-04-09 15:52vmromanosRelationship replaceddepends on 0038292
2018-04-12 12:39hgbotCheckin
2018-04-12 12:39hgbotNote Added: 0103833
2018-04-12 12:39hgbotCheckin
2018-04-12 12:39hgbotNote Added: 0103835
2018-04-12 12:39hgbotStatusscheduled => resolved
2018-04-12 12:39hgbotResolutionopen => fixed
2018-04-12 12:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d27b7f54d0daf8885ffd9da4b6c51c7dbd572097 [^] => http://code.openbravo.com/erp/devel/pi/rev/9bf688e01cf861193a690e49a513620454ec19fa [^]
2018-04-12 12:41aferrazNote Added: 0103836
2018-04-12 12:41aferrazStatusresolved => closed
2018-04-12 12:41aferrazFixed in Version => 3.0PR18Q3
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104364
2018-05-09 19:29hudsonbotCheckin
2018-05-09 19:29hudsonbotNote Added: 0104374

Notes
(0103512)
collazoandy4   
2018-03-26 16:41   
Test Plan
  As group admin role:
   Create a product, set is as Production
   Add a storage bin in Manufacturing plan
   Create a Process Plan, Version and Operation
   Add the previously created product as P+
   Create a Work Requirement for that Process Plan
   Quantity: 6.5
   Process Work Requirement
   Create Work Effort from it
   Go to Work Effort - Production Run tab and check Required Quantity shows the correct value 6.5

   Delete the Production Run
   Create a new one
   Select the WR Phase
   Check the Required Quantity shows 6.5 (the corect one)
(0103694)
hgbot   
2018-04-05 17:08   
Repository: erp/devel/pi
Changeset: d27b7f54d0daf8885ffd9da4b6c51c7dbd572097
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Mar 23 16:18:56 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d27b7f54d0daf8885ffd9da4b6c51c7dbd572097 [^]

Fixes issue 38198: Required Quantity in Work Effort - Production Run is rounded
to Integer, decimals are removed

The required quantity in work efforts can be decimals, a long value was set and
the decimals are removed even if the work requeriment quantity is decimal

The Required Quantity in work efforts was change to quantity reference to allows
decimal values.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateWorkEffort.java
---
(0103695)
dmiguelez   
2018-04-05 17:08   
Code Review + Testing Ok
(0103708)
dmiguelez   
2018-04-06 09:49   
There has been an API Change not properly managed.

Reopened until API Change is handled.
(0103725)
dmiguelez   
2018-04-06 19:00   
Pending API Change to be approved:

https://issues.openbravo.com/view.php?id=38292 [^]
(0103833)
hgbot   
2018-04-12 12:39   
Repository: erp/devel/api-checks
Changeset: 168ba08168554a7092f5117638f0ce7dab363c16
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Apr 12 12:35:54 2018 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/168ba08168554a7092f5117638f0ce7dab363c16 [^]

Fixes issue 38292: API change for issue 38198

---
M java/reference/java.japi.gz
---
(0103835)
hgbot   
2018-04-12 12:39   
Repository: erp/devel/pi
Changeset: 9bf688e01cf861193a690e49a513620454ec19fa
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Fri Mar 23 16:18:56 2018 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/9bf688e01cf861193a690e49a513620454ec19fa [^]

Fixes issue 38198: Required Quantity in Work Effort - Production Run is rounded
to Integer, decimals are removed

The required quantity in work efforts can be decimals, a long value was set and
the decimals are removed even if the work requeriment quantity is decimal

The Required Quantity in work efforts was change to quantity reference to allows
decimal values.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateWorkEffort.java
---
(0103836)
aferraz   
2018-04-12 12:41   
Pushed and closed again after pushing the API change.
(0104364)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test
(0104374)
hudsonbot   
2018-05-09 19:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2be7d3efe606 [^]
Maturity status: Test